Commit 59afb8ff authored by Glen Ditchfield's avatar Glen Ditchfield 🐛
Browse files

Preserve sorting in the ListView

When an incidence editor changes an incidence, the ListViews in the
Event View and the Search Dialog update, and re-sort themselves by
the starting date in ascending order, overriding the user's choice.

This patch tracks changes to the view's sort column and order, and
also saves them in the application settings.

BUG: 441530
parent 2a459703
Pipeline #77050 failed with stage
in 2 minutes and 2 seconds
......@@ -115,6 +115,8 @@ public:
QDate mStartDate;
QDate mEndDate;
DateList mSelectedDates;
int mSortColumn = StartDateTime_Column;
Qt::SortOrder mSortOrder = Qt::AscendingOrder;
// if it's non interactive we disable context menu, and incidence editing
bool mIsNonInteractive;
......@@ -298,6 +300,8 @@ ListView::ListView(const Akonadi::ETMCalendar::Ptr &calendar, QWidget *parent, b
QOverload<const QModelIndex &>::of(&ListView::defaultItemAction));
QObject::connect(d->mTreeWidget, &QTreeWidget::customContextMenuRequested, this, &ListView::popupMenu);
QObject::connect(d->mTreeWidget, &QTreeWidget::itemSelectionChanged, this, &ListView::processSelectionChange);
QObject::connect(d->mTreeWidget->header(), &QHeaderView::sortIndicatorChanged,
this, &ListView::slotSortIndicatorChanged);
......@@ -342,7 +346,7 @@ void ListView::updateView()
for (int col = StartDateTime_Column; col < Dummy_EOF_Column; ++col) {
d->mTreeWidget->sortItems(StartDateTime_Column, Qt::AscendingOrder);
d->mTreeWidget->sortItems(d->mSortColumn, d->mSortOrder);
void ListView::showDates(const QDate &start, const QDate &end, const QDate &preferredMonth)
......@@ -495,6 +499,12 @@ ListViewItem *ListView::Private::getItemForIncidence(const Akonadi::Item &aitem)
return nullptr;
void ListView::slotSortIndicatorChanged(int logicalIndex, Qt::SortOrder order)
d->mSortColumn = logicalIndex;
d->mSortOrder = order;
void ListView::defaultItemAction(const QModelIndex &index)
if (!d->mIsNonInteractive) {
......@@ -532,6 +542,8 @@ void ListView::readSettings(KConfig *config)
KConfigGroup cfgGroup = config->group("ListView Layout");
const QByteArray state = cfgGroup.readEntry("ViewState", QByteArray());
d->mSortColumn = cfgGroup.readEntry("SortColumn", static_cast<int>(StartDateTime_Column));
d->mSortOrder = static_cast<Qt::SortOrder>(cfgGroup.readEntry("SortOrder", static_cast<int>(Qt::AscendingOrder)));
void ListView::writeSettings(KConfig *config)
......@@ -540,6 +552,8 @@ void ListView::writeSettings(KConfig *config)
KConfigGroup cfgGroup = config->group("ListView Layout");
cfgGroup.writeEntry("ViewState", state);
cfgGroup.writeEntry("SortColumn", d->mSortColumn);
cfgGroup.writeEntry("SortOrder", static_cast<int>(d->mSortOrder));
void ListView::processSelectionChange()
......@@ -68,6 +68,8 @@ protected Q_SLOTS:
void processSelectionChange();
void slotSortIndicatorChanged(int logicalIndex, Qt::SortOrder order);
class Private;
Private *const d;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment