GitLab

The agenda view displays non-recurring to-dos on their due date, and at
their due time-of-day if they are not all-day todos.  However, it displays
all-day recurring to-dos on their *start* date, and other recurring to-dos on
their *start* date but at their *due* time-of-day.

This patch displays all to-dos on their due date.

The agenda view displays non-recurring all-day to-dos that are not overdue
on the day before their due date.  Recurring to-dos and non-all-day to-dos
are displayed correctly, on their due dates.

`displayIncidence()` deliberately displays to-dos due at midnight in the
event view at the end of the previous day, but that should not be done for
all-day to-dos.  This patch adds an all-day check.

The patch opportunistically removes two `setTime()` calls that duplicate
work done in initializers, and tidies a third.

BUG: 338302

BUG: 417982

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
If one creates a Todo inside KOrganizer, it sets some default generated UID.
Such UID can be changed by the resource afterwards. The model should handle this case.

This patch adds a simple check: if the uid has changed inside `onDataChange, then just update the hashes.

Test Plan:
1) Add a Todo to Google Tasklist
2) Add a subtodo instantly (without reloading the view)
3) (without patch) Subtodo is added at the top level (parent was not recognized)
4) (with patch) Subtodo is added below the parent todo

Reviewers: dvratil

Subscribers: kde-pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D28436

Summary:
When creating a subtodo of an existing task, it should belong to the same collection.

Apparenly, there was a typo: parent collection was determined, but not passed to `createIncidence` call.
Just fix it.

Test Plan:
1) Open KOrganizer todo list, select an existing todo
2) Enter new todo description in the text widget below the list, press Ctrl+Enter
3) (without patch) It asks for a collection despite attempting to create a sub-todo
4) (with patch) A sub-todo gets created in the same collection

Reviewers: dvratil

Subscribers: kde-pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D28434

now we don't see "Failed to remove" messages on
successful incidence deletions.

Reviewers: mlaurent

Reviewed By: mlaurent

Subscribers: kde-pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D28013

GIT_SILENT: Prepare 5.14.0 beta1. Update ecm as 5.67.0 is broken see 417396. 5.68 will be release in 2 days. But dependancy freeze is tomorrow.