GitLab

Glen Ditchfield authored Dec 24, 2020 and Glen Ditchfield committed Jan 02, 2021

 * `IncidenceDateTime::load(Todo::Ptr)` did not cause
   `startDateChanged` to be emitted when the start date changed, so
   the recurrence rule editor did not recalculate its menus; see
   bug 430651.
 * If the start date's year changes, the recurrence rule menus must be
   recalculated, because the number of days in February differs
   between leap years and non-leap years.
 * In comparison to `load(Event::Ptr)`, `load(ToDo::Ptr)` did not make
   connections to `updateStartTime` in several circumstances, so
   changing the start date did not cause matching changes to the end
   date.

BUG: 430651

FIXED-IN: 5.16.1

The Monthly recurrence rule pull-down correctly lists December 30 as
"the 2nd to last day", but the Yearly rule pull-down incorrectly lists it as
"the 1st to last day of December".

Allow to use UNITY build see https://cmake.org/cmake/help/latest/prop_tgt/UNITY_BUILD.html (Reduce compile time. Need cmake 3.16.0)

This only sounds like a recipe for security issues, with no good use
case. Looking at the history in the kde4 kdepim repo is difficult
because of rewrites of the class, but it really looks like this was
a boolean-trap victim, the initial "true" in runURL() was about
'tempFile', not about 'runExecutables'.