1. 29 Aug, 2017 1 commit
  2. 26 Aug, 2017 2 commits
    • Denis Kurz's avatar
      Remove obsolete load method · 64b85dad
      Denis Kurz authored
      Summary:
      The default implementation of load in IncidenceEditor already
      does what we did here: nothing.
      
      Test Plan:
      Compiles. I also played around with changing some events randomly,
      both categories and/or other changes, also this diff should effectively
      be a no-op.
      
      Reviewers: #kde_pim, dvratil
      
      Reviewed By: #kde_pim, dvratil
      
      Tags: #kde_pim
      
      Differential Revision: https://phabricator.kde.org/D7552
      64b85dad
    • Laurent Montel's avatar
      GIT_SILENT: Prepare 5.6.1 · 8b3d8b1e
      Laurent Montel authored
      8b3d8b1e
  3. 25 Aug, 2017 4 commits
    • Denis Kurz's avatar
      Prevent tag name vs gid confusion · b8077150
      Denis Kurz authored
      Summary:
      The old code relied on the display name of the tags of the item provided
      via load(const Akonadi::Item&) being set, but those aren't actually
      fetched. This led IncidenceCategories to believe that an item's
      categories are the gids of its tags. Saving the item without confirming
      the category dialog (e.g. by only modifying the description) led to this
      gid being written back to Akonadi. Opening the item again afterwards
      then even leads to a corresponding Akonadi tag being created.
      
      We reduce state in IncidenceEditor, stop matching Tags twice a
      row (in onTagsFetched and matchExistingCategories), and rely more on
      incidence->categories(), where no gid confusion exists.
      
      BUG: 373257
      FIXED-IN: 5.6.1
      
      Test Plan:
      I editted multiple events in KOrganizer, modifying categories or
      description or title of the event, or all of them in one change.
      For categories, I tried to set related subsets of my tags (a sub-
      or superset of the previously selected tags), or completely unrelated
      sets (deselecting all selected, and selecting previously other ones
      instead). All changes were saved as expected, and no gid-named
      categories were created in the process.
      
      Reviewers: #kde_pim, dvratil
      
      Reviewed By: #kde_pim, dvratil
      
      Subscribers: dvratil
      
      Tags: #kde_pim
      
      Differential Revision: https://phabricator.kde.org/D7548
      b8077150
    • Denis Kurz's avatar
      Remove unused getter method · add5866a
      Denis Kurz authored
      Test Plan:
      It compiles; projects depending on IncidenceEditor compile, too.
      The methods are neither signals nor slots, so they are not used
      in a string-based connect. In summary: they are actually not used
      anywhere
      
      Reviewers: #kde_pim, dvratil
      
      Reviewed By: #kde_pim, dvratil
      
      Tags: #kde_pim
      
      Differential Revision: https://phabricator.kde.org/D7550
      add5866a
    • Denis Kurz's avatar
      Remove unused EditorItemManager methods · 931ac9fb
      Denis Kurz authored
      Summary:
      The methods (set)fetchScope were never used. They also violate
      encapsulation: setting an arbitrary fetch scopes might lead to some
      features not being fetched that are required by IncidenceDialog to work
      correctly, like item tags including tag names.
      
      Test Plan:
      It compiles; projects depending on IncidenceEditor compile, too.
      The methods are neither signals nor slots, so they are not used
      in a string-based connect. In summary: they are actually not used
      anywhere
      
      Reviewers: #kde_pim, dvratil
      
      Reviewed By: #kde_pim, dvratil
      
      Tags: #kde_pim
      
      Differential Revision: https://phabricator.kde.org/D7549
      931ac9fb
    • Denis Kurz's avatar
      Fix wrong API comment · 8cdc303b
      Denis Kurz authored
      Summary:
      The load method only requires item to be valid, and then fetches it
      unconditionally to make sure all required data like tags are present.
      
      Test Plan: Just a change in comments; no testing done
      
      Reviewers: #kde_pim, dvratil
      
      Reviewed By: #kde_pim, dvratil
      
      Tags: #kde_pim
      
      Differential Revision: https://phabricator.kde.org/D7551
      8cdc303b
  4. 23 Aug, 2017 1 commit
  5. 22 Aug, 2017 1 commit
  6. 18 Aug, 2017 1 commit
  7. 11 Aug, 2017 1 commit
  8. 07 Aug, 2017 1 commit
  9. 04 Aug, 2017 1 commit
  10. 30 Jul, 2017 1 commit
  11. 22 Jul, 2017 1 commit
  12. 15 Jul, 2017 1 commit
  13. 13 Jul, 2017 1 commit
  14. 08 Jul, 2017 2 commits
  15. 07 Jul, 2017 3 commits
  16. 06 Jul, 2017 1 commit
  17. 26 Jun, 2017 1 commit
  18. 23 Jun, 2017 1 commit
  19. 22 Jun, 2017 1 commit
  20. 21 Jun, 2017 2 commits
  21. 19 Jun, 2017 1 commit
  22. 15 Jun, 2017 1 commit
  23. 14 Jun, 2017 1 commit
  24. 13 Jun, 2017 1 commit
  25. 11 Jun, 2017 1 commit
  26. 09 Jun, 2017 1 commit
  27. 08 Jun, 2017 1 commit
  28. 07 Jun, 2017 1 commit
  29. 04 Jun, 2017 1 commit
  30. 01 Jun, 2017 1 commit
  31. 24 May, 2017 1 commit
  32. 15 May, 2017 1 commit