1. 01 Apr, 2022 1 commit
    • Glen Ditchfield's avatar
      Preserve datetimes of incidences created from templates · ba964b3b
      Glen Ditchfield authored
      When the editor applies a template, as identified by the "isTemplate"
      property, it (usually) does not copy its start/end/due datetimes;  it
      keeps the datetimes set before the template was applied.  Unfortunately
      when the instance is saved it still has the "isTemplate" property, and
      so when it is edited the editor does not copy its datetimes; the GUI
      fields are left with default values.  Removing the property fixes the
      bug.
      
      BUG: 332048
      ba964b3b
  2. 20 Mar, 2022 1 commit
    • Glen Ditchfield's avatar
      Synchronize "floating" status of date-times · b14b742a
      Glen Ditchfield authored and David Faure's avatar David Faure committed
      RFC5545 states that the DTEND and DUE properties must be specified with
      local ("floating") times if and only if DTSTART is local.  This patch
      ensures that the incidence editor obeys that rule by setting the two
      timezone combo boxes to the same time zone if either of them changes to
      or from the "floating" time zone.
      
      - `updateStartSpec()` and `updateEndSpec()` synchronize the combo boxes.
      - `enableStartEdit()` and `enableEndEdit()` no longer change time zones
        when a todo's start or due time is enabled or disabled.  Disabling
        one would set both to "floating"!
      - `identical()` ensures that all changes to time zones are detected.
      
      @dfaure
      b14b742a
  3. 19 Mar, 2022 1 commit
  4. 06 Mar, 2022 1 commit
    • David Faure's avatar
      KTimeZoneComboBox: fix support for floating events · ac3e1df0
      David Faure authored and Allen Winter's avatar Allen Winter committed
      12:00 my time can be either
       * floating if timeSpec() == Qt::LocalTime
       * non-floating if timeSpec() == Qt::TimeZone (in which case the system timezone is set)
      
      KTimeZoneComboBox didn't distinguish the two, returning systemTimeZone()
      in both cases. This commit adds new API that works with QDateTimes so
      that the combo can read/write both timeSpec() and timeZone().
      ac3e1df0
  5. 23 Nov, 2021 1 commit
  6. 20 May, 2021 1 commit
  7. 26 Jan, 2021 1 commit
  8. 02 Jan, 2021 1 commit
    • Glen Ditchfield's avatar
      Handle changes to start dates of recurring to-dos · 5c9c45bb
      Glen Ditchfield authored and Glen Ditchfield's avatar Glen Ditchfield committed
       * `IncidenceDateTime::load(Todo::Ptr)` did not cause
         `startDateChanged` to be emitted when the start date changed, so
         the recurrence rule editor did not recalculate its menus; see
         bug 430651.
       * If the start date's year changes, the recurrence rule menus must be
         recalculated, because the number of days in February differs
         between leap years and non-leap years.
       * In comparison to `load(Event::Ptr)`, `load(ToDo::Ptr)` did not make
         connections to `updateStartTime` in several circumstances, so
         changing the start date did not cause matching changes to the end
         date.
      
      BUG: 430651
      
      FIXED-IN: 5.16.1
      5c9c45bb
  9. 01 Nov, 2020 1 commit
    • Glen Ditchfield's avatar
      Detect invalid start and end times · 701db76d
      Glen Ditchfield authored
      If the user enters an invalid string such as "25:00" into the start time field
      or the end/due time field, IncidenceDateTime does not detect it, because the
      QDateTime constructor used by currentStartDateTime() and currentEndDateTime()
      treats it as "00:00".
      
      This patch
       * detects and reports the error,
       * uses more specific error messages,
       * focuses on the erroneous field, and
       * logs at "debug" level, because the problem isn't very big.
      
      CCBUG: 409912
      701db76d
  10. 12 Aug, 2020 1 commit
  11. 01 May, 2020 1 commit
  12. 26 Mar, 2020 1 commit
  13. 15 Feb, 2020 1 commit
  14. 25 Dec, 2019 1 commit
  15. 26 Aug, 2019 1 commit
  16. 31 Jul, 2019 1 commit
  17. 17 Nov, 2018 1 commit
  18. 11 Oct, 2018 1 commit
    • Denis Kurz's avatar
      Fix keyboard editting of start/end times of VTODOs · 10056772
      Denis Kurz authored
      Summary:
      Editting start/end times of VTODOs using only the keyboard did not
      trigger a check whether the VTODO is dirty. If other fields were updated
      along with start/end times, everything was fine, but only editting those
      times was simply ignored. The patch causes a dirty check for keyboard
      edits of the corresponding KTimeComboBoxes.
      
      BUG: 391769
      FIXED-IN: 5.9.3
      
      Test Plan:
      I changed start and end times of a test VTODO. Without the patch,
      the change was not saved when hitting OK, nor did I hit my dirty-check
      breakpoint. With the patch, everything works as expected: Keyboard editting
      results in an updated VTODO, as verified via the Month View tooltip and by
      opening the IncidenceEditor again for that VTODO. VEVENTs do not have this
      problem even without the patch.
      
      Reviewers: #kde_pim, winterz
      
      Reviewed By: #kde_pim, winterz
      
      Subscribers: kde-pim
      
      Tags: #kde_pim
      
      Differential Revision: https://phabricator.kde.org/D16114
      10056772
  19. 08 Jul, 2018 1 commit
  20. 15 Jun, 2018 1 commit
  21. 05 Apr, 2018 1 commit
  22. 13 Sep, 2017 2 commits
  23. 12 Sep, 2017 1 commit
  24. 11 Sep, 2017 1 commit
  25. 10 Sep, 2017 1 commit
  26. 09 Sep, 2017 1 commit
  27. 21 Jun, 2017 1 commit
  28. 08 Jun, 2017 1 commit
  29. 02 Jan, 2017 2 commits
  30. 02 Apr, 2016 2 commits
  31. 09 Dec, 2015 2 commits