GitLab

This broke adding new events in KOrganizer.

Glen Ditchfield authored Mar 30, 2022 and Glen Ditchfield committed Apr 04, 2022

With version 5.19.3, using the keyboard to move between the Calendar and
Summary fields is a bit off.

* Generally the user must press `Tab` or `Shift-Tab` twice.  Removing
  some properties from the Category label fixes that, and also removes
  an underline from the 'd' in the 'Calendar' label.

* If the Attachments tab is visible, the user must press the key three
  times;  focus moves to the attachment list before reaching the final
  destination.  Adding a `setTabOrder()` fixes that.

BUG: 331543

Glen Ditchfield authored Apr 02, 2022 and David Faure committed Apr 02, 2022

Creating all-day to-dos by right-clicking in the month view or in the
all-day area of the agenda view caused an assertion failure, "editor
shouldn't be dirty", because the timeSpec of an all-day event is not
rigorously defined.  This patch codes around the problem and imitates
the "dirty" logic for events.

@dfaure

When the editor applies a template, as identified by the "isTemplate"
property, it (usually) does not copy its start/end/due datetimes;  it
keeps the datetimes set before the template was applied.  Unfortunately
when the instance is saved it still has the "isTemplate" property, and
so when it is edited the editor does not copy its datetimes; the GUI
fields are left with default values.  Removing the property fixes the
bug.

BUG: 332048

This was always needed, but calendarsupport was bringing it transitively
before:
calendarsupport@32878677

Glen Ditchfield authored Mar 20, 2022 and David Faure committed Mar 20, 2022

RFC5545 states that the DTEND and DUE properties must be specified with
local ("floating") times if and only if DTSTART is local.  This patch
ensures that the incidence editor obeys that rule by setting the two
timezone combo boxes to the same time zone if either of them changes to
or from the "floating" time zone.

- `updateStartSpec()` and `updateEndSpec()` synchronize the combo boxes.
- `enableStartEdit()` and `enableEndEdit()` no longer change time zones
  when a todo's start or due time is enabled or disabled.  Disabling
  one would set both to "floating"!
- `identical()` ensures that all changes to time zones are detected.

@dfaure

Glen Ditchfield authored Mar 20, 2022 and David Faure committed Mar 20, 2022

As with new events, new todos and journal entries should not have
floating date-times by default;  use the system time zone instead.

@dfaure