Commit 2d53e559 authored by David Faure's avatar David Faure

IncidenceAttachment: don't allow running executables

This only sounds like a recipe for security issues, with no good use
case. Looking at the history in the kde4 kdepim repo is difficult
because of rewrites of the class, but it really looks like this was
a boolean-trap victim, the initial "true" in runURL() was about
'tempFile', not about 'runExecutables'.
parent 60483fb4
Pipeline #43841 passed with stage
in 8 minutes and 39 seconds
......@@ -275,7 +275,6 @@ void IncidenceAttachment::showAttachment(QListWidgetItem *item)
KIO::OpenUrlJob *job = new KIO::OpenUrlJob(attitem->tempFileForAttachment(), att.mimeType());
job->setUiDelegate(new KIO::JobUiDelegate(KJobUiDelegate::AutoHandlingEnabled, mAttachmentView));
job->setDeleteTemporaryFile(true);
job->setRunExecutables(true);
job->start();
}
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment