Commit 931ac9fb authored by Denis Kurz's avatar Denis Kurz
Browse files

Remove unused EditorItemManager methods

Summary:
The methods (set)fetchScope were never used. They also violate
encapsulation: setting an arbitrary fetch scopes might lead to some
features not being fetched that are required by IncidenceDialog to work
correctly, like item tags including tag names.

Test Plan:
It compiles; projects depending on IncidenceEditor compile, too.
The methods are neither signals nor slots, so they are not used
in a string-based connect. In summary: they are actually not used
anywhere

Reviewers: #kde_pim, dvratil

Reviewed By: #kde_pim, dvratil

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D7549
parent 8cdc303b
......@@ -386,18 +386,6 @@ void EditorItemManager::save()
}
}
void EditorItemManager::setFetchScope(const Akonadi::ItemFetchScope &fetchScope)
{
Q_D(ItemEditor);
d->mFetchScope = fetchScope;
}
Akonadi::ItemFetchScope &EditorItemManager::fetchScope()
{
Q_D(ItemEditor);
return d->mFetchScope;
}
void EditorItemManager::setIsCounterProposal(bool isCounterProposal)
{
Q_D(ItemEditor);
......
......@@ -83,32 +83,6 @@ public:
*/
void save();
/**
* Sets the item fetch scope.
*
* Controls how much of an item's data is fetched from the server, e.g.
* whether to fetch the full item payload or only meta data.
*
* @param fetchScope The new scope for item fetch operations.
*
* @see fetchScope()
*/
void setFetchScope(const Akonadi::ItemFetchScope &fetchScope);
/**
* Returns the item fetch scope.
*
* Since this returns a reference it can be used to conveniently modify the
* current scope in-place, i.e. by calling a method on the returned reference
* without storing it in a local variable. See the ItemFetchScope documentation
* for an example.
*
* @return a reference to the current item fetch scope
*
* @see setFetchScope() for replacing the current item fetch scope
*/
Akonadi::ItemFetchScope &fetchScope();
/**
* Returns the collection where the last item was created.
* Or an invalid collection if none was created.
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment