Code quality fixes

src/commandoptions.cpp

@@ -81,7 +81,7 @@ bool convInterval(const QString& timeParam, KARecurrence::Type&, int& timeInterv
 class CommandOptions::Private
 {
 public:
-    Private(CommandOptions* parent)
+    explicit Private(CommandOptions* parent)
         : p(parent)
     {}
     bool    checkCommand(Option, Command, EditAlarmDlg::Type = EditAlarmDlg::NO_TYPE);

src/commandoptions.h

@@ -39,6 +39,8 @@ public:
     QStringList setOptions(QCommandLineParser*, const QStringList& args);
     static CommandOptions* firstInstance()        { return mFirstInstance; }
     CommandOptions();
+    CommandOptions(CommandOptions&) = delete;
+    CommandOptions& operator=(CommandOptions&) = delete;
     void                parse();
     void                process();
     Command             command() const           { return mCommand; }

src/editdlg.cpp

 /*
  *  editdlg.cpp  -  dialog to create or modify an alarm or alarm template
  *  Program:  kalarm
- *  SPDX-FileCopyrightText: 2001-2021 David Jarvie <djarvie@kde.org>
+ *  SPDX-FileCopyrightText: 2001-2022 David Jarvie <djarvie@kde.org>
  *
  *  SPDX-License-Identifier: GPL-2.0-or-later
  */
@@ -906,8 +906,8 @@ void EditAlarmDlg::closeEvent(QCloseEvent* ce)
 */
 void EditAlarmDlg::slotResize()
 {
-    QSize s = mTabScrollGroup->adjustSize(true);
-    s = minimumSizeHint();
+    mTabScrollGroup->adjustSize(true);
+    const QSize s = minimumSizeHint();
     if (height() > s.height())
     {
         // Resize to slightly greater than the minimum height.

src/kalarmapp.cpp

@@ -404,7 +404,6 @@ int KAlarmApp::activateInstance(const QStringList& args, const QString& workingD
     int exitCode = 0;               // default = success
     static bool firstInstance = true;
     bool dontRedisplay = false;
-    CommandOptions::Command command = CommandOptions::NONE;
     if (!firstInstance  ||  !isSessionRestored())
     {
         options->process();
@@ -412,7 +411,7 @@ int KAlarmApp::activateInstance(const QStringList& args, const QString& workingD
         if (options->simulationTime().isValid())
             KAlarm::setSimulatedSystemTime(options->simulationTime());
 #endif
-        command = options->command();
+        CommandOptions::Command command = options->command();
         if (options->disableAll())
             setAlarmsEnabled(false);   // disable alarm monitoring
 

src/resourceselector.cpp

@@ -285,6 +285,8 @@ void ResourceSelector::selectionChanged()
 */
 void ResourceSelector::initActions(KActionCollection* actions)
 {
+    if (mActionReload)
+        return;   // this function can only be called once
     mActionReload      = new QAction(QIcon::fromTheme(QStringLiteral("view-refresh")), i18nc("@action Reload calendar", "Re&load"), this);
     actions->addAction(QStringLiteral("resReload"), mActionReload);
     connect(mActionReload, &QAction::triggered, this, &ResourceSelector::reloadResource);