Revert function-args-by-value clazy fixes

The clazy config in .gitlab-ci.yml doesn't specify function-args-by-value
(deliberately).

src/functions.cpp

@@ -1059,7 +1059,7 @@ void editNewAlarm(EditAlarmDlg::Type type, QWidget* parent)
 {
     editNewAlarm(type, QDate(), parent);
 }
-void editNewAlarm(EditAlarmDlg::Type type, QDate startDate, QWidget* parent)
+void editNewAlarm(EditAlarmDlg::Type type, const QDate& startDate, QWidget* parent)
 {
     EditAlarmDlg* editDlg = EditAlarmDlg::create(false, type, parent);
     if (editDlg)
@@ -1118,7 +1118,7 @@ void editNewAlarm(const KAEvent& preset, const QDate& startDate, QWidget* parent
 /******************************************************************************
 * Common code for editNewAlarm() variants.
 */
-void execNewAlarmDlg(EditAlarmDlg* editDlg, QDate startDate)
+void execNewAlarmDlg(EditAlarmDlg* editDlg, const QDate& startDate)
 {
     if (startDate.isValid())
     {
@@ -1872,7 +1872,7 @@ bool convertTimeString(const QByteArray& timeString, KADateTime& dateTime, const
 * "UTC". If no time zone is specified, it defaults to the local time zone.
 * If 'defaultDt' is valid, it supplies the time spec and default date.
 */
-KADateTime applyTimeZone(const QString& tzstring, QDate date, QTime time,
+KADateTime applyTimeZone(const QString& tzstring, const QDate& date, const QTime& time,
                          bool haveTime, const KADateTime& defaultDt)
 {
     bool error = false;

src/functions.h

@@ -75,7 +75,7 @@ MainWindow*         displayMainWindowSelected(const QString& eventId);
 
 bool                editNewAlarm(const QString& templateName, QWidget* parent = nullptr);
 void                editNewAlarm(EditAlarmDlg::Type, QWidget* parent = nullptr);
-void                editNewAlarm(EditAlarmDlg::Type, QDate startDate, QWidget* parent = nullptr);
+void                editNewAlarm(EditAlarmDlg::Type, const QDate& startDate, QWidget* parent = nullptr);
 void                editNewAlarm(KAEvent::SubAction, QWidget* parent = nullptr, const AlarmText* = nullptr);
 void                editNewAlarm(const KAEvent& preset, QWidget* parent = nullptr);
 void                editNewAlarm(const KAEvent& preset, const QDate& startDate, QWidget* parent = nullptr);
@@ -86,7 +86,7 @@ void                viewAlarm(const KAEvent&, QWidget* parent = nullptr);
 void                editNewTemplate(EditAlarmDlg::Type, QWidget* parent = nullptr);
 void                editNewTemplate(const KAEvent& preset, QWidget* parent = nullptr);
 void                editTemplate(KAEvent&, QWidget* parent = nullptr);
-void                execNewAlarmDlg(EditAlarmDlg*, QDate startDate = QDate());
+void                execNewAlarmDlg(EditAlarmDlg*, const QDate& startDate = QDate());
 /** Create a "New From Template" QAction */
 KToggleAction*      createAlarmEnableAction(QObject* parent);
 QAction*            createStopPlayAction(QObject* parent);
@@ -309,7 +309,7 @@ bool                setRtcWakeTime(unsigned triggerTime, QWidget* parent);
 
 bool                convertTimeString(const QByteArray& timeString, KADateTime& dateTime,
                                   const KADateTime& defaultDt = KADateTime(), bool allowTZ = true);
-KADateTime          applyTimeZone(const QString& tzstring, QDate date, QTime time,
+KADateTime          applyTimeZone(const QString& tzstring, const QDate& date, const QTime& time,
                                    bool haveTime, const KADateTime& defaultDt = KADateTime());
 
 #ifndef NDEBUG

src/preferences.cpp

@@ -330,7 +330,7 @@ void Preferences::holidaysChange(const QString& regionCode)
     Q_EMIT mInstance->holidaysChanged(holidays());
 }
 
-void Preferences::setStartOfDay(QTime t)
+void Preferences::setStartOfDay(const QTime& t)
 {
     if (t != self()->mBase_StartOfDay.time())
     {

src/preferences.h

@@ -56,12 +56,12 @@ public:
     static const KHolidays::HolidayRegion& holidays();
     static void             setHolidayRegion(const QString& regionCode);
     static QTime            startOfDay()                     { return self()->mBase_StartOfDay.time(); }
-    static void             setStartOfDay(QTime);
+    static void             setStartOfDay(const QTime&);
     static QTime            workDayStart()                   { return self()->mBase_WorkDayStart.time(); }
     static QTime            workDayEnd()                     { return self()->mBase_WorkDayEnd.time(); }
     static QBitArray        workDays();
-    static void             setWorkDayStart(QTime t)  { self()->setBase_WorkDayStart(QDateTime(QDate(1900,1,1), t)); }
-    static void             setWorkDayEnd(QTime t)    { self()->setBase_WorkDayEnd(QDateTime(QDate(1900,1,1), t)); }
+    static void             setWorkDayStart(const QTime& t)  { self()->setBase_WorkDayStart(QDateTime(QDate(1900,1,1), t)); }
+    static void             setWorkDayEnd(const QTime& t)    { self()->setBase_WorkDayEnd(QDateTime(QDate(1900,1,1), t)); }
     static void             setWorkDays(const QBitArray&);
     static bool             quitWarn()                       { return mUsingDefaults ? self()->base_QuitWarn() : notifying(QUIT_WARN); }
     static void             setQuitWarn(bool yes)            { setNotify(QUIT_WARN, yes); }