Commit 77392bcf authored by David Jarvie's avatar David Jarvie
Browse files

Fix cppcheck warnings

parent 9ce69fac
Pipeline #167945 passed with stage
in 1 minute and 36 seconds
......@@ -84,7 +84,7 @@ int AkonadiPlugin::birthdayModelEnum(BirthdayModelValue value) const
* Send an email via Akonadi.
*/
QString AkonadiPlugin::sendMail(KMime::Message::Ptr message, const KIdentityManagement::Identity& identity,
const QString normalizedFrom, bool keepSentMail, MailSend::JobData& jobdata)
const QString& normalizedFrom, bool keepSentMail, MailSend::JobData& jobdata)
{
if (!mSendAkonadiMail)
{
......
......@@ -35,7 +35,7 @@ public:
* @return empty string if sending initiated successfully, else error message.
*/
QString sendMail(KMime::Message::Ptr message, const KIdentityManagement::Identity& identity,
const QString normalizedFrom, bool keepSentMail, MailSend::JobData& jobdata) override;
const QString& normalizedFrom, bool keepSentMail, MailSend::JobData& jobdata) override;
/** Extract dragged and dropped Akonadi RFC822 message data.
* @param url the dropped URL.
......
......@@ -43,7 +43,7 @@ SendAkonadiMail* SendAkonadiMail::instance()
* = error message if the message was not sent.
*/
QString SendAkonadiMail::send(KMime::Message::Ptr message, const KIdentityManagement::Identity& identity,
const QString normalizedFrom, bool keepSentMail, JobData& jobdata)
const QString& normalizedFrom, bool keepSentMail, JobData& jobdata)
{
qCDebug(AKONADIPLUGIN_LOG) << "SendAkonadiMail::send: Sending via KDE";
MailTransport::TransportManager* manager = MailTransport::TransportManager::self();
......
......@@ -27,7 +27,7 @@ class SendAkonadiMail : public QObject
public:
static SendAkonadiMail* instance();
static QString send(KMime::Message::Ptr message, const KIdentityManagement::Identity& identity,
const QString normalizedFrom, bool keepSentMail, MailSend::JobData& jobdata);
const QString& normalizedFrom, bool keepSentMail, MailSend::JobData& jobdata);
Q_SIGNALS:
/** Emitted when a send job has been queued. */
......
......@@ -47,7 +47,7 @@ public:
* @return empty string if sending initiated successfully, else error message.
*/
virtual QString sendMail(KMime::Message::Ptr message, const KIdentityManagement::Identity& identity,
const QString normalizedFrom, bool keepSentMail, MailSend::JobData& jobdata) = 0;
const QString& normalizedFrom, bool keepSentMail, MailSend::JobData& jobdata) = 0;
/** Extract dragged and dropped Akonadi RFC822 message data. */
virtual KMime::Message::Ptr fetchAkonadiEmail(const QUrl&, qint64& emailId) = 0;
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment