Commit add31103 authored by David Jarvie's avatar David Jarvie
Browse files

For command alarms, always use path to find executables

QProcess defaults to current directory, which is not what is wanted.
parent 68377ed9
Pipeline #132468 skipped
KAlarm Change Log
=== Version 3.3.5 (KDE Applications 21.12.2) --- 21 January 2022 ===
=== Version 3.3.5 (KDE Applications 21.12.2) --- 31 January 2022 ===
* Fix crash after Defer is selected in alarm notification message [KDE Bug 448212]
* Fix deleted calendar resources reappearing when KAlarm restarts.
* For command alarms, use path to find executables, instead of current directory.
* Fix regression introduced in version 3.1.0:
Make auto-close work for message windows.
......
/*
* shellprocess.cpp - execute a shell process
* Program: kalarm
* SPDX-FileCopyrightText: 2004-2020 David Jarvie <djarvie@kde.org>
* SPDX-FileCopyrightText: 2004-2022 David Jarvie <djarvie@kde.org>
*
* SPDX-License-Identifier: GPL-2.0-or-later
*/
......@@ -45,7 +45,7 @@ bool ShellProcess::start(OpenMode openMode)
connect(this, &QProcess::readyReadStandardOutput, this, &ShellProcess::stdoutReady);
connect(this, &QProcess::readyReadStandardError, this, &ShellProcess::stderrReady);
const QStringList args{ QStringLiteral("-c"), mCommand };
QProcess::start(QLatin1String(shellName()), args, openMode);
QProcess::start(QLatin1String(shellPath()), args, openMode);
if (!waitForStarted())
{
mStatus = START_FAIL;
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment