Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
PIM
KDE PIM Add-ons
Commits
01ced26f
Commit
01ced26f
authored
Jul 12, 2021
by
Laurent Montel
😁
Browse files
Add autotest + make sure that ok button is disabled
parent
b73a20ad
Pipeline
#70055
passed with stage
in 41 minutes and 6 seconds
Changes
6
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
kmail/checkbeforedeletemailplugins/confirmbeforedeleting/autotests/CMakeLists.txt
View file @
01ced26f
...
...
@@ -12,3 +12,4 @@ add_kmail_checkbeforedeleting_unittest(confirmbeforedeletingdialogtest.cpp)
add_kmail_checkbeforedeleting_unittest
(
confirmbeforedeletingwidgettest.cpp
)
add_kmail_checkbeforedeleting_unittest
(
confirmbeforedeletingruletest.cpp
)
add_kmail_checkbeforedeleting_unittest
(
confirmbeforedeletingcreaterulewidgettest.cpp
)
add_kmail_checkbeforedeleting_unittest
(
confirmbeforedeletingcreateruledialogtest.cpp
)
kmail/checkbeforedeletemailplugins/confirmbeforedeleting/autotests/confirmbeforedeletingcreateruledialogtest.cpp
0 → 100644
View file @
01ced26f
/*
SPDX-FileCopyrightText: 2021 Laurent Montel <montel@kde.org>
SPDX-License-Identifier: LGPL-2.0-or-later
*/
#include "confirmbeforedeletingcreateruledialogtest.h"
#include "confirmbeforedeletingcreateruledialog.h"
#include "confirmbeforedeletingcreaterulewidget.h"
#include <QDialogButtonBox>
#include <QPushButton>
#include <QTest>
#include <QVBoxLayout>
QTEST_MAIN
(
ConfirmBeforeDeletingCreateRuleDialogTest
)
ConfirmBeforeDeletingCreateRuleDialogTest
::
ConfirmBeforeDeletingCreateRuleDialogTest
(
QObject
*
parent
)
:
QObject
(
parent
)
{
}
void
ConfirmBeforeDeletingCreateRuleDialogTest
::
shouldHaveDefaultValues
()
{
ConfirmBeforeDeletingCreateRuleDialog
w
;
QVERIFY
(
!
w
.
windowTitle
().
isEmpty
());
auto
mainLayout
=
w
.
findChild
<
QVBoxLayout
*>
(
QStringLiteral
(
"mainlayout"
));
QVERIFY
(
mainLayout
);
auto
mConfirmBeforeDeletingCreateRuleWidget
=
w
.
findChild
<
ConfirmBeforeDeletingCreateRuleWidget
*>
(
QStringLiteral
(
"mConfirmBeforeDeletingCreateRuleWidget"
));
mainLayout
->
addWidget
(
mConfirmBeforeDeletingCreateRuleWidget
);
auto
buttonBox
=
w
.
findChild
<
QDialogButtonBox
*>
(
QStringLiteral
(
"buttonBox"
));
QVERIFY
(
buttonBox
);
auto
okButton
=
buttonBox
->
button
(
QDialogButtonBox
::
Ok
);
QVERIFY
(
!
okButton
->
isEnabled
());
}
kmail/checkbeforedeletemailplugins/confirmbeforedeleting/autotests/confirmbeforedeletingcreateruledialogtest.h
0 → 100644
View file @
01ced26f
/*
SPDX-FileCopyrightText: 2021 Laurent Montel <montel@kde.org>
SPDX-License-Identifier: LGPL-2.0-or-later
*/
#pragma once
#include <QObject>
class
ConfirmBeforeDeletingCreateRuleDialogTest
:
public
QObject
{
Q_OBJECT
public:
explicit
ConfirmBeforeDeletingCreateRuleDialogTest
(
QObject
*
parent
=
nullptr
);
~
ConfirmBeforeDeletingCreateRuleDialogTest
()
override
=
default
;
private
Q_SLOTS
:
void
shouldHaveDefaultValues
();
};
kmail/checkbeforedeletemailplugins/confirmbeforedeleting/confirmbeforedeletingcreateruledialog.cpp
View file @
01ced26f
...
...
@@ -7,6 +7,7 @@
#include "confirmbeforedeletingcreateruledialog.h"
#include <KLocalizedString>
#include <QDialogButtonBox>
#include <QPushButton>
#include <QVBoxLayout>
ConfirmBeforeDeletingCreateRuleDialog
::
ConfirmBeforeDeletingCreateRuleDialog
(
QWidget
*
parent
)
...
...
@@ -25,6 +26,9 @@ ConfirmBeforeDeletingCreateRuleDialog::ConfirmBeforeDeletingCreateRuleDialog(QWi
mainLayout
->
addWidget
(
buttonBox
);
connect
(
buttonBox
,
&
QDialogButtonBox
::
accepted
,
this
,
&
ConfirmBeforeDeletingCreateRuleDialog
::
accept
);
connect
(
buttonBox
,
&
QDialogButtonBox
::
rejected
,
this
,
&
ConfirmBeforeDeletingCreateRuleDialog
::
reject
);
auto
okButton
=
buttonBox
->
button
(
QDialogButtonBox
::
Ok
);
okButton
->
setEnabled
(
false
);
connect
(
mConfirmBeforeDeletingCreateRuleWidget
,
&
ConfirmBeforeDeletingCreateRuleWidget
::
updateOkButton
,
okButton
,
&
QPushButton
::
setEnabled
);
}
ConfirmBeforeDeletingCreateRuleDialog
::~
ConfirmBeforeDeletingCreateRuleDialog
()
...
...
kmail/checkbeforedeletemailplugins/confirmbeforedeleting/confirmbeforedeletingcreaterulewidget.cpp
View file @
01ced26f
...
...
@@ -34,6 +34,9 @@ ConfirmBeforeDeletingCreateRuleWidget::ConfirmBeforeDeletingCreateRuleWidget(QWi
mPatternLineEdit
->
setObjectName
(
QStringLiteral
(
"mPatternLineEdit"
));
mainLayout
->
addWidget
(
mPatternLineEdit
);
fillComboBox
();
connect
(
mPatternLineEdit
,
&
QLineEdit
::
textChanged
,
this
,
[
this
](
const
QString
&
str
)
{
Q_EMIT
updateOkButton
(
!
str
.
trimmed
().
isEmpty
());
});
}
ConfirmBeforeDeletingCreateRuleWidget
::~
ConfirmBeforeDeletingCreateRuleWidget
()
...
...
kmail/checkbeforedeletemailplugins/confirmbeforedeleting/confirmbeforedeletingcreaterulewidget.h
View file @
01ced26f
...
...
@@ -25,6 +25,9 @@ public:
void
setInfo
(
const
ConfirmBeforeDeletingCreateRuleWidget
::
ConfirmBeforeDeletingInfo
&
info
);
Q_SIGNALS:
void
updateOkButton
(
bool
enabled
);
private:
void
fillComboBox
();
QLineEdit
*
const
mPatternLineEdit
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment