From 6d41df37c9ea68a7fd990ee5192a9825c8e00431 Mon Sep 17 00:00:00 2001
From: Laurent Montel <montel@kde.org>
Date: Sun, 27 Sep 2020 18:34:49 +0200
Subject: [PATCH] Use new folderconfiguresettingspagebase

---
 .../folderconfiguresettingsgeneralwidget.cpp        | 13 ++++++-------
 .../folderconfiguresettingsgeneralwidget.h          |  3 ++-
 .../folderconfiguresettingspagebase.cpp             |  1 +
 .../folderconfiguresettingstemplatewidget.cpp       | 11 +++++------
 .../folderconfiguresettingstemplatewidget.h         |  4 +++-
 .../folderconfiguresettingsviewwidget.cpp           | 10 +++++-----
 .../folderconfiguresettingsviewwidget.h             |  4 +++-
 7 files changed, 25 insertions(+), 21 deletions(-)

diff --git a/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingsgeneralwidget.cpp b/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingsgeneralwidget.cpp
index 1399d7e9..9cffd463 100644
--- a/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingsgeneralwidget.cpp
+++ b/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingsgeneralwidget.cpp
@@ -9,15 +9,12 @@
 #include <QVBoxLayout>
 
 FolderConfigureSettingsGeneralWidget::FolderConfigureSettingsGeneralWidget(QWidget *parent)
-    : QWidget(parent)
+    : FolderConfigureSettingsPageBase(parent)
 {
-    QVBoxLayout *mainLayout = new QVBoxLayout(this);
-    mainLayout->setObjectName(QStringLiteral("mainLayout"));
-
     mCollectionGeneralWidget = new MailCommon::CollectionGeneralWidget(this);
     mCollectionGeneralWidget->setObjectName(QStringLiteral("mCollectionGeneralWidget"));
-    mainLayout->addWidget(mCollectionGeneralWidget);
-    mainLayout->addStretch();
+    addMainWidget(mCollectionGeneralWidget);
+    mMainLayout->addStretch();
 }
 
 FolderConfigureSettingsGeneralWidget::~FolderConfigureSettingsGeneralWidget()
@@ -26,5 +23,7 @@ FolderConfigureSettingsGeneralWidget::~FolderConfigureSettingsGeneralWidget()
 
 void FolderConfigureSettingsGeneralWidget::save(Akonadi::Collection &col)
 {
-    mCollectionGeneralWidget->save(col);
+    if (wasModified()) {
+        mCollectionGeneralWidget->save(col);
+    }
 }
diff --git a/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingsgeneralwidget.h b/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingsgeneralwidget.h
index 20edc0a6..235563a2 100644
--- a/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingsgeneralwidget.h
+++ b/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingsgeneralwidget.h
@@ -9,11 +9,12 @@
 
 #include <QWidget>
 #include "folderconfiguresettings_private_export.h"
+#include "folderconfiguresettingspagebase.h"
 #include <AkonadiCore/Collection>
 namespace MailCommon {
 class CollectionGeneralWidget;
 }
-class LIBFOLDERCONFIGURESETTINGS_TESTS_EXPORT FolderConfigureSettingsGeneralWidget : public QWidget
+class LIBFOLDERCONFIGURESETTINGS_TESTS_EXPORT FolderConfigureSettingsGeneralWidget : public FolderConfigureSettingsPageBase
 {
     Q_OBJECT
 public:
diff --git a/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingspagebase.cpp b/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingspagebase.cpp
index 52b41923..d3e91168 100644
--- a/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingspagebase.cpp
+++ b/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingspagebase.cpp
@@ -19,6 +19,7 @@ FolderConfigureSettingsPageBase::FolderConfigureSettingsPageBase(QWidget *parent
     mModifyCheckBox = new QCheckBox(i18n("Modify Settings"), this);
     mModifyCheckBox->setObjectName(QStringLiteral("mModifiedCheckBox"));
     mModifyCheckBox->setChecked(false);
+    mMainLayout->addWidget(mModifyCheckBox);
     connect(mModifyCheckBox, &QCheckBox::clicked, this, &FolderConfigureSettingsPageBase::slotModifyClicked);
 }
 
diff --git a/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingstemplatewidget.cpp b/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingstemplatewidget.cpp
index 25b5dc74..3eb65370 100644
--- a/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingstemplatewidget.cpp
+++ b/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingstemplatewidget.cpp
@@ -9,14 +9,11 @@
 #include <QVBoxLayout>
 
 FolderConfigureSettingsTemplateWidget::FolderConfigureSettingsTemplateWidget(QWidget *parent)
-    : QWidget(parent)
+    : FolderConfigureSettingsPageBase(parent)
 {
-    QVBoxLayout *mainLayout = new QVBoxLayout(this);
-    mainLayout->setObjectName(QStringLiteral("mainLayout"));
-    mainLayout->setContentsMargins(0, 0, 0, 0);
     mCollectionTemplateWidget = new MailCommon::CollectionTemplatesWidget(this);
     mCollectionTemplateWidget->setObjectName(QStringLiteral("mCollectionTemplateWidget"));
-    mainLayout->addWidget(mCollectionTemplateWidget);
+    addMainWidget(mCollectionTemplateWidget);
 }
 
 FolderConfigureSettingsTemplateWidget::~FolderConfigureSettingsTemplateWidget()
@@ -25,5 +22,7 @@ FolderConfigureSettingsTemplateWidget::~FolderConfigureSettingsTemplateWidget()
 
 void FolderConfigureSettingsTemplateWidget::save(Akonadi::Collection &col)
 {
-    mCollectionTemplateWidget->save(col);
+    if (wasModified()) {
+        mCollectionTemplateWidget->save(col);
+    }
 }
diff --git a/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingstemplatewidget.h b/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingstemplatewidget.h
index 7f0b46cd..37146ba3 100644
--- a/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingstemplatewidget.h
+++ b/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingstemplatewidget.h
@@ -7,12 +7,14 @@
 #ifndef FOLDERCONFIGURESETTINGSTEMPLATEWIDGET_H
 #define FOLDERCONFIGURESETTINGSTEMPLATEWIDGET_H
 
+#include "folderconfiguresettingspagebase.h"
+
 #include <QWidget>
 #include <AkonadiCore/Collection>
 namespace MailCommon {
 class CollectionTemplatesWidget;
 }
-class FolderConfigureSettingsTemplateWidget : public QWidget
+class FolderConfigureSettingsTemplateWidget : public FolderConfigureSettingsPageBase
 {
     Q_OBJECT
 public:
diff --git a/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingsviewwidget.cpp b/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingsviewwidget.cpp
index ed9bbea1..d3b11f4c 100644
--- a/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingsviewwidget.cpp
+++ b/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingsviewwidget.cpp
@@ -9,13 +9,11 @@
 #include <QVBoxLayout>
 
 FolderConfigureSettingsViewWidget::FolderConfigureSettingsViewWidget(QWidget *parent)
-    : QWidget(parent)
+    : FolderConfigureSettingsPageBase(parent)
 {
-    QVBoxLayout *mainLayout = new QVBoxLayout(this);
-    mainLayout->setObjectName(QStringLiteral("mainLayout"));
     mCollectionViewWidget = new MailCommon::CollectionViewWidget(this);
     mCollectionViewWidget->setObjectName(QStringLiteral("mCollectionTemplateWidget"));
-    mainLayout->addWidget(mCollectionViewWidget);
+    addMainWidget(mCollectionViewWidget);
 }
 
 FolderConfigureSettingsViewWidget::~FolderConfigureSettingsViewWidget()
@@ -24,5 +22,7 @@ FolderConfigureSettingsViewWidget::~FolderConfigureSettingsViewWidget()
 
 void FolderConfigureSettingsViewWidget::save(Akonadi::Collection &col)
 {
-    mCollectionViewWidget->save(col);
+    if (wasModified()) {
+        mCollectionViewWidget->save(col);
+    }
 }
diff --git a/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingsviewwidget.h b/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingsviewwidget.h
index 72ed3e85..76f29cbc 100644
--- a/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingsviewwidget.h
+++ b/plugins/messageviewerconfigureplugins/foldersettings/folderconfiguresettingsviewwidget.h
@@ -7,12 +7,14 @@
 #ifndef FOLDERCONFIGURESETTINGSVIEWWIDGET_H
 #define FOLDERCONFIGURESETTINGSVIEWWIDGET_H
 
+#include "folderconfiguresettingspagebase.h"
+
 #include <QWidget>
 #include <AkonadiCore/Collection>
 namespace MailCommon {
 class CollectionViewWidget;
 }
-class FolderConfigureSettingsViewWidget : public QWidget
+class FolderConfigureSettingsViewWidget : public FolderConfigureSettingsPageBase
 {
     Q_OBJECT
 public:
-- 
GitLab