Improve confirmbeforedeleting dialog

kmail/checkbeforedeletemailplugins/confirmbeforedeleting/confirmbeforedeletingdialog.cpp

@@ -30,7 +30,7 @@ ConfirmBeforeDeletingDialog::ConfirmBeforeDeletingDialog(QWidget *parent)
     auto buttonBox = new QDialogButtonBox(QDialogButtonBox::Ok | QDialogButtonBox::Cancel, this);
     buttonBox->setObjectName(QStringLiteral("buttonBox"));
     mainLayout->addWidget(buttonBox);
-    connect(buttonBox, &QDialogButtonBox::accepted, this, &ConfirmBeforeDeletingDialog::accept);
+    connect(buttonBox, &QDialogButtonBox::accepted, this, &ConfirmBeforeDeletingDialog::slotSave);
     connect(buttonBox, &QDialogButtonBox::rejected, this, &ConfirmBeforeDeletingDialog::reject);
     readConfig();
 }
@@ -40,6 +40,12 @@ ConfirmBeforeDeletingDialog::~ConfirmBeforeDeletingDialog()
     writeConfig();
 }
 
+void ConfirmBeforeDeletingDialog::slotSave()
+{
+    // TODO
+    accept();
+}
+
 void ConfirmBeforeDeletingDialog::writeConfig()
 {
     KConfigGroup group(KSharedConfig::openStateConfig(), myConfirmBeforeDeletingConfigGroupName);

kmail/checkbeforedeletemailplugins/confirmbeforedeleting/confirmbeforedeletingdialog.h

@@ -16,6 +16,7 @@ public:
     ~ConfirmBeforeDeletingDialog() override;
 
 private:
+    void slotSave();
     void writeConfig();
     void readConfig();
     ConfirmBeforeDeletingWidget *const mConfirmBeforeDeletingWidget;

kmail/checkbeforedeletemailplugins/confirmbeforedeleting/confirmbeforedeletingmanager.cpp

@@ -68,7 +68,7 @@ void ConfirmBeforeDeletingManager::saveRules()
         const QString groupName = defaultGroupName() + QStringLiteral(" #%1").arg(i);
         KConfigGroup group = config->group(groupName);
         const ConfirmBeforeDeletingRule &rule = mRules.at(i);
-        rule.save(group); // TODO
+        rule.save(group);
     }
 }