Add missing Q_REQUIRED_RESULT

plugins/messageviewerplugins/common/expandurlplugin/viewerpluginexpandurl.h

@@ -17,7 +17,7 @@ public:
     explicit ViewerPluginExpandurl(QObject *parent = nullptr, const QList<QVariant> & = QList<QVariant>());
 
     ViewerPluginInterface *createView(QWidget *parent, KActionCollection *ac) override;
-    QString viewerPluginName() const override;
+    Q_REQUIRED_RESULT QString viewerPluginName() const override;
 };
 }
 #endif // VIEWERPLUGINEXPANDURL_H

plugins/messageviewerplugins/common/expandurlplugin/viewerpluginexpandurlinterface.h

@@ -18,9 +18,9 @@ public:
     explicit ViewerPluginExpandurlInterface(KActionCollection *ac, QWidget *parent = nullptr);
     ~ViewerPluginExpandurlInterface() override;
 
-    QList<QAction *> actions() const override;
+    Q_REQUIRED_RESULT QList<QAction *> actions() const override;
     void execute() override;
-    ViewerPluginInterface::SpecificFeatureTypes featureTypes() const override;
+    Q_REQUIRED_RESULT ViewerPluginInterface::SpecificFeatureTypes featureTypes() const override;
 
     void setUrl(const QUrl &url) override;
 private:

plugins/messageviewerplugins/createnoteplugin/noteedit.h

@@ -27,10 +27,10 @@ public:
     explicit NoteEdit(QWidget *parent = nullptr);
     ~NoteEdit() override;
 
-    Akonadi::Collection collection() const;
+    Q_REQUIRED_RESULT Akonadi::Collection collection() const;
     void setCollection(const Akonadi::Collection &value);
 
-    KMime::Message::Ptr message() const;
+    Q_REQUIRED_RESULT KMime::Message::Ptr message() const;
     void setMessage(const KMime::Message::Ptr &value);
 
     void writeConfig();

plugins/messageviewerplugins/createnoteplugin/viewerplugincreatenote.h

@@ -17,7 +17,7 @@ public:
     explicit ViewerPluginCreatenote(QObject *parent = nullptr, const QList<QVariant> & = QList<QVariant>());
 
     ViewerPluginInterface *createView(QWidget *parent, KActionCollection *ac) override;
-    QString viewerPluginName() const override;
+    Q_REQUIRED_RESULT QString viewerPluginName() const override;
 };
 }
 #endif // VIEWERPLUGINCREATENOTE_H

plugins/messageviewerplugins/createnoteplugin/viewerplugincreatenoteinterface.h

@@ -20,22 +20,22 @@ public:
     ~ViewerPluginCreatenoteInterface() override;
 
     void setText(const QString &text) override;
-    QList<QAction *> actions() const override;
+    Q_REQUIRED_RESULT QList<QAction *> actions() const override;
     void setMessage(const KMime::Message::Ptr &value) override;
     void closePlugin() override;
     void showWidget() override;
     void setMessageItem(const Akonadi::Item &item) override;
     void updateAction(const Akonadi::Item &item) override;
-    ViewerPluginInterface::SpecificFeatureTypes featureTypes() const override;
+    Q_REQUIRED_RESULT ViewerPluginInterface::SpecificFeatureTypes featureTypes() const override;
 
 private:
     void slotCreateNote(const KMime::Message::Ptr &notePtr, const Akonadi::Collection &collection);
 
     void slotNoteItemFetched(KJob *job);
-    Akonadi::Relation relatedNoteRelation() const;
+    Q_REQUIRED_RESULT Akonadi::Relation relatedNoteRelation() const;
     void showCreateNewNoteWidget();
     void createAction(KActionCollection *ac);
-    NoteEdit *widget();
+    Q_REQUIRED_RESULT NoteEdit *widget();
 
     Akonadi::Item mMessageItem;
     NoteEdit *mNoteEdit = nullptr;

plugins/messageviewerplugins/createtodoplugin/todoedit.h

@@ -27,10 +27,10 @@ public:
     explicit TodoEdit(QWidget *parent = nullptr);
     ~TodoEdit() override;
 
-    Akonadi::Collection collection() const;
+    Q_REQUIRED_RESULT Akonadi::Collection collection() const;
     void setCollection(const Akonadi::Collection &value);
 
-    KMime::Message::Ptr message() const;
+    Q_REQUIRED_RESULT KMime::Message::Ptr message() const;
     void setMessage(const KMime::Message::Ptr &value);
 
     void writeConfig();

plugins/plasma/pimeventsplugin/akonadipimdatasource.h

@@ -22,9 +22,9 @@ public:
     explicit AkonadiPimDataSource(QObject *parent = nullptr);
     ~AkonadiPimDataSource() override;
 
-    qint64 akonadiIdForIncidence(const KCalendarCore::Incidence::Ptr &incidence) const override;
-    KCalendarCore::Calendar *calendar() const override;
-    QString calendarColorForIncidence(const KCalendarCore::Incidence::Ptr &incidence) const override;
+    Q_REQUIRED_RESULT qint64 akonadiIdForIncidence(const KCalendarCore::Incidence::Ptr &incidence) const override;
+    Q_REQUIRED_RESULT KCalendarCore::Calendar *calendar() const override;
+    Q_REQUIRED_RESULT QString calendarColorForIncidence(const KCalendarCore::Incidence::Ptr &incidence) const override;
 
 private Q_SLOTS:
     void onSettingsChanged();

plugins/plasma/pimeventsplugin/autotests/fakepimdatasource.h

@@ -17,11 +17,11 @@ public:
     ~FakePimDataSource() override;
 
     void setAkonadiIdForIncidence(const KCalendarCore::Incidence::Ptr &incidence, qint64 akonadiId);
-    qint64 akonadiIdForIncidence(const KCalendarCore::Incidence::Ptr &incidence) const override;
+    Q_REQUIRED_RESULT qint64 akonadiIdForIncidence(const KCalendarCore::Incidence::Ptr &incidence) const override;
 
-    KCalendarCore::Calendar *calendar() const override;
+    Q_REQUIRED_RESULT KCalendarCore::Calendar *calendar() const override;
 
-    QString calendarColorForIncidence(const KCalendarCore::Incidence::Ptr &incidence) const override;
+    Q_REQUIRED_RESULT QString calendarColorForIncidence(const KCalendarCore::Incidence::Ptr &incidence) const override;
 
 private:
     QMap<KCalendarCore::Incidence::Ptr, qint64> mAkonadiIdMap;

plugins/plasma/pimeventsplugin/autotests/pimeventsplugintest.h

@@ -32,9 +32,9 @@ private Q_SLOTS:
     void testEventRemoved();
 
 private:
-    bool compareEventDataHashes(const DateEventDataHash &actual, const DateEventDataHash &expected);
-    DateEventDataHash populateCalendar(FakePimDataSource *source, bool uniqueEventData);
-    QVector<CalendarEvents::EventData> findEventData(const KCalendarCore::Event::Ptr &event, const DateEventDataHash &allData);
+    Q_REQUIRED_RESULT bool compareEventDataHashes(const DateEventDataHash &actual, const DateEventDataHash &expected);
+    Q_REQUIRED_RESULT DateEventDataHash populateCalendar(FakePimDataSource *source, bool uniqueEventData);
+    Q_REQUIRED_RESULT QVector<CalendarEvents::EventData> findEventData(const KCalendarCore::Event::Ptr &event, const DateEventDataHash &allData);
 };
 
 #endif

plugins/plasma/pimeventsplugin/autotests/testdataparser.h

@@ -20,13 +20,13 @@ public:
     explicit TestDataParser(const QString &testData, bool uniqueEventData = false);
     ~TestDataParser();
 
-    QDate rangeStart() const;
-    QDate rangeEnd() const;
-    qint64 akonadiId() const;
-    KCalendarCore::Incidence::Ptr incidence() const;
-    QVector<CalendarEvents::EventData> eventData() const;
+    Q_REQUIRED_RESULT QDate rangeStart() const;
+    Q_REQUIRED_RESULT QDate rangeEnd() const;
+    Q_REQUIRED_RESULT qint64 akonadiId() const;
+    Q_REQUIRED_RESULT KCalendarCore::Incidence::Ptr incidence() const;
+    Q_REQUIRED_RESULT QVector<CalendarEvents::EventData> eventData() const;
 
-    static QStringList allTestData();
+    static Q_REQUIRED_RESULT QStringList allTestData();
 
 private:
     void parse();

plugins/plasma/pimeventsplugin/eventdatavisitor.h

@@ -18,17 +18,17 @@ class BaseEventDataVisitor : public KCalendarCore::Visitor
 public:
     ~BaseEventDataVisitor();
 
-    bool act(const KCalendarCore::Incidence::Ptr &incidence);
-    bool act(const KCalendarCore::Event::List &events);
-    bool act(const KCalendarCore::Todo::List &todos);
+    Q_REQUIRED_RESULT bool act(const KCalendarCore::Incidence::Ptr &incidence);
+    Q_REQUIRED_RESULT bool act(const KCalendarCore::Event::List &events);
+    Q_REQUIRED_RESULT bool act(const KCalendarCore::Todo::List &todos);
 
 protected:
     BaseEventDataVisitor(PimDataSource *dataSource, QDate start, QDate end);
 
-    QString generateUid(const KCalendarCore::Incidence::Ptr &incidence, const QDateTime &recurrenceId = {}) const;
-    bool isInRange(QDate start, QDate end) const;
+    Q_REQUIRED_RESULT QString generateUid(const KCalendarCore::Incidence::Ptr &incidence, const QDateTime &recurrenceId = {}) const;
+    Q_REQUIRED_RESULT bool isInRange(QDate start, QDate end) const;
 
-    QVector<CalendarEvents::EventData> explodeIncidenceOccurences(const CalendarEvents::EventData &ed, const KCalendarCore::Incidence::Ptr &incidence, bool &ok);
+    Q_REQUIRED_RESULT QVector<CalendarEvents::EventData> explodeIncidenceOccurences(const CalendarEvents::EventData &ed, const KCalendarCore::Incidence::Ptr &incidence, bool &ok);
 protected:
     PimDataSource *const mDataSource;
     const QDate mStart;

plugins/plasma/pimeventsplugin/eventmodel.h

@@ -23,7 +23,7 @@ public:
     explicit EventModel(QObject *parent = nullptr);
     ~EventModel();
 
-    QVector<Akonadi::Collection> collections() const;
+    Q_REQUIRED_RESULT QVector<Akonadi::Collection> collections() const;
 
     Akonadi::Collection collection(qint64 id) const;
 

plugins/templateparser/templateparseremailaddressrequesterakonadi.h

@@ -21,7 +21,7 @@ public:
     });
     ~TemplateParserEmailAddressRequesterAkonadi() override;
 
-    QString text() const override;
+    Q_REQUIRED_RESULT QString text() const override;
     void setText(const QString &str) override;
     void clear() override;