Const'ify pointer

plugins/messageviewerplugins/externalscriptplugin/viewerpluginexternalscriptparseargument.cpp

@@ -22,6 +22,7 @@ QStringList ViewerPluginExternalScriptParseArgument::parse(const QStringList &sc
     }
 
     QStringList newArguments;
+    newArguments.reserve(scriptArguments.count());
     for (const QString &arg : scriptArguments) {
         if (arg == QLatin1String("%s")) {
             const KMime::Headers::Subject *const subject = mMessage ? mMessage->subject(false) : nullptr;

sieveeditor/emaillineedit/emaillineedit.cpp

@@ -22,19 +22,19 @@ K_PLUGIN_CLASS_WITH_JSON(EmailLineEdit, "emaillineedit.json")
 
 EmailLineEdit::EmailLineEdit(QWidget *parent, const QList<QVariant> &)
     : KSieveUi::AbstractSelectEmailLineEdit(parent)
+    , mLineEdit(new QLineEdit(this))
+    , mEmailButton(new QToolButton(this))
 {
     QHBoxLayout *mainLayout = new QHBoxLayout(this);
     mainLayout->setObjectName(QStringLiteral("mainlayout"));
     mainLayout->setContentsMargins({});
 
-    mLineEdit = new QLineEdit(this);
     mLineEdit->setObjectName(QStringLiteral("lineedit"));
     mLineEdit->setClearButtonEnabled(true);
     mLineEdit->setPlaceholderText(i18n("Click on button for selecting contacts..."));
     connect(mLineEdit, &QLineEdit::textChanged, this, &EmailLineEdit::slotTextChanged);
     mainLayout->addWidget(mLineEdit);
 
-    mEmailButton = new QToolButton(this);
     mEmailButton->setText(i18n("..."));
     mEmailButton->setObjectName(QStringLiteral("emailbutton"));
     mEmailButton->setToolTip(i18n("Select Emails"));

sieveeditor/emaillineedit/emaillineedit.h

@@ -31,8 +31,8 @@ private:
     void verifyAkonadiStatus();
     void akonadiStateChanged(Akonadi::ServerManager::State state);
     QString mNegativeBackground;
-    QLineEdit *mLineEdit = nullptr;
-    QToolButton *mEmailButton = nullptr;
+    QLineEdit *const mLineEdit;
+    QToolButton *const mEmailButton;
     bool mEmailIsValid = false;
 };