Clean up code

kaddressbook/editorpages/cryptopageplugin.cpp

@@ -28,7 +28,6 @@
 #include <Libkleo/Enum>
 
 CryptoPagePlugin::CryptoPagePlugin()
-    : mReadOnly(false)
 {
     KIconLoader::global()->addAppDir(QStringLiteral("libkleopatra"));
 

kmail/editorplugins/insertshorturl/insertshorturlconfiguredialog.cpp

@@ -11,10 +11,10 @@
 
 InsertShorturlConfigureDialog::InsertShorturlConfigureDialog(QWidget *parent)
     : QDialog(parent)
+    , mInsertShortUrlWidget(new InsertShorturlConfigureWidget(this))
 {
     QVBoxLayout *mainLayout = new QVBoxLayout(this);
 
-    mInsertShortUrlWidget = new InsertShorturlConfigureWidget(this);
     mInsertShortUrlWidget->setObjectName(QStringLiteral("insertshorturlwidget"));
     mainLayout->addWidget(mInsertShortUrlWidget);
 

kmail/editorplugins/insertshorturl/insertshorturlconfiguredialog.h

@@ -19,7 +19,7 @@ public:
     void accept() override;
 
 private:
-    InsertShorturlConfigureWidget *mInsertShortUrlWidget = nullptr;
+    InsertShorturlConfigureWidget *const mInsertShortUrlWidget;
 };
 
 #endif // INSERTSHORTURLCONFIGUREDIALOG_H

plugins/plasma/pimeventsplugin/akonadipimdatasource.cpp

@@ -25,13 +25,13 @@ using namespace std::placeholders;
 
 AkonadiPimDataSource::AkonadiPimDataSource(QObject *parent)
     : QObject(parent)
+    , mCalendar(new EventModel(this))
 {
     Akonadi::AttributeFactory::registerAttribute<Akonadi::CollectionColorAttribute>();
 
     connect(SettingsChangeNotifier::self(), &SettingsChangeNotifier::settingsChanged,
             this, &AkonadiPimDataSource::onSettingsChanged);
 
-    mCalendar = new EventModel(this);
 
     onSettingsChanged();
 

plugins/plasma/pimeventsplugin/akonadipimdatasource.h

@@ -30,7 +30,7 @@ private Q_SLOTS:
     void onSettingsChanged();
 
 private:
-    EventModel *mCalendar = nullptr;
+    EventModel *const mCalendar;
     EventViews::PrefsPtr mEventViewsPrefs;
     mutable QHash<qint64, QString> mColorCache;
 };