Add missing Q_REQUIRED_RESULT + const'ify pointer

korganizer/emailaddressselectionldapdialog/emailaddressselectionldapdialog.h

@@ -23,7 +23,7 @@ public:
     explicit EmailAddressSelectionLdapDialog(QWidget *parent = nullptr, const QList<QVariant> & = {});
     ~EmailAddressSelectionLdapDialog() override;
 
-    Akonadi::EmailAddressSelection::List selectedAddresses() const override;
+    Q_REQUIRED_RESULT Akonadi::EmailAddressSelection::List selectedAddresses() const override;
     Akonadi::EmailAddressSelectionWidget *view() const override;
 
 private:

korganizer/plugins/datenums/configdialog.cpp

@@ -23,6 +23,7 @@
 
 ConfigDialog::ConfigDialog(QWidget *parent)
     : QDialog(parent)
+    , mDayNumGroup(new QButtonGroup(this))
 {
     setWindowTitle(i18nc("@title:window", "Configure Day Numbers"));
     auto mainLayout = new QVBoxLayout(this);
@@ -43,7 +44,6 @@ ConfigDialog::ConfigDialog(QWidget *parent)
     topLayout->addWidget(dayNumBox);
     auto groupLayout = new QVBoxLayout(dayNumBox);
 
-    mDayNumGroup = new QButtonGroup(this);
     auto btn = new QRadioButton(i18n("Show day number"), dayNumBox);
     mDayNumGroup->addButton(btn, int(Datenums::DayOfYear));
     groupLayout->addWidget(btn);

korganizer/plugins/datenums/configdialog.h

@@ -28,6 +28,6 @@ protected Q_SLOTS:
     void slotOk();
 
 private:
-    QButtonGroup *mDayNumGroup = nullptr;
+    QButtonGroup *const mDayNumGroup;
 };
 

korganizer/plugins/hebrew/hebrew.h

@@ -21,9 +21,9 @@ public:
 
     void configure(QWidget *parent) override;
 
-    Element::List createDayElements(const QDate &) override;
+    Q_REQUIRED_RESULT Element::List createDayElements(const QDate &) override;
 
-    QString info() const override;
+    Q_REQUIRED_RESULT QString info() const override;
 
 private:
     bool showParsha, showChol, showOmer;

korganizer/plugins/lunarphases/lunarphases.h

@@ -17,10 +17,10 @@ public:
     {
     }
 
-    Element::List createDayElements(const QDate &) override;
-    Element::List createWeekElements(const QDate &) override;
+    Q_REQUIRED_RESULT Element::List createDayElements(const QDate &) override;
+    Q_REQUIRED_RESULT Element::List createWeekElements(const QDate &) override;
 
-    QString info() const override;
+    Q_REQUIRED_RESULT QString info() const override;
 };
 
 class LunarphasesFactory : public DecorationFactory

korganizer/plugins/picoftheday/picoftheday.cpp

@@ -16,6 +16,9 @@
 #include <KLocalizedString>
 
 #include <QDomDocument>
+#include <chrono>
+
+using namespace std::chrono_literals;
 // https://www.mediawiki.org/wiki/API:Picture_of_the_day_viewer
 Picoftheday::Picoftheday()
 {
@@ -312,7 +315,7 @@ QPixmap POTDElement::newPixmap(const QSize &size)
                 disconnect(mTimer, &QTimer::timeout, this, &POTDElement::step3GetThumbnail);
                 connect(mTimer, &QTimer::timeout, this, &POTDElement::step3GetThumbnail);
                 mTimer->setSingleShot(true);
-                mTimer->start(1000);
+                mTimer->start(1s);
             }
         }
     }

korganizer/plugins/picoftheday/picoftheday.h

@@ -19,11 +19,11 @@ public:
     Picoftheday();
     ~Picoftheday() override;
 
-    Element::List createDayElements(const QDate &) override;
+    Q_REQUIRED_RESULT Element::List createDayElements(const QDate &) override;
 
     void configure(QWidget *parent) override;
 
-    QString info() const override;
+    Q_REQUIRED_RESULT QString info() const override;
 
 private:
     QSize mThumbSize;