Clean up code

kmail/editorconvertertextplugins/markdown/markdownlib/markdownhighlighter.h

@@ -23,7 +23,7 @@ protected:
     void applyFormat(int offset, int length, const KSyntaxHighlighting::Format &format) override;
 private:
     QString mCurrentLine;
-    QTextStream *mStream;
+    QTextStream *const mStream;
 };
 
 #endif // MARKDOWNHighlighter_H

kmail/editorinitplugins/externalcomposer/externalcomposerconfiguredialog.cpp

@@ -10,7 +10,6 @@
 
 ExternalComposerConfigureDialog::ExternalComposerConfigureDialog(QWidget *parent)
     : PimCommon::ConfigurePluginDialog(parent)
-    , mConfigureWidget(nullptr)
 {
     setWindowTitle(i18nc("@title:window", "Configure \"External Composer\" Plugin"));
     initLayout();

kmail/grammarplugins/languagetool/src/languagetoolmanager.h

@@ -46,7 +46,7 @@ private:
     QHash<QString, QColor> mGrammarColor;
     QString mLanguage;
     QString mLanguageToolPath;
-    QNetworkAccessManager *mNetworkAccessManager = nullptr;
+    QNetworkAccessManager *const mNetworkAccessManager;
     bool mUseLocalInstance = false;
 };
 

kmail/grammarplugins/languagetool/src/languagetoolresultjob.h

@@ -18,7 +18,7 @@ class LIBLANGUAGETOOLPRIVATE_TESTS_EXPORT LanguageToolResultJob : public QObject
 public:
     explicit LanguageToolResultJob(QObject *parent = nullptr);
     ~LanguageToolResultJob();
-    bool canStart() const;
+    Q_REQUIRED_RESULT bool canStart() const;
     void start();
     Q_REQUIRED_RESULT QStringList arguments() const;
     void setArguments(const QStringList &arguments);

kmailtransport/sendmail/sendmailconfigdialog.cpp

@@ -18,8 +18,6 @@ using namespace MailTransport;
 SendMailConfigDialog::SendMailConfigDialog(MailTransport::Transport *transport, QWidget *parent)
     : QDialog(parent)
     , mTransport(transport)
-    , mConfigWidget(nullptr)
-    , mOkButton(nullptr)
 {
     Q_ASSERT(transport);
     QVBoxLayout *mainLayout = new QVBoxLayout(this);

plugins/customtoolsplugins/translatorplugin/translatorview.cpp

@@ -14,8 +14,6 @@
 
 TranslatorView::TranslatorView(KActionCollection *ac, QWidget *parent)
     : PimCommon::CustomToolsViewInterface(parent)
-    , mAction(nullptr)
-    , mTranslatorWidget(nullptr)
 {
     QHBoxLayout *layout = new QHBoxLayout(this);
     layout->setContentsMargins(0, 0, 0, 0);

plugins/messageviewer/bodypartformatter/calendar/memorycalendarmemento.cpp

@@ -14,7 +14,6 @@ using namespace Akonadi;
 
 MemoryCalendarMemento::MemoryCalendarMemento()
     : QObject(nullptr)
-    , mFinished(false)
 {
     Akonadi::ETMCalendar::Ptr etmCalendar = CalendarSupport::calendarSingleton(/*createIfNull=*/ false);
     if (etmCalendar && etmCalendar->isLoaded()) {

plugins/messageviewer/bodypartformatter/highlighter/highlighter.h

@@ -23,7 +23,7 @@ protected:
     void applyFormat(int offset, int length, const KSyntaxHighlighting::Format &format) override;
 private:
     QString mCurrentLine;
-    QTextStream *mStream;
+    QTextStream *const mStream;
 };
 
 #endif // DIFFHIGHLIGHTER_H

plugins/messageviewerheaderplugins/briefheaderstyleplugin/briefheaderstyleplugin.h

@@ -25,8 +25,8 @@ public:
     HeaderStyleInterface *createView(KActionMenu *menu, QActionGroup *actionGroup, KActionCollection *ac, QObject *parent = nullptr) override;
     QString name() const override;
 private:
-    HeaderStyle *mHeaderStyle = nullptr;
-    HeaderStrategy *mHeaderStrategy = nullptr;
+    HeaderStyle *const mHeaderStyle;
+    HeaderStrategy *const mHeaderStrategy;
 };
 }
 #endif // BRIEFHEADERSTYLEPLUGIN_H

plugins/messageviewerheaderplugins/enterpriseheaderstyleplugin/enterpriseheaderstyleplugin.h

@@ -27,8 +27,8 @@ public:
     QString alignment() const override;
     int elidedTextSize() const override;
 private:
-    HeaderStyle *mHeaderStyle = nullptr;
-    HeaderStrategy *mHeaderStrategy = nullptr;
+    HeaderStyle *const mHeaderStyle;
+    HeaderStrategy *const mHeaderStrategy;
 };
 }
 #endif // ENTERPRISEHEADERSTYLEPLUGIN_H

plugins/messageviewerheaderplugins/fancyheaderstyleplugin/fancyheaderstyleplugin.h

@@ -30,8 +30,8 @@ public:
     QString attachmentHtml() const override;
 
 private:
-    HeaderStyle *mHeaderStyle = nullptr;
-    HeaderStrategy *mHeaderStrategy = nullptr;
+    HeaderStyle *const mHeaderStyle;
+    HeaderStrategy *const mHeaderStrategy;
 };
 }
 #endif // FANCYHEADERSTYLEPLUGIN_H

plugins/messageviewerheaderplugins/grantleeheaderstyleplugin/grantleeheaderstyleplugin.h

@@ -24,8 +24,8 @@ public:
     HeaderStyleInterface *createView(KActionMenu *menu, QActionGroup *actionGroup, KActionCollection *ac, QObject *parent = nullptr) override;
     QString name() const override;
 private:
-    HeaderStyle *mHeaderStyle = nullptr;
-    HeaderStrategy *mHeaderStrategy = nullptr;
+    HeaderStyle *const mHeaderStyle;
+    HeaderStrategy *const mHeaderStrategy;
 };
 }
 #endif // GRANTLEEHEADERSTYLEPLUGIN_H

plugins/messageviewerheaderplugins/longheaderstyleplugin/longheaderstyleplugin.h

@@ -24,8 +24,8 @@ public:
     HeaderStyleInterface *createView(KActionMenu *menu, QActionGroup *actionGroup, KActionCollection *ac, QObject *parent = nullptr) override;
     QString name() const override;
 private:
-    HeaderStyle *mHeaderStyle = nullptr;
-    HeaderStrategy *mHeaderStrategy = nullptr;
+    HeaderStyle *const mHeaderStyle;
+    HeaderStrategy *const mHeaderStrategy;
 };
 }
 #endif // LONGHEADERSTYLEPLUGIN_H

plugins/messageviewerheaderplugins/standardsheaderstyleplugin/standardsheaderstyleplugin.h

@@ -24,8 +24,8 @@ public:
     HeaderStyleInterface *createView(KActionMenu *menu, QActionGroup *actionGroup, KActionCollection *ac, QObject *parent = nullptr) override;
     QString name() const override;
 private:
-    HeaderStyle *mHeaderStyle = nullptr;
-    HeaderStrategy *mHeaderStrategy = nullptr;
+    HeaderStyle *const mHeaderStyle;
+    HeaderStrategy *const mHeaderStrategy;
 };
 }
 #endif // STANDARDSHEADERSTYLEPLUGIN_H

plugins/messageviewerplugins/common/translatorplugin/viewerplugintranslatorinterface.cpp

@@ -17,7 +17,6 @@ using namespace MessageViewer;
 
 ViewerPluginTranslatorInterface::ViewerPluginTranslatorInterface(KActionCollection *ac, QWidget *parent)
     : ViewerPluginInterface(parent)
-    , mTranslatorWidget(nullptr)
 {
     createAction(ac);
 }