Commit 4b89f4e0 authored by Krzysztof Nowicki's avatar Krzysztof Nowicki Committed by Laurent Montel
Browse files

Synchronize items directly in response to subscription notification

When encountering a server-side notification about changes in folders
issue a item sync request directly along with subsequent item
add/modify/delete requests instead of relying on Akonadi to trigger
this. This is possible as Akonadi will not notify the resource back
about changes it has done itself.

This saves some roundtrip time in the server-side driven
synchronization mechanism.
parent 0e22137d
......@@ -15,7 +15,10 @@
#include <AkonadiCore/CollectionFetchScope>
#include <AkonadiCore/CollectionModifyJob>
#include <AkonadiCore/EntityDisplayAttribute>
#include <AkonadiCore/ItemCreateJob>
#include <AkonadiCore/ItemDeleteJob>
#include <AkonadiCore/ItemFetchScope>
#include <AkonadiCore/ItemModifyJob>
#include <KMime/Message>
#include <KNotification>
#include <KWallet/KWallet>
......@@ -1023,8 +1026,34 @@ void EwsResource::foldersModifiedCollectionSyncFinished(KJob *job)
auto fetchJob = qobject_cast<CollectionFetchJob *>(job);
auto fetchColJob = qobject_cast<CollectionFetchJob *>(job);
const auto collection = fetchColJob->collections().at(0);
auto fetchJob =
new EwsFetchItemsJob(collection, mEwsClient, getCollectionSyncState(collection), mItemsToCheck.value(collection.remoteId()), mTagStore, this);
connect(fetchJob, &EwsFetchItemsJob::result, this, [this, fetchJob](KJob *) {
auto collection = fetchJob->collection();
if (fetchJob->error()) {
qCWarningNC(EWSRES_LOG) << QStringLiteral("Item fetch error:") << fetchJob->errorString() << fetchJob->error();
} else {
const auto newItems = fetchJob->newItems();
for (const auto &newItem : newItems) {
new ItemCreateJob(newItem, collection, this);
if (!fetchJob->changedItems().isEmpty()) {
new ItemModifyJob(fetchJob->changedItems());
if (!fetchJob->deletedItems().isEmpty()) {
new ItemDeleteJob(fetchJob->deletedItems());
saveCollectionSyncState(collection, fetchJob->syncState());
void EwsResource::folderTreeModifiedEvent()
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment