Commit 595303e5 authored by Igor Poboiko's avatar Igor Poboiko
Browse files

[resources/maildir] Don't create junk files

As user types path inside configuration dialog, it gets checked to display
the comment whether it's a valid maildir or not. Under the hood, it calls
`maildir.isValid(createMissingFolders=false)`. There was a codepath, however,
where `createMissingFolders` is not provided (and the default value is `true`),
thus creating `cur/new/tmp` folders all over the place as user types the path.

Test Plan:
1) Try to create maildir inside `/tmp/dummy`
2) Observe `cur/new/tmp` folders being created everywhere inside `/tmp/*`
3) After applying the patch, they don't

Reviewers: dvratil, mlaurent

Reviewed By: dvratil

Subscribers: kde-pim

Tags: #kde_pim

Differential Revision:
parent 7afd99ab
...@@ -256,7 +256,7 @@ bool Maildir::isValid(bool createMissingFolders) const ...@@ -256,7 +256,7 @@ bool Maildir::isValid(bool createMissingFolders) const
const QStringList lstMaildir = subFolderList(); const QStringList lstMaildir = subFolderList();
for (const QString &sf : lstMaildir) { for (const QString &sf : lstMaildir) {
const Maildir subMd = Maildir(path() + QLatin1Char('/') + sf); const Maildir subMd = Maildir(path() + QLatin1Char('/') + sf);
if (!subMd.isValid()) { if (!subMd.isValid(createMissingFolders)) {
d->lastError = subMd.lastError(); d->lastError = subMd.lastError();
return false; return false;
} }
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment