1. 17 Nov, 2020 4 commits
  2. 03 Nov, 2020 1 commit
  3. 22 Oct, 2020 1 commit
  4. 25 Sep, 2020 1 commit
  5. 14 Aug, 2020 1 commit
  6. 01 May, 2020 1 commit
  7. 11 Apr, 2020 1 commit
  8. 10 Apr, 2020 1 commit
    • Daniel Vrátil's avatar
      POP3: Remove the singleton pattern from Settings · 6cdf43de
      Daniel Vrátil authored
      Summary:
      It's causing issues with the "new" out-of-process settings
      dialog which initializes a new Settings object each time and asserts
      when the SettingsHelper Q_GLOBAL_STATIC is already initialized.
      
      Instead just get rid of the singleton pattern and have Settings
      object be owned by whomever created it and pass a reference to it
      to the classes that need it.
      
      BUG: 419726
      
      Subscribers: mkoller, kde-pim
      
      Tags: #kde_pim
      
      Differential Revision: https://phabricator.kde.org/D28732
      6cdf43de
  9. 01 Mar, 2020 1 commit
  10. 07 Dec, 2019 1 commit
  11. 02 Dec, 2019 1 commit
  12. 23 Oct, 2019 1 commit
  13. 27 Dec, 2018 1 commit
  14. 05 Dec, 2018 1 commit
  15. 03 Dec, 2018 1 commit
  16. 09 Oct, 2018 1 commit
    • Krzysztof Nowicki's avatar
      Remove just deleted POP3 messages from the internal maps · 7f0ce855
      Krzysztof Nowicki authored
      This is to prevent attempts to delete them again.
      
      Fixes the testCountBasedLeaveRule, which excercises the following
      scenario:
      
       * initial state: 3 messages known
       * two new messages are added on server
       * LIST returns 5 messages
       * UIDL returns 5 UIDs, 2 of them new
       * download of 2 messages starts
       * fetch of first message is completed
       * item create for first message is completed
       * item create completion triggers cleanup of unwanted server messages
       * messages 1 and 3 are deleted as they are the oldest
       * fetch of second message is completed
       * item create for second message is completed
       * item create completion triggers cleanup of unwanted server messages
       * messages 1 and 3 are deleted again - this causes the test to fail
      
      Removing those identifiers causes the second search for items to
      delete to return an empty set and no further delete attempts are made.
      
      Reviewers: #kde_pim
      
      Reviewed By: dvratil
      
      Tags: #kde_pim
      
      Differential Revision: https://phabricator.kde.org/D15975
      7f0ce855
  17. 05 Oct, 2018 1 commit
  18. 02 Sep, 2018 1 commit
  19. 19 Aug, 2018 1 commit
  20. 03 Feb, 2018 1 commit
  21. 12 Jan, 2018 1 commit
  22. 28 Nov, 2017 1 commit
    • Jonathan Marten's avatar
      Fix POP3 mail fetch not finishing if there are no new messages but some old ones · 5f9902c1
      Jonathan Marten authored
      This may have been introduced by commit e7ba619b.
      It happens when there are no new messages to download, detected
      in doStateStep() in the Download state.  The state then changes
      to CheckRemovingMessage and checkRemovingMessageFromServer() starts
      a delete job if there are any old messages to be deleted.  When the
      delete job finishes, deleteJobResult() is called which checks
      shouldAdvanceToQuitState() to see whether there is any more work to
      do... but the first conditional in shouldAdvanceToQuitState() is
      "mState==Save".  This condition can never be satisfied once the
      state has become CheckRemovingMessage.
      
      The solution is, at the end of deleteJobResult(), to go to state Save
      if there are no more deletion jobs to run.  If there are, the state will
      remain as CheckRemovingMessage and the same check will be done when the
      deletion job eventually finishes.
      
      Differential Revision: https://phabricator.kde.org/D9013
      5f9902c1
  23. 04 Nov, 2017 1 commit
  24. 31 Oct, 2017 1 commit
  25. 19 Apr, 2017 1 commit
  26. 16 Apr, 2017 1 commit
  27. 17 Mar, 2017 1 commit
  28. 01 Feb, 2017 1 commit
  29. 02 Jan, 2017 2 commits
  30. 19 Dec, 2016 1 commit
  31. 06 Dec, 2016 1 commit
  32. 28 Nov, 2016 1 commit
  33. 13 Nov, 2016 1 commit
  34. 12 Nov, 2016 3 commits