1. 12 Oct, 2018 26 commits
  2. 10 Oct, 2018 1 commit
  3. 09 Oct, 2018 6 commits
    • Krzysztof Nowicki's avatar
      Call the POP3 fake server thread's quit() method directly · 3fc4d3be
      Krzysztof Nowicki authored
      Using invoke method makes no sense as the QThread object always lives
      in the parent (=main) thread, which means the message will get
      dispatched to the current thread's event loop anyway. Since that event
      loop will be blocked by the subsequent wait() call the message will
      never reach the fake server thread.
      Instead just call the method directly.
    • Krzysztof Nowicki's avatar
      Clean the seen UID lists on the POP3 resource for all tests · ed251f17
      Krzysztof Nowicki authored
      This ensures that the next test always sees a clean state of the
    • Krzysztof Nowicki's avatar
      Wait for the response each time an option is set on the resource · db2913ae
      Krzysztof Nowicki authored
      Whenever an option is set on a resource during the POP3 test wait for
      the resource to acknowledge. This makes sure the resource has actually
      consumed this setting before relying on it in subsequent tests.
    • Krzysztof Nowicki's avatar
      Work around maildir not being able to create all the paths. · 361c2845
      Krzysztof Nowicki authored
      The maildir resource should automatically create all the paths inside
      its data dir. Unfortunately in case of the POP3 test this does not
      happen for some reason. Work around by creating the paths manually.
    • Krzysztof Nowicki's avatar
      Wait for Akonadi to process items after handling all POP3 messages · 59733dbb
      Krzysztof Nowicki authored
      The POP3 resource test simulates a series of POP3 messages to the
      resource and waits for them to be processed. Unfortunately this is not
      enough as even though the POP3 resource is done talking to the server
      processing of items in Akonadi and in the associated maildir resource
      can still take some time. Due to this fact the POP3 tests were failing
      In order to prevent that run an additional wait loop with the help of
      the monitor interface. Each time an item operation is notified a timer
      is reset. Once no item operation happens within 200ms it is safe to
      assume that the server is done and all the operations resulting from
      the simulated POP3 traffic have been committed.
    • Krzysztof Nowicki's avatar
      Remove just deleted POP3 messages from the internal maps · 7f0ce855
      Krzysztof Nowicki authored
      This is to prevent attempts to delete them again.
      Fixes the testCountBasedLeaveRule, which excercises the following
       * initial state: 3 messages known
       * two new messages are added on server
       * LIST returns 5 messages
       * UIDL returns 5 UIDs, 2 of them new
       * download of 2 messages starts
       * fetch of first message is completed
       * item create for first message is completed
       * item create completion triggers cleanup of unwanted server messages
       * messages 1 and 3 are deleted as they are the oldest
       * fetch of second message is completed
       * item create for second message is completed
       * item create completion triggers cleanup of unwanted server messages
       * messages 1 and 3 are deleted again - this causes the test to fail
      Removing those identifiers causes the second search for items to
      delete to return an empty set and no further delete attempts are made.
      Reviewers: #kde_pim
      Reviewed By: dvratil
      Tags: #kde_pim
      Differential Revision: https://phabricator.kde.org/D15975
  4. 05 Oct, 2018 3 commits
  5. 04 Oct, 2018 4 commits
    • Krzysztof Nowicki's avatar
      EWS/test: Fix build with Qt<5.11 · a52cc769
      Krzysztof Nowicki authored
    • Krzysztof Nowicki's avatar
      EWS/test: Work around occasional missed collection change notifications · 540b6f35
      Krzysztof Nowicki authored
      The test works by faking responses to some EWS requests and waiting
      for the resource to reach an expected state based on mocked responses
      to these requests.
      The state expectation logic is driven by Akonadi collection change
      monitor. Unfortunately every now and then some notifications get lost
      causing the state not to be reached while the server is actually in a
      correct one.
      Work around this by introducing an optional recheck method that
      fetches all collections and forces a recheck of the current state.
      This should finally fix the isolated tests for good.
    • Krzysztof Nowicki's avatar
      EWS/test: Use the SpecialCollectionAttribute to determine collection special type · 94dacf7c
      Krzysztof Nowicki authored
      It looks like use of EntityDisplayAttribute was deprecated.
      This fixes the isolated test not being able to reach expected state.
      Note: the test still fails intermittently - to be investigated.
    • Krzysztof Nowicki's avatar
      EWS/test: Fix authentication failure in isolated test · 9c94779a
      Krzysztof Nowicki authored
      Commit a20701f5 added the "has domain" flag to fix ambiguity between
      empty domain and no domain in the username. Unfortunately the default
      behaviour was set to "domain present", which changed the default
      username from "test" to "/test" causing an unexpected value of the
      Authorization HTTP header and in turn a failure.
      Fix this by explicitly setting the "has domain" flag to false.