GitLab

BUG:449024

Albert Astals Cid authored Dec 16, 2021 and Laurent Montel committed Dec 16, 2021

BUGS: 447005

We need to go into ssl before trying to read from the socket, otherwise
nothing works

BUGS: 446751

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Now I check encrypt support when I create resource.
So if resource support starttls it will set option for it.

BUG: 423426
FIXED-IN: 5.19.0

created
=> show it before start job

BUG: 444985
FIXED-IN: 5.19.0

This is already handled nicely by the resource itself
(see mAskAgain and showPasswordDialog).

(taken from IMAP sessionpool and imap resource)

* POPSession instanciates POP3Protocol directly
* Port POP3Protocol from TCPSlaveBase methods to using QSslSocket directly
* Replace KIO metadata with direct poking into the Settings class
* This means jobs are synchronous, which is fine in an akonadi resource (AFAIK)
* Use the Result class from kio_ftp for returning success+errcode+errstring
* Remove support for prompting for user/pass, this is supposed to be
  done in the settings dialog already. Might be convenient to
  reintroduce this somehow though, in case of a typo in the password.

The unittest passes.

(not built/integrated yet)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Conversion table:
0  => Success
1  => Failure (try fallbacks)
-1 => Abort