Commit 0874efda authored by Laurent Montel's avatar Laurent Montel 😁

Pedantic

parent 587924b9
......@@ -29,12 +29,12 @@
class EwsFolderShape
{
public:
explicit EwsFolderShape(EwsBaseShape shape = EwsShapeDefault) : mBaseShape(shape) {};
~EwsFolderShape() {};
explicit EwsFolderShape(EwsBaseShape shape = EwsShapeDefault) : mBaseShape(shape) {}
~EwsFolderShape() {}
EwsFolderShape(const EwsFolderShape &other)
: mBaseShape(other.mBaseShape), mProps(other.mProps) {};
: mBaseShape(other.mBaseShape), mProps(other.mProps) {}
EwsFolderShape(EwsFolderShape &&other)
: mBaseShape(other.mBaseShape), mProps(other.mProps) {};
: mBaseShape(other.mBaseShape), mProps(other.mProps) {}
EwsFolderShape &operator=(EwsFolderShape &&other)
{
mBaseShape = other.mBaseShape;
......
......@@ -57,7 +57,7 @@ public:
typedef QList<EwsId> List;
explicit EwsId(EwsDistinguishedId did) : mType(Distinguished), mDid(did) {};
explicit EwsId(EwsDistinguishedId did) : mType(Distinguished), mDid(did) {}
explicit EwsId(const QString &id, const QString &changeKey = QString());
EwsId(const EwsId &id)
{
......@@ -69,7 +69,7 @@ public:
*this = std::move(id);
}
EwsId() : mType(Unspecified), mDid(EwsDIdCalendar) {};
EwsId() : mType(Unspecified), mDid(EwsDIdCalendar) {}
explicit EwsId(QXmlStreamReader &reader);
Type type() const
......
......@@ -40,11 +40,11 @@ public:
Q_DECLARE_FLAGS(Flags, Flag)
explicit EwsItemShape(EwsBaseShape shape = EwsShapeDefault) : EwsFolderShape(shape), mBodyType(BodyNone) {};
explicit EwsItemShape(EwsBaseShape shape = EwsShapeDefault) : EwsFolderShape(shape), mBodyType(BodyNone) {}
EwsItemShape(const EwsItemShape &other)
: EwsFolderShape(other), mBodyType(BodyNone) {};
: EwsFolderShape(other), mBodyType(BodyNone) {}
explicit EwsItemShape(EwsFolderShape &&other)
: EwsFolderShape(other), mBodyType(BodyNone) {};
: EwsFolderShape(other), mBodyType(BodyNone) {}
EwsItemShape &operator=(EwsItemShape &&other)
{
mBaseShape = other.mBaseShape;
......
......@@ -52,7 +52,7 @@ public:
class Protocol
{
public:
Protocol() : mType(UnknownProto) {};
Protocol() : mType(UnknownProto) {}
bool isValid() const
{
......
......@@ -71,7 +71,7 @@ public:
: mPropType(EwsPropertyField::UnknownField), mIndex(0), mPsIdType(DistinguishedPropSet),
mPsDid(EwsPropSetMeeting), mIdType(PropName), mId(0), mHasTag(false), mTag(0),
mType(EwsPropTypeNull), mHash(0)
{};
{}
enum PropSetIdType {
DistinguishedPropSet,
......
......@@ -33,14 +33,14 @@ public:
FreeBusyChangedEvent,
};
EwsServerVersion() : mMajor(0), mMinor(0), mMajorBuild(0), mMinorBuild(0) {};
EwsServerVersion() : mMajor(0), mMinor(0), mMajorBuild(0), mMinorBuild(0) {}
EwsServerVersion(uint major, uint minor, const QString &name, const QString &friendlyName)
: mMajor(major), mMinor(minor), mMajorBuild(0), mMinorBuild(0), mName(name),
mFriendlyName(friendlyName) {};
mFriendlyName(friendlyName) {}
explicit EwsServerVersion(QXmlStreamReader &reader);
EwsServerVersion(const EwsServerVersion &other)
: mMajor(other.mMajor), mMinor(other.mMinor), mMajorBuild(other.mMajorBuild),
mMinorBuild(other.mMinorBuild), mName(other.mName), mFriendlyName(other.mFriendlyName) {};
mMinorBuild(other.mMinorBuild), mName(other.mName), mFriendlyName(other.mFriendlyName) {}
EwsServerVersion &operator=(const EwsServerVersion &other)
{
......
......@@ -49,7 +49,7 @@ public:
};
Update(EwsPropertyField field, const QVariant &val, Type type)
: mField(field), mValue(val), mType(type) {};
: mField(field), mValue(val), mType(type) {}
EwsPropertyField mField;
QVariant mValue;
......@@ -59,25 +59,25 @@ public:
class AppendUpdate : public Update
{
public:
AppendUpdate(EwsPropertyField field, const QVariant &val) : Update(field, val, Append) {};
AppendUpdate(EwsPropertyField field, const QVariant &val) : Update(field, val, Append) {}
};
class SetUpdate : public Update
{
public:
SetUpdate(EwsPropertyField field, const QVariant &val) : Update(field, val, Set) {};
SetUpdate(EwsPropertyField field, const QVariant &val) : Update(field, val, Set) {}
};
class DeleteUpdate : public Update
{
public:
DeleteUpdate(EwsPropertyField field) : Update(field, QVariant(), Delete) {};
DeleteUpdate(EwsPropertyField field) : Update(field, QVariant(), Delete) {}
};
class FolderChange
{
public:
FolderChange(EwsId folderId, EwsFolderType type) : mId(folderId), mType(type) {};
FolderChange(EwsId folderId, EwsFolderType type) : mId(folderId), mType(type) {}
void addUpdate(const Update *upd)
{
mUpdates.append(QSharedPointer<const Update>(upd));
......
......@@ -49,7 +49,7 @@ public:
};
Update(EwsPropertyField field, const QVariant &val, Type type)
: mField(field), mValue(val), mType(type) {};
: mField(field), mValue(val), mType(type) {}
EwsPropertyField mField;
QVariant mValue;
......@@ -59,25 +59,25 @@ public:
class AppendUpdate : public Update
{
public:
AppendUpdate(EwsPropertyField field, const QVariant &val) : Update(field, val, Append) {};
AppendUpdate(EwsPropertyField field, const QVariant &val) : Update(field, val, Append) {}
};
class SetUpdate : public Update
{
public:
SetUpdate(EwsPropertyField field, const QVariant &val) : Update(field, val, Set) {};
SetUpdate(EwsPropertyField field, const QVariant &val) : Update(field, val, Set) {}
};
class DeleteUpdate : public Update
{
public:
DeleteUpdate(EwsPropertyField field) : Update(field, QVariant(), Delete) {};
DeleteUpdate(EwsPropertyField field) : Update(field, QVariant(), Delete) {}
};
class ItemChange
{
public:
ItemChange(EwsId itemId, EwsItemType type) : mId(itemId), mType(type) {};
ItemChange(EwsId itemId, EwsItemType type) : mId(itemId), mType(type) {}
void addUpdate(const Update *upd)
{
mUpdates.append(QSharedPointer<const Update>(upd));
......
......@@ -39,23 +39,23 @@ public:
static Q_CONSTEXPR T Ignore = static_cast<T>(-1);
struct Item {
Item() : key(Ignore) {};
Item() : key(Ignore) {}
Item(T k, const QString &n, ReadFunction rfn = ReadFunction(), WriteFunction wfn = WriteFunction())
: key(k), elmName(n), readFn(rfn), writeFn(wfn) {};
: key(k), elmName(n), readFn(rfn), writeFn(wfn) {}
T key;
QString elmName;
ReadFunction readFn;
WriteFunction writeFn;
};
EwsXml() {};
EwsXml() {}
EwsXml(const QVector<Item> &items) : mItems(items)
{
rebuildItemHash();
}
EwsXml(const EwsXml &other)
: mItems(other.mItems), mValues(other.mValues), mItemHash(other.mItemHash) {};
: mItems(other.mItems), mValues(other.mValues), mItemHash(other.mItemHash) {}
void setItems(const QVector<Item> &items)
{
......
......@@ -121,7 +121,7 @@ public:
} Flag;
Q_DECLARE_FLAGS(Flags, Flag)
FolderDescr() {};
FolderDescr() {}
Akonadi::Collection collection;
Flags flags;
......
......@@ -40,6 +40,7 @@ void EwsFetchItemDetailJob::setItemLists(const Akonadi::Item::List &changedItems
mDeletedItems = deletedItems;
EwsId::List ids;
ids.reserve(changedItems.count());
Q_FOREACH (const Akonadi::Item &item, changedItems) {
EwsId id(item.remoteId(), item.remoteRevision());
......
......@@ -57,7 +57,6 @@ protected:
const Akonadi::Collection mCollection;
private Q_SLOTS:
void itemDetailFetched(KJob *job);
private:
};
#endif
......@@ -31,7 +31,7 @@ class StateMonitorBase : public QObject
{
Q_OBJECT
public:
explicit StateMonitorBase(QObject *parent) : QObject(parent) {};
explicit StateMonitorBase(QObject *parent) : QObject(parent) {}
virtual ~StateMonitorBase() = default;
Q_SIGNALS:
void stateReached();
......
......@@ -33,7 +33,7 @@ class Job;
template <typename F>
struct Finally {
Finally(F f): cleanupf{f} {};
Finally(F f): cleanupf{f} {}
~Finally()
{
cleanupf();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment