Commit 0ecea2dc authored by Laurent Montel's avatar Laurent Montel 😁
Browse files

Add missing override

parent a6177f9c
Pipeline #49513 failed with stage
in 19 minutes and 56 seconds
......@@ -22,7 +22,7 @@ class InfoDialog : public QDialog
Q_OBJECT
public:
InfoDialog(bool closeWhenDone = true);
~InfoDialog();
~InfoDialog() override;
static bool hasError()
{
......
......@@ -23,7 +23,7 @@ class FolderArchiveComboBox : public QComboBox
Q_OBJECT
public:
explicit FolderArchiveComboBox(QWidget *parent = nullptr);
~FolderArchiveComboBox();
~FolderArchiveComboBox() override;
void setType(FolderArchiveAccountInfo::FolderArchiveType type);
FolderArchiveAccountInfo::FolderArchiveType type() const;
......
......@@ -37,7 +37,7 @@ public:
typedef std::unique_ptr<GenericHandler> Ptr;
GenericHandler(GoogleResourceStateInterface *iface, GoogleSettings *settings);
virtual ~GenericHandler();
~GenericHandler() override;
virtual QString mimeType() = 0;
......
......@@ -27,7 +27,7 @@ class GoogleSettingsDialog : public QDialog
Q_OBJECT
public:
explicit GoogleSettingsDialog(GoogleResource *resource, GoogleSettings *settings, WId wId);
~GoogleSettingsDialog();
~GoogleSettingsDialog() override;
protected:
bool handleError(KGAPI2::Job *job);
......
......@@ -38,7 +38,7 @@ class ImapIdleManager : public QObject
public:
ImapIdleManager(ResourceStateInterface::Ptr state, SessionPool *pool, ImapResourceBase *parent);
~ImapIdleManager();
~ImapIdleManager() override;
void stop();
KIMAP::Session *session() const;
......
......@@ -16,12 +16,12 @@
ServerInfoDialog::ServerInfoDialog(ImapResourceBase *parentResource, QWidget *parent)
: QDialog(parent)
, mTextBrowser(new ServerInfoTextBrowser(this))
{
setWindowTitle(i18nc("@title:window Dialog title for dialog showing information about a server", "Server Info"));
auto mainLayout = new QVBoxLayout(this);
setAttribute(Qt::WA_DeleteOnClose);
mTextBrowser = new ServerInfoTextBrowser(this);
mTextBrowser->setPlainText(parentResource->serverCapabilities().join(QLatin1Char('\n')));
mainLayout->addWidget(mTextBrowser);
QDialogButtonBox *buttonBox = new QDialogButtonBox(QDialogButtonBox::Close, this);
......
......@@ -28,10 +28,10 @@ class ServerInfoDialog : public QDialog
Q_OBJECT
public:
explicit ServerInfoDialog(ImapResourceBase *parentResource, QWidget *parent);
~ServerInfoDialog();
~ServerInfoDialog() override;
private:
ServerInfoTextBrowser *mTextBrowser = nullptr;
ServerInfoTextBrowser *const mTextBrowser;
};
#endif // SERVERINFODIALOG_H
......@@ -45,7 +45,7 @@ public:
enum SessionTermination { LogoutSession, CloseSession };
explicit SessionPool(int maxPoolSize, QObject *parent = nullptr);
~SessionPool();
~SessionPool() override;
PasswordRequesterInterface *passwordRequester() const;
void setPasswordRequester(PasswordRequesterInterface *requester);
......
......@@ -49,7 +49,7 @@ void SettingsPasswordRequester::askUserInput(const QString &serverError)
return;
}
QWidget *parent = QWidget::find(m_resource->winIdForDialogs());
QString text = i18n(
const QString text = i18n(
"The server for account \"%2\" refused the supplied username and password.\n"
"Do you want to go to the settings, have another attempt "
"at logging in, or do nothing?\n\n"
......
......@@ -34,7 +34,7 @@ private Q_SLOTS:
void onSettingsDialogFinished(int result);
private:
Q_REQUIRED_RESULT QString requestManualAuth(bool *userRejected);
QString requestManualAuth(bool *userRejected);
ImapResourceBase *const m_resource;
QDialog *m_requestDialog = nullptr;
......
......@@ -400,11 +400,11 @@ void SetupServer::readSettings()
populateDefaultAuthenticationOptions();
i = m_parentResource->settings()->authentication();
qCDebug(IMAPRESOURCE_LOG) << "read IMAP auth mode: " << authenticationModeString((MailTransport::Transport::EnumAuthenticationType::type)i);
qCDebug(IMAPRESOURCE_LOG) << "read IMAP auth mode: " << authenticationModeString(static_cast<MailTransport::Transport::EnumAuthenticationType::type>(i));
setCurrentAuthMode(m_ui->authenticationCombo, (MailTransport::Transport::EnumAuthenticationType::type)i);
i = m_parentResource->settings()->alternateAuthentication();
setCurrentAuthMode(m_ui->authenticationAlternateCombo, (MailTransport::Transport::EnumAuthenticationType::type)i);
setCurrentAuthMode(m_ui->authenticationAlternateCombo, static_cast<MailTransport::Transport::EnumAuthenticationType::type>(i));
bool rejected = false;
const QString password = m_parentResource->settings()->password(&rejected);
......
......@@ -31,7 +31,7 @@ class POPSession : public QObject
Q_OBJECT
public:
explicit POPSession(Settings &settings, const QString &password);
~POPSession();
~POPSession() override;
bool connectSlave();
void abortCurrentJob();
......
......@@ -36,7 +36,7 @@ class AKONADI_SINGLEFILERESOURCE_EXPORT SingleFileResourceConfigWidgetBase : pub
Q_OBJECT
public:
explicit SingleFileResourceConfigWidgetBase(QWidget *parent);
~SingleFileResourceConfigWidgetBase();
~SingleFileResourceConfigWidgetBase() override;
/**
* Adds @param page to the tabwidget. This can be used to add custom
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment