Modernize code

resources/folderarchivesettings/folderarchivesettingpage.cpp

@@ -73,7 +73,7 @@ FolderArchiveSettingPage::FolderArchiveSettingPage(const QString &instanceName,
                                  "@label:chooser for the folder that messages will be archived under",
                                  "Archive into:"));
     hbox->addWidget(lab);
-    mArchiveFolder = new Akonadi::CollectionRequester;
+    mArchiveFolder = new Akonadi::CollectionRequester(this);
     mArchiveFolder->setMimeTypeFilter(QStringList() << KMime::Message::mimeType());
     hbox->addWidget(mArchiveFolder);
     lay->addLayout(hbox);

resources/tomboynotes/tomboycollectionsdownloadjob.cpp

@@ -15,8 +15,8 @@
 TomboyCollectionsDownloadJob::TomboyCollectionsDownloadJob(const QString &collectionName, KIO::AccessManager *manager, int refreshInterval, QObject *parent)
     : TomboyJobBase(manager, parent)
     , mCollectionName(collectionName)
+    , mRefreshInterval(refreshInterval)
 {
-    mRefreshInterval = refreshInterval;
 }
 
 Akonadi::Collection::List TomboyCollectionsDownloadJob::collections() const

resources/tomboynotes/tomboycollectionsdownloadjob.h

@@ -26,8 +26,8 @@ private:
     // This will be called once the request is finished.
     void onRequestFinished();
     Akonadi::Collection::List mResultCollections;
-    QString mCollectionName;
-    int mRefreshInterval;
+    const QString mCollectionName;
+    const int mRefreshInterval;
 };
 
 #endif // TOMBOYCOLLECTIONSDOWNLOADJOB_H

resources/tomboynotes/tomboyitemsdownloadjob.h

@@ -23,7 +23,7 @@ public:
     void start() override;
 
 private:
-    Akonadi::Collection::Id mCollectionId;
+    const Akonadi::Collection::Id mCollectionId;
     // This will be called once the request is finished.
     void onRequestFinished();
     Akonadi::Item::List mResultItems;

resources/tomboynotes/tomboyitemuploadjob.h

@@ -40,7 +40,7 @@ private:
     Akonadi::Item mSourceItem;
     KMime::Message::Ptr mNoteContent;
 
-    JobType mJobType;
+    const JobType mJobType;
 
     int mRemoteRevision;
 };

resources/tomboynotes/tomboyjobbase.cpp

@@ -10,7 +10,6 @@ TomboyJobBase::TomboyJobBase(KIO::AccessManager *manager, QObject *parent)
     : KCompositeJob(parent)
     , mManager(manager)
     , mO1(new O1Tomboy(this))
-    , mReply(nullptr)
 {
     mRequestor = new O1Requestor(mManager, mO1, this);
 }

resources/tomboynotes/tomboyjobbase.h

@@ -29,9 +29,9 @@ public:
     void setAuthentication(const QString &token, const QString &secret);
 
 protected:
-    KIO::Integration::AccessManager *mManager = nullptr;
+    KIO::Integration::AccessManager *const mManager;
     O1Requestor *mRequestor = nullptr;
-    O1Tomboy *mO1 = nullptr;
+    O1Tomboy *const mO1;
     QNetworkReply *mReply = nullptr;
 
     QString mApiURL;

resources/tomboynotes/tomboyserverauthenticatejob.h

@@ -35,7 +35,7 @@ private:
     void onUserRequestFinished();
     QString mUserURL;
 
-    QWebEngineView *mWebView = nullptr;
+    QWebEngineView *const mWebView;
 };
 
 #endif // TOMBOYSERVERAUTHENTICATEJOB_H