Members of the KDE Community are recommended to subscribe to the kde-community mailing list at https://mail.kde.org/mailman/listinfo/kde-community to allow them to participate in important discussions and receive other important announcements

Commit d92010e4 authored by Laurent Montel's avatar Laurent Montel 😁

Various fix

parent b7d09755
......@@ -35,7 +35,7 @@ class BirthdaysResource : public Akonadi::ResourceBase, public Akonadi::AgentBas
public:
explicit BirthdaysResource(const QString &id);
~BirthdaysResource();
~BirthdaysResource() override;
public Q_SLOTS:
void configure(WId windowId) override;
......
......@@ -38,7 +38,7 @@ class ContactsResource : public Akonadi::ResourceBase, public Akonadi::AgentBase
public:
explicit ContactsResource(const QString &id);
~ContactsResource();
~ContactsResource() override;
public Q_SLOTS:
void configure(WId windowId) override;
......
......@@ -40,7 +40,7 @@ class DavGroupwareResource : public Akonadi::ResourceBase, public Akonadi::Agent
public:
explicit DavGroupwareResource(const QString &id);
~DavGroupwareResource();
~DavGroupwareResource() override;
void collectionRemoved(const Akonadi::Collection &collection) override;
void cleanup() override;
......
......@@ -56,7 +56,7 @@ inline QDebug operator<<(QDebug debug, const Akonadi::Collection::List &cols)
for (const Akonadi::Collection &col : cols) {
itemStrs.append(EwsClient::folderHash.value(col.remoteId(), ewsHash(col.remoteId())));
}
debug.nospace().noquote() << "Akonadi::Collection::List(" << itemStrs.join(QChar::fromLatin1(',')) << ")";
debug.nospace().noquote() << "Akonadi::Collection::List(" << itemStrs.join(QLatin1Char(',')) << ")";
return debug.maybeSpace();
}
......@@ -75,7 +75,7 @@ inline QDebug operator<<(QDebug debug, const QSet<QByteArray> &items)
for (const QByteArray &item : items) {
itemStrs.append(QString::fromLatin1(item));
}
debug.nospace().noquote() << "QSet<QByteArray>(" << itemStrs.join(QChar::fromLatin1(',')) << ")";
debug.nospace().noquote() << "QSet<QByteArray>(" << itemStrs.join(QLatin1Char(',')) << ")";
return debug.maybeSpace();
}
......
......@@ -43,7 +43,7 @@ class QWebEngineUrlRequestJob : public QObject
{
Q_OBJECT
public:
QWebEngineUrlRequestJob(const QUrl &url, QObject *parent) : QObject(parent), mUrl(url) {}
explicit QWebEngineUrlRequestJob(const QUrl &url, QObject *parent) : QObject(parent), mUrl(url) {}
~QWebEngineUrlRequestJob() override = default;
QUrl requestUrl() const;
......@@ -55,7 +55,7 @@ class QWebEngineUrlRequestInfo : public QObject
{
Q_OBJECT
public:
QWebEngineUrlRequestInfo(const QUrl &url, QObject *parent) : QObject(parent), mBlocked(false), mUrl(url) {}
explicit QWebEngineUrlRequestInfo(const QUrl &url, QObject *parent) : QObject(parent), mBlocked(false), mUrl(url) {}
~QWebEngineUrlRequestInfo() override = default;
QUrl requestUrl() const;
......@@ -89,7 +89,7 @@ class QWebEngineProfile : public QObject
{
Q_OBJECT
public:
QWebEngineProfile(QObject *parent = nullptr);
explicit QWebEngineProfile(QObject *parent = nullptr);
~QWebEngineProfile() override;
void setHttpUserAgent(const QString &ua);
......@@ -108,7 +108,7 @@ class QWebEnginePage : public QObject
{
Q_OBJECT
public:
QWebEnginePage(QWebEngineProfile *profile, QObject *parent = nullptr);
explicit QWebEnginePage(QWebEngineProfile *profile, QObject *parent = nullptr);
~QWebEnginePage() override;
Q_SIGNALS:
void logEvent(const QString &event);
......@@ -122,7 +122,7 @@ class QWebEngineView : public QWidget
public:
typedef std::function<void(const QUrl &, QVariantMap &)> AuthFunc;
QWebEngineView(QWidget *parent);
explicit QWebEngineView(QWidget *parent);
~QWebEngineView() override;
void load(const QUrl &url);
......@@ -160,7 +160,7 @@ public:
};
Q_ENUM(NetworkError)
QNetworkReply(QObject *parent) : QBuffer(parent) {}
explicit QNetworkReply(QObject *parent) : QBuffer(parent) {}
~QNetworkReply() override = default;
NetworkError error() const;
......@@ -204,7 +204,7 @@ public:
RefreshingToken
};
QAbstractOAuth(QObject *parent);
explicit QAbstractOAuth(QObject *parent);
~QAbstractOAuth() override = default;
void setReplyHandler(QAbstractOAuthReplyHandler *handler);
......@@ -292,7 +292,7 @@ class EwsPKeyAuthJob : public KJob
{
Q_OBJECT
public:
EwsPKeyAuthJob(const QUrl &pkeyUri, const QString &certFile, const QString &keyFile, const QString &keyPassword,
explicit EwsPKeyAuthJob(const QUrl &pkeyUri, const QString &certFile, const QString &keyFile, const QString &keyPassword,
QObject *parent);
~EwsPKeyAuthJob() override = default;
void start() {}
......
......@@ -98,7 +98,7 @@ std::string Event::toICal() const
bool Event::fromIMip(const std::string &input)
{
std::vector<Kolab::Event> list = mITipHandler.fromIMip(input);
const std::vector<Kolab::Event> list = mITipHandler.fromIMip(input);
if (list.size() != 1) {
std::cout << "invalid number of events: " << list.size();
return false;
......
......@@ -226,7 +226,7 @@ int fromAddressType(int kabcType, bool &pref)
KContacts::Address::Type toAddressType(int types, bool pref)
{
KContacts::Address::Type type = 0;
KContacts::Address::Type type = {};
if (pref) {
type |= KContacts::Address::Pref;
}
......@@ -289,7 +289,7 @@ int fromPhoneType(int kabcType, bool &pref)
KContacts::PhoneNumber::Type toPhoneType(int types, bool pref)
{
KContacts::PhoneNumber::Type type = 0;
KContacts::PhoneNumber::Type type = {};
if (types & Kolab::Telephone::Home) {
type |= KContacts::PhoneNumber::Home;
}
......
......@@ -1008,7 +1008,7 @@ static const char *s_knownCustomFields[] = {
"X-SpousesName",
"X-Anniversary",
"DistributionList",
0
nullptr
};
// The saving is addressee -> Contact -> xml, this is the first part
......
......@@ -472,7 +472,7 @@ void Incidence::loadAlarms(const QDomElement &element)
QString tagName = e.tagName();
if (tagName == QLatin1String("alarm")) {
KCalCore::Alarm::Ptr a = KCalCore::Alarm::Ptr(new KCalCore::Alarm(0));
KCalCore::Alarm::Ptr a = KCalCore::Alarm::Ptr(new KCalCore::Alarm(nullptr));
a->setEnabled(true); // default to enabled, unless some XML attribute says otherwise.
QString type = e.attribute(QStringLiteral("type"));
if (type == QLatin1String("display")) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment