Commit ecff6377 authored by Laurent Montel's avatar Laurent Montel 😁
Browse files

Pedantic

parent 3f60455a
Pipeline #41305 failed with stage
in 18 minutes
......@@ -208,7 +208,7 @@ void SendJob::resourceProgress(const AgentInstance &instance)
void SendJob::resourceResult(qlonglong itemId, int result, const QString &message)
{
Q_UNUSED(itemId);
Q_UNUSED(itemId)
Q_ASSERT(mInterface);
delete mInterface; // So that abort() knows the transport job is over.
mInterface = nullptr;
......
......@@ -87,7 +87,7 @@ public:
void percent(KJob *job, long unsigned int percent) override
{
Q_UNUSED(job);
Q_UNUSED(job)
mPercent = percent;
}
......
......@@ -175,7 +175,7 @@ void NewMailNotifierAgent::itemsRemoved(const Item::List &items)
void NewMailNotifierAgent::itemsFlagsChanged(const Akonadi::Item::List &items, const QSet<QByteArray> &addedFlags, const QSet<QByteArray> &removedFlags)
{
Q_UNUSED(removedFlags);
Q_UNUSED(removedFlags)
if (!isActive()) {
return;
......
......@@ -1061,7 +1061,7 @@ void POP3Protocol::get(const QUrl &url)
void POP3Protocol::listDir(const QUrl &url)
{
Q_UNUSED(url);
Q_UNUSED(url)
bool isINT;
int num_messages = 0;
......
......@@ -78,7 +78,7 @@ void BirthdaysResource::retrieveCollections()
void BirthdaysResource::retrieveItems(const Akonadi::Collection &collection)
{
Q_UNUSED(collection);
Q_UNUSED(collection)
itemsRetrievedIncremental(Akonadi::valuesToVector(mPendingItems), Akonadi::valuesToVector(mDeletedItems));
mPendingItems.clear();
mDeletedItems.clear();
......@@ -86,7 +86,7 @@ void BirthdaysResource::retrieveItems(const Akonadi::Collection &collection)
bool BirthdaysResource::retrieveItem(const Akonadi::Item &item, const QSet< QByteArray > &parts)
{
Q_UNUSED(parts);
Q_UNUSED(parts)
qint64 contactId = item.remoteId().mid(1).toLongLong();
ItemFetchJob *job = new ItemFetchJob(Item(contactId), this);
job->fetchScope().fetchFullPayload();
......
......@@ -385,7 +385,7 @@ void EwsOAuthPrivate::error(const QString &error, const QString &errorDescriptio
{
Q_Q(EwsOAuth);
Q_UNUSED(uri);
Q_UNUSED(uri)
mAuthenticated = false;
......@@ -414,8 +414,8 @@ bool EwsOAuth::getAuthData(QString &username, QString &password, QStringList &cu
{
Q_D(const EwsOAuth);
Q_UNUSED(username);
Q_UNUSED(password);
Q_UNUSED(username)
Q_UNUSED(password)
if (d->mAuthenticated) {
customHeaders.append(QStringLiteral("Authorization: Bearer ") + d->mOAuth2.token());
......@@ -456,7 +456,7 @@ const QString &EwsOAuth::authFailedPrompt() const
void EwsOAuth::walletPasswordRequestFinished(const QString &password)
{
Q_UNUSED(password);
Q_UNUSED(password)
}
void EwsOAuth::walletMapRequestFinished(const QMap<QString, QString> &map)
......
......@@ -23,7 +23,7 @@ void EwsPasswordAuth::init()
bool EwsPasswordAuth::getAuthData(QString &username, QString &password, QStringList &customHeaders)
{
Q_UNUSED(customHeaders);
Q_UNUSED(customHeaders)
if (!mPassword.isNull()) {
username = mUsername;
......@@ -40,7 +40,7 @@ void EwsPasswordAuth::notifyRequestAuthFailed()
bool EwsPasswordAuth::authenticate(bool interactive)
{
Q_UNUSED(interactive);
Q_UNUSED(interactive)
return false;
}
......@@ -70,7 +70,7 @@ void EwsPasswordAuth::walletPasswordRequestFinished(const QString &password)
void EwsPasswordAuth::walletMapRequestFinished(const QMap<QString, QString> &map)
{
Q_UNUSED(map);
Q_UNUSED(map)
}
void EwsPasswordAuth::setUsername(const QString &username)
......
......@@ -61,7 +61,7 @@ void EwsGetStreamingEventsRequest::start()
void EwsGetStreamingEventsRequest::requestData(KIO::Job *job, const QByteArray &data)
{
Q_UNUSED(job);
Q_UNUSED(job)
mRespTimer.stop();
qCDebug(EWSCLI_PROTO_LOG) << "data" << job << data;
......
......@@ -95,7 +95,7 @@ void EwsPoxAutodiscoverRequest::start()
void EwsPoxAutodiscoverRequest::requestData(KIO::Job *job, const QByteArray &data)
{
Q_UNUSED(job);
Q_UNUSED(job)
qCDebug(EWSCLI_PROTO_LOG) << "data" << job << data;
mResponseData += QString::fromUtf8(data);
......
......@@ -218,7 +218,7 @@ bool EwsRequest::readSoapFault(QXmlStreamReader &reader)
void EwsRequest::requestData(KIO::Job *job, const QByteArray &data)
{
Q_UNUSED(job);
Q_UNUSED(job)
qCDebug(EWSCLI_PROTO_LOG) << "data" << job << data;
mResponseData += QString::fromUtf8(data);
......
......@@ -451,10 +451,10 @@ const QString &KJob::errorString() const
EwsPKeyAuthJob::EwsPKeyAuthJob(const QUrl &pkeyUri, const QString &certFile, const QString &keyFile, const QString &keyPassword, QObject *parent)
: KJob(parent)
{
Q_UNUSED(pkeyUri);
Q_UNUSED(certFile);
Q_UNUSED(keyFile);
Q_UNUSED(keyPassword);
Q_UNUSED(pkeyUri)
Q_UNUSED(certFile)
Q_UNUSED(keyFile)
Q_UNUSED(keyPassword)
}
const QUrl &EwsPKeyAuthJob::resultUri() const
......
......@@ -14,8 +14,8 @@
namespace KIO {
inline TransferJob *http_post(const QUrl &url, const QByteArray &postData, JobFlags flags)
{
Q_UNUSED(url);
Q_UNUSED(flags);
Q_UNUSED(url)
Q_UNUSED(flags)
FakeTransferJob::Verifier vfy = FakeTransferJob::getVerifier();
auto *job = new FakeTransferJob(postData, vfy.fn, vfy.object);
......
......@@ -17,7 +17,7 @@ FakeTransferJob::FakeTransferJob(const QByteArray &postData, const VerifierFn &f
, mPostData(postData)
, mVerifier(fn)
{
Q_UNUSED(parent);
Q_UNUSED(parent)
metaObject()->invokeMethod(this, "callVerifier", Qt::QueuedConnection);
}
......
......@@ -101,8 +101,8 @@ void FacebookResource::retrieveItems(const Akonadi::Collection &collection)
bool FacebookResource::retrieveItems(const Akonadi::Item::List &items, const QSet<QByteArray> &parts)
{
Q_UNUSED(items);
Q_UNUSED(parts);
Q_UNUSED(items)
Q_UNUSED(parts)
// We always do full re-sync, and we always retrieve the entire payload, so
// there's no need to implement this function
......
......@@ -37,7 +37,7 @@ ICalResource::~ICalResource()
bool ICalResource::doRetrieveItem(const Akonadi::Item &item, const QSet<QByteArray> &parts)
{
Q_UNUSED(parts);
Q_UNUSED(parts)
const QString rid = item.remoteId();
Incidence::Ptr incidence = calendar()->instance(rid);
if (!incidence) {
......@@ -112,7 +112,7 @@ void ICalResource::itemChanged(const Akonadi::Item &item, const QSet<QByteArray>
void ICalResource::doRetrieveItems(const Akonadi::Collection &col)
{
Q_UNUSED(col);
Q_UNUSED(col)
const Incidence::List incidences = calendar()->incidences();
Item::List items;
items.reserve(incidences.count());
......
......@@ -28,7 +28,7 @@ GmailPasswordRequester::~GmailPasswordRequester()
void GmailPasswordRequester::requestPassword(RequestType request, const QString &serverError)
{
Q_UNUSED(serverError); // we don't get anything useful from XOAUTH2 SASL
Q_UNUSED(serverError) // we don't get anything useful from XOAUTH2 SASL
if (request == WrongPasswordRequest) {
auto promise = KGAPI2::AccountManager::instance()->findAccount(GOOGLE_API_KEY, mResource->settings()->userName());
......
......@@ -183,7 +183,7 @@ void ImapIdleManager::onStatsReceived(KIMAP::IdleJob *job, const QString &mailBo
void ImapIdleManager::onFlagsChanged(KIMAP::IdleJob *job)
{
Q_UNUSED(job);
Q_UNUSED(job)
qCDebug(IMAPRESOURCE_LOG) << "IDLE flags changed in" << m_session->selectedMailBox();
m_resource->synchronizeCollection(m_state->collection().id());
}
......@@ -457,14 +457,14 @@ void ImapResourceBase::collectionMoved(const Akonadi::Collection &collection, co
void ImapResourceBase::addSearch(const QString &query, const QString &queryLanguage, const Collection &resultCollection)
{
Q_UNUSED(query);
Q_UNUSED(queryLanguage);
Q_UNUSED(resultCollection);
Q_UNUSED(query)
Q_UNUSED(queryLanguage)
Q_UNUSED(resultCollection)
}
void ImapResourceBase::removeSearch(const Collection &resultCollection)
{
Q_UNUSED(resultCollection);
Q_UNUSED(resultCollection)
}
void ImapResourceBase::search(const QString &query, const Collection &collection)
......
......@@ -17,7 +17,7 @@ MessageHelper::~MessageHelper()
Akonadi::Item MessageHelper::createItemFromMessage(const KMime::Message::Ptr &message, const qint64 uid, const qint64 size, const QMap<QByteArray, QVariant> &attrs, const QList<QByteArray> &flags, const KIMAP::FetchJob::FetchScope &scope, bool &ok) const
{
Q_UNUSED(attrs);
Q_UNUSED(attrs)
Akonadi::Item i;
if (scope.mode == KIMAP::FetchJob::FetchScope::Flags) {
......
......@@ -112,7 +112,7 @@ void MoveItemsTask::startMove(KIMAP::Session *session)
set.add(item.remoteId().toLong());
} catch (const Akonadi::PayloadException &e) {
Q_UNUSED(e);
Q_UNUSED(e)
qCWarning(IMAPRESOURCE_LOG) << "Move failed, payload exception " << item.id() << item.remoteId();
cancelTask(i18n("Failed to move item, it has no message payload. Remote id: %1", item.remoteId()));
return;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment