Add more const variable/pointer

src/core/ldapdn.cpp

@@ -17,7 +17,6 @@ class Q_DECL_HIDDEN LdapDN::LdapDNPrivate
 {
 public:
     LdapDNPrivate()
-        : m_dn()
     {
     }
 
@@ -25,8 +24,8 @@ public:
     {
     }
 
-    bool isValidRDNString(const QString &rdn) const;
-    QStringList splitOnNonEscapedChar(const QString &rdn, QChar ch) const;
+    Q_REQUIRED_RESULT bool isValidRDNString(const QString &rdn) const;
+    Q_REQUIRED_RESULT QStringList splitOnNonEscapedChar(const QString &rdn, QChar ch) const;
 
     QString m_dn;
 };

src/core/ldapserver.cpp

@@ -323,7 +323,7 @@ void LdapServer::setUrl(const LdapUrl &url)
         d->mAuth = Simple;
         d->mBindDn = url.extension(QStringLiteral("bindname"), critical);
     } else {
-        QString user = url.userName();
+        const QString user = url.userName();
         if (user.isEmpty()) {
             d->mAuth = Anonymous;
         } else {

src/widgets/ldapconfigurewidget.cpp

@@ -33,8 +33,8 @@ using namespace KLDAP;
 
 LdapConfigureWidget::LdapConfigureWidget(QWidget *parent)
     : QWidget(parent)
+    , mClientSearchConfig(new KLDAP::LdapClientSearchConfig)
 {
-    mClientSearchConfig = new KLDAP::LdapClientSearchConfig;
     initGUI();
 
     connect(mHostListView, &QListWidget::currentItemChanged, this, &LdapConfigureWidget::slotSelectionChanged);

src/widgets/ldapconfigurewidget.h

@@ -55,7 +55,7 @@ private:
 
     QToolButton *mUpButton = nullptr;
     QToolButton *mDownButton = nullptr;
-    KLDAP::LdapClientSearchConfig *mClientSearchConfig = nullptr;
+    KLDAP::LdapClientSearchConfig *const mClientSearchConfig;
 };
 }
 

src/widgets/ldapconfigwidget.cpp

@@ -305,7 +305,7 @@ void LdapConfigWidget::Private::sendQuery()
         return;
     }
 
-    if (mProg == nullptr) {
+    if (!mProg) {
         mProg = new QProgressDialog(mParent);
         mProg->setWindowTitle(i18nc("@title:window", "LDAP Query"));
         mProg->setModal(true);