1. 15 Aug, 2022 1 commit
  2. 30 Jul, 2022 1 commit
  3. 28 Jul, 2022 1 commit
  4. 13 Jul, 2022 2 commits
  5. 03 Jul, 2022 1 commit
  6. 01 Jul, 2022 2 commits
  7. 27 Jun, 2022 1 commit
  8. 14 Jun, 2022 1 commit
  9. 11 Jun, 2022 2 commits
    • Ahmad Samir's avatar
      Cleanup ldap_extended_operation/_s related buildsystem code · a20dd5e5
      Ahmad Samir authored
      - remove check_symbol_exists(), check_function_exists() should be enough
      - fix check for HAVE_LDAP_EXTENDED_OPERATION_S before ldap_extended_operation_s
        is used
      a20dd5e5
    • Ahmad Samir's avatar
      Use cmakedefine01 · 2f084272
      Ahmad Samir authored
      This way we get a build time warning if the var isn't defined at all, e.g.
      a missing check_include_files() CMake call.
      
      Remove unused var, HAVE_LDAP_H.
      2f084272
  10. 26 May, 2022 1 commit
  11. 16 May, 2022 1 commit
  12. 03 May, 2022 2 commits
  13. 15 Apr, 2022 1 commit
  14. 13 Apr, 2022 1 commit
  15. 12 Apr, 2022 1 commit
  16. 06 Apr, 2022 1 commit
  17. 01 Apr, 2022 1 commit
  18. 25 Mar, 2022 1 commit
  19. 21 Mar, 2022 1 commit
  20. 14 Mar, 2022 1 commit
  21. 11 Mar, 2022 1 commit
  22. 10 Mar, 2022 1 commit
  23. 08 Mar, 2022 1 commit
  24. 01 Mar, 2022 1 commit
  25. 16 Feb, 2022 1 commit
  26. 15 Feb, 2022 2 commits
  27. 24 Jan, 2022 1 commit
    • Adriaan de Groot's avatar
      Fix crash in destructor when using libcxx (Clang STL, FreeBSD) · 1683a9d0
      Adriaan de Groot authored
      This code crashes in the destructor of LdapClient on FreeBSD.
      The crash is visible to uses who
      - start KOrganizer
      - click the "New Event" button
      
      The underlying issue is a lot like the one described in
      	https://blogs.kde.org/2021/02/20/uniqueptr-difference-between-libstdc-and-libc-crashes-your-application
      There is a convoluted call-chain on destruction of LdapClient:
      - ~LdapClient
      - ~std::unique_ptr<LdapClientPrivate>
      - ~LdapClientPrivate
      - LdapClient::cancelQuery
      - (accesses to members of LdapClientPrivate `d`)
      
      With libcxx, the pointer in `d` is already set to nullptr and
      SEGV happens. I'm not sure it isn't UB, anyway, since the
      destructor body for LdapClient has already run.
      
      The fix moves the implementation of `cancelQuery()` into
      the private class. This means that the LdapClient class does
      a little less poking-and-prodding in the private class,
      but also cuts out the call-from-private-back-to-destroyed-
      owning-LdapClient, fixing the SEGV and possible UB.
      1683a9d0
  28. 23 Jan, 2022 1 commit
  29. 19 Jan, 2022 4 commits
  30. 17 Jan, 2022 1 commit
  31. 15 Jan, 2022 1 commit
  32. 10 Jan, 2022 1 commit