Commit 9b38454c authored by Ingo Klöcker's avatar Ingo Klöcker
Browse files

Fix invocation of the load() slot from KCModule::showEvent()

For some reason the save() override was invoked instead of the load()
override. Apparently, Qt's dispatch gets confused if overridden virtual
slots are not marked as slots. Marking the overridden slots as slots
fixes this.

In particular, this bug caused the X.509 servers to be saved as soon as
the config dialog was opened.

Note to self: Virtual slots are evil. Use non-virtual slots calling
(protected) virtual member functions.

GnuPG-bug-id: 5801
parent 318ff3a4
......@@ -26,6 +26,7 @@ class AppearanceConfigurationPage : public KCModule
public:
explicit AppearanceConfigurationPage(QWidget *parent = nullptr, const QVariantList &args = QVariantList());
public Q_SLOTS:
void load() override;
void save() override;
void defaults() override;
......
......@@ -26,6 +26,7 @@ class CryptoOperationsConfigurationPage : public KCModule
public:
explicit CryptoOperationsConfigurationPage(QWidget *parent = nullptr, const QVariantList &args = QVariantList());
public Q_SLOTS:
void load() override;
void save() override;
void defaults() override;
......
......@@ -25,6 +25,7 @@ public:
explicit DirectoryServicesConfigurationPage(QWidget *parent = nullptr, const QVariantList &args = {});
~DirectoryServicesConfigurationPage() override;
public Q_SLOTS:
void load() override;
void save() override;
void defaults() override;
......
......@@ -26,6 +26,7 @@ public:
explicit GnuPGSystemConfigurationPage(QWidget *parent = nullptr, const QVariantList &args = QVariantList());
~GnuPGSystemConfigurationPage() override;
public Q_SLOTS:
void load() override;
void save() override;
void defaults() override;
......
......@@ -22,6 +22,7 @@ class SMimeValidationConfigurationPage : public KCModule
public:
explicit SMimeValidationConfigurationPage(QWidget *parent = nullptr, const QVariantList &args = QVariantList());
public Q_SLOTS:
void load() override;
void save() override;
void defaults() override;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment