GnuPG-bug-id: 5969

This happened when switching in the Advanced Settings dialog from the
first tab to the second tab.

GnuPG-bug-id: 5969

This makes it possible to use this dialog on a Full HD display with 400 %
magnification.

GnuPG-bug-id: 5969

GnuPG-bug-id: 5969

GnuPG-bug-id: 5969

Move the top and bottom margins of the page layout to the scroll area
layout. This way the scroll area gets more vertical space, but the overall
margins stay the same.

GnuPG-bug-id: 5969

This makes it possible to use this page on a Full HD display with 400 %
magnification.

GnuPG-bug-id: 5969

GnuPG-bug-id: 5969

This makes it possible to use this page on a Full HD display with 400 %
magnification.

GnuPG-bug-id: 5969

Do not add the height of the widget's minimum size hint to the scroll
area's minimum size hint. Adding the height made the minimum size of
the scroll area too large on small displays (or with large magnifaction)
and is not necessary because the scroll area enables vertical scrolling.
This reverts one of the changes made with d4d7bb80.

GnuPG-bug-id: 5969

GnuPG-bug-id: 5969

GnuPG-bug-id: 5969

GnuPG-bug-id: 5969

GnuPG-bug-id: 5969

GnuPG-bug-id: 5969

GIT_SILENT

Before the previous commit slotDialogRejected/Accepted() couldn't be
called in the Functors in connect(), as the captured 'this' pointer was a
pointer to non-const.

It's creating the dialog and assigning it to a member.

... GnuPGProcessCommand, so that we can more precisely disconnect
QProcess::readyReadStandardError.

- ReloadKeysCommand: use KeyCache::instance() instead of mutableInstance() in
  connect call.

Add success helper (with default window title "Success") as counterpart
for the error helper.

"Error" is the default window caption/title used by KMessageBox::error.

There isn't really any non-trivial code left that came originally from
KDAB.

See !16 (comment 428719)

With this change, cancelling a publish request job will also delete the
corresponding WKS job.

The formerly used icon is no longer provided by icon sets, so a switch
to an existing icon is needed.
See !16 (comment 428725)
and !16 (comment 428726)

Also capitalized action text.
See !16 (comment 428723)
and !16 (comment 428724)

See !16 (comment 427798)

Assuming a user either has KMail (then with Akonadi) or is likely to use
an entirely different GUI tool for key management, no option to create a
publish request at all is provided in case Akonadi is not found.

See !16 (comment 428570)

See !16 (comment 427747)

Instead of using gpg-wks-binary on the commandline,
QGpgME::WKSPublishJob is now used, skipping creating, writing to,
reading from and finally deleting a temporary file on disk.
It also releases dependency on Libkleo to provide a path to the
gpg-wks-client binary.

Unlike the old version, successfully queueing a key publication request
mail does no longer produce an info box, a feature which might be
re-added.

See !16 (comment 427785)

The result signal of the mail creation job is connected to a lambda
method producing an error notification if, and only if, the job sets its
error() value to something other than 0.

See !16 (comment 427791)

There is only the transport name of an identity, which is of interest
throughout the code, so instead of handling an identity in the calling
functions, now there's just the name of an identity's transport returned
to be used, further reducing overhead.

See !16 (comment 427791)

As per the comment, mailIdManager has been moved from a class static
variable into a file static function.
This revealed that it is only required to get hold of the identity
associated with a certain mail sender address. Thus the class code using
the IdentityManager has been refactored into the same function and it no
longer returns an IdentityManager, but instead directly returns the
identity requested, or the default identity if a mail address has no
associated identity.

See !16 (comment 427795)
and !16 (comment 427796)

Since a restriction is in place which allows for only one key to be
published using WKS, it is also unnecessary to iterate over `d->keys()`
as it is guaranteed there's only one key in that vector.

Some mail providers offer GnuPG WebKey Service, publishing a user's
public PGP key on the provider's WebKey Directory using a well-defined
string of mails to verify the submitter is actually the owner of the key
and approves of the submission, rectifying some of the shortcomings of
public key servers.

The process is defined in
https://www.ietf.org/archive/id/draft-koch-openpgp-webkey-service-13.html

Justification: Thunderbird's engimail extension already supports
publishing public PGP keys using the same process and KMail is already
capable of handling the authorization request and response mails from
the provider, at which point Kleopatra is no longer involved, Kleopatra
just needs to create and send the initial publication request mail with
the key's user id as the sender address, which is a feature this patch
adds.

Functional description: This patch adds a context menu entry for PGP
keys for which a secret key is in the keyring to "Publish at mail
provider". Calling this entry will try to publish the key at the key's
first user id's mail provider. Likewise it adds a context menu entry for
each such key's user id which provides the option to select which user
id should be used to determine the mail provider and sending user in
question.
Provided the user continues the publishing process after a warning
message, gpg-wks-client is called with the selected user id which then
figures if the mail provider supports publishing via WKS in the first
place and if so, will produce a temporary file with the mail to be sent.
If gpg-wks-client is unable to find the necessary submission mail address
and PGP key for the user id's mail provider, an error message is shown
and the process aborted.
Otherwise Kleopatra invokes Akonadi to select the user id's mail
transport and will use it to send the previosuly created mail. If no
such transport can be found, the process is aborted.
When the mail has been handed over to Akonadi mail transport,
Kleopatra's part in publishing the PGP key at the mail provider is
complete, the rest is handled by the user's mail agent.

GnuPG-bug-id: 5969

GnuPG-bug-id: 5969

The "empty" cpp makes automoc work.

GnuPG-bug-id: 5969

With 400 % magnification on a Full HD display the text on the buttons
is now fully visible.

GnuPG-bug-id: 5969