1. 18 Dec, 2020 2 commits
  2. 01 Oct, 2020 2 commits
    • Ingo Klöcker's avatar
      Generalize/simplify handling of common card info (e.g. app version) · 33381833
      Ingo Klöcker authored
      Card:
      * Add parseCardInfo() for parsing the common card infos APPVERSION,
        CARDTYPE, and CARDVERSION
      * Add cardtype() and cardVersion() returning the parsed card info
      * Add displayAppVersion() and displayCardVersion() returning nicely
        formatted version numbers
      
      OpenPGPCard:
      * Remove unused mIsV2
      * Remove obsolete setSerialNumber() overload and obsolete cardVersion()
        and mCardVersion; the app version (confusingly named mCardVersion)
        is now read from the card info by the base class
      * Rename setKeyPairInfo() to more appropriate setCardInfo() (also used
        for PIVCard)
      
      PIVCard:
      * Parsing of APPVERSION is now done by the base class
      
      ReaderStatus:
      * handle_openpgp_card: Use "LEARN --force" instead of
        "LEARN --keypairinfo" to also get common card infos
      
      ChangePinCommand, PGPCardWidget:
      * Simplify checks for certain app versions
      
      PGPCardWidget, PIVCardWidget:
      * Use Card::displayAppVersion() to get app version for display
      33381833
    • Ingo Klöcker's avatar
      Ensure that we use the correct card app if a card provides multiple apps · d292d1dc
      Ingo Klöcker authored
      To ensure this we always look up the cards by serial number _and_
      app name.
      
      GnuPG-bug-id: 5066
      d292d1dc
  3. 30 Sep, 2020 1 commit
  4. 29 Sep, 2020 1 commit
    • Ingo Klöcker's avatar
      Derive all card commands from CardCommand and CardCommand from Command · 32c6f48b
      Ingo Klöcker authored
      Command::Private:
      * Add two constructors for commands that are independent of
        KeyListController, but that may set a parent widget (e.g. for dialogs
        shown by the commands)
      * Simplify member initialization
      
      CardCommand:
      * Remove methods initially duplicated from Command
      * Remove empty default implementation of doCancel()
      
      AuthenticatePIVCardApplicationCommand, ChangePinCommand,
      PIVGenerateCardKeyCommand, SetPIVCardApplicationAdministrationKeyCommand:
      * Implement doCancel()
      * Adjust some calls of methods of super class
      
      CertificateToPIVCardCommand, KeyToCardCommand:
      * Derive from CardCommand instead of Command
      * Remove serialNumber member, get serial number from super class
      
      ImportCertificateFromDataCommand:
      * Add mId member to allow overriding the hard-coded id ("Notepad")
      
      ImportCertificateFromPIVCardCommand:
      * Derive from CardCommand instead of ImportCertificatesCommand
      * Use ImportCertificateFromDataCommand internally
      * Implement doCancel()
      
      GnuPG-bug-id: 5066
      32c6f48b
  5. 25 Aug, 2020 3 commits