1. 12 Oct, 2020 4 commits
  2. 10 Oct, 2020 1 commit
  3. 09 Oct, 2020 2 commits
    • Ingo Klöcker's avatar
      Ask user for target card if multiple cards are suitable for key to card · 81569bb8
      Ingo Klöcker authored
      Previously, always the first card was taken (under the assumption that
      it's the only inserted card).
      * Add possibility for subclasses to set the serial number
      * Remove superfluous supported() (always returned true)
      * Add static method for getting the suitable cards for a given subkey
      * Ask the user which card to write the key to if multiple suitable cards
        are available
      * Always show the "Transfer to smartcard" option if the secret subkey
        is available; disable the option if no suitable cards are available
      smartcard/utils.*, view/smartcardwidget.cpp:
      * Make displayAppName() available everywhere
      GnuPG-bug-id: 5066
    • Ingo Klöcker's avatar
      Fix class name in debug logging · e866e470
      Ingo Klöcker authored
  4. 08 Oct, 2020 2 commits
  5. 07 Oct, 2020 5 commits
    • Ingo Klöcker's avatar
      Show nicer card/app labels for the card/app tabs · bbe8d775
      Ingo Klöcker authored
      Card, PIVCard:
      * Add display serial number to the base class Card
      * Try to get the display serial number from scdaemon for all supported
        cards/card applications
      * Show only the display serial number; the full serial number is available
        as tooltip
      * Use display serial number and nicer app names for the labels of the
        card application tabs
      GnuPG-bug-id: 5066
    • Ingo Klöcker's avatar
      Improve handling of "card not present" situation · ff3e79e6
      Ingo Klöcker authored
      * Treat ENODEV error from scdaemon as "card not present" as done by
      * Only return an invalid dummy card if a real error occurred; if no
        card is present simply return an empty list of cards
      GnuPG-bug-id: 5066
    • Ingo Klöcker's avatar
    • Ingo Klöcker's avatar
      Show UI for all inserted cards in tabs · 762726ce
      Ingo Klöcker authored
      * Use more specific signals cardAdded, cardChanged, cardRemoved instead
        of just cardChanged.
      * Send serial number and app name (which uniquely identify an application
        on a smartcard) with the signals
      NetKeyWidget, PGPCardWidget, PIVCardWidget:
      * Remove double margins around the widgets; this also avoids an ugly
        lightgray border around the widgets
      * Use a QTabWidget with tabs for each application on the inserted
      GnuPG-bug-id: 5066
    • Ingo Klöcker's avatar
  6. 06 Oct, 2020 2 commits
    • Andre Heinecke's avatar
      Rename Export Secret keys to Backup · 0ea195ed
      Andre Heinecke authored
      It happened once too many times that someone sent me his
      secret key even though the filename now clearly says SECRET.
      I think using the word "Backup" is better. Because "Export" is
      something that you give away. "Backup" is something for yourself.
      Should also help with confusion about "Export your key in Kleopatra
      and send it to others."
      GnuPG-Bug-Id: T5095
    • Andre Heinecke's avatar
      Remove moved files · 2fbcef3d
      Andre Heinecke authored
      gnupg-helper now lives in libkleo under the name
  7. 05 Oct, 2020 6 commits
  8. 03 Oct, 2020 1 commit
  9. 01 Oct, 2020 3 commits
    • Ingo Klöcker's avatar
      Generalize/simplify handling of common card info (e.g. app version) · 33381833
      Ingo Klöcker authored
      * Add parseCardInfo() for parsing the common card infos APPVERSION,
      * Add cardtype() and cardVersion() returning the parsed card info
      * Add displayAppVersion() and displayCardVersion() returning nicely
        formatted version numbers
      * Remove unused mIsV2
      * Remove obsolete setSerialNumber() overload and obsolete cardVersion()
        and mCardVersion; the app version (confusingly named mCardVersion)
        is now read from the card info by the base class
      * Rename setKeyPairInfo() to more appropriate setCardInfo() (also used
        for PIVCard)
      * Parsing of APPVERSION is now done by the base class
      * handle_openpgp_card: Use "LEARN --force" instead of
        "LEARN --keypairinfo" to also get common card infos
      ChangePinCommand, PGPCardWidget:
      * Simplify checks for certain app versions
      PGPCardWidget, PIVCardWidget:
      * Use Card::displayAppVersion() to get app version for display
    • Ingo Klöcker's avatar
      Ensure that we use the correct card app if a card provides multiple apps · d292d1dc
      Ingo Klöcker authored
      To ensure this we always look up the cards by serial number _and_
      app name.
      GnuPG-bug-id: 5066
    • Ingo Klöcker's avatar
      Clean up/modernize Card and its subclasses a bit · 7ba9c16d
      Ingo Klöcker authored
      In particular, add constructors for converting a Card to the specific
      Card subclasses. This ensures that all state already set on a Card is
      copied to the specific subclass when we construct it. Previously, we
      copied the serial number (but no other state) manually.
      * Document that Card represents one of possibly many applications on
        a smartcard
      * Make setAppName() protected since it's only supposed to be called by
        the subclasses during initialization
      * Remove unused (and obsolete) mSlot, slot(), setSlot()
      * Initialize member variables in class definition
      NetKeyCard, OpenPGPCard, PIVCard:
      * Remove default constructors and unused constructors from serial number
      * Add constructors for converting a Card to the specific Card subclasses
  10. 30 Sep, 2020 5 commits
  11. 29 Sep, 2020 3 commits
    • Ingo Klöcker's avatar
      Make SetInitialPinCommand work on a card with given serial number · 044244a4
      Ingo Klöcker authored
      Previously, the command always worked on the "first" card.
      * Remove obsolete pinStates()
      GnuPG-bug-id: 5066
    • Ingo Klöcker's avatar
      Track first card with Null PIN instead of general "any card has Null PIN" · 6eac9b66
      Ingo Klöcker authored
      This makes it easier to handle multiple cards.
      GnuPG-bug-id: 5066
    • Ingo Klöcker's avatar
      Derive all card commands from CardCommand and CardCommand from Command · 32c6f48b
      Ingo Klöcker authored
      * Add two constructors for commands that are independent of
        KeyListController, but that may set a parent widget (e.g. for dialogs
        shown by the commands)
      * Simplify member initialization
      * Remove methods initially duplicated from Command
      * Remove empty default implementation of doCancel()
      AuthenticatePIVCardApplicationCommand, ChangePinCommand,
      PIVGenerateCardKeyCommand, SetPIVCardApplicationAdministrationKeyCommand:
      * Implement doCancel()
      * Adjust some calls of methods of super class
      CertificateToPIVCardCommand, KeyToCardCommand:
      * Derive from CardCommand instead of Command
      * Remove serialNumber member, get serial number from super class
      * Add mId member to allow overriding the hard-coded id ("Notepad")
      * Derive from CardCommand instead of ImportCertificatesCommand
      * Use ImportCertificateFromDataCommand internally
      * Implement doCancel()
      GnuPG-bug-id: 5066
  12. 22 Sep, 2020 3 commits
  13. 21 Sep, 2020 3 commits