GitLab

This changes the recently introduced check for users running
Kleopatra with elevated permissions to a warning. There are
still Windows users that run Kleopatra without any privilege
seperation whatsover on their system, they run everything
with full Administrative privileges. So for them the change
blocked usage of Kleopatra. I was unaware that this is still
possible in modern Windows versions as this is very hidden
and requires the user to disable safety systems.

GnuPG-Bug-Id: T5248

With Qt 5.13.2 (and still there in 5.15.0)
there was a regression that QTemporaryFile on Windows
UNC drives (unmounted Samba shares) have a bad filename even
though the file is correctly created. As the fix in Qt for
this is not trivial this adds a workaround to fix up the path name
and can probably be removed in a future version.

GnuPG-Bug-Id: T5216

gpgtar does not properly handle local 8 bit encoding
and interprets it internally as UTF-8 breaking the
folder name created by gpgtar. To avoid having wrong
encoding in the filenames we now pass it for the
unpack command with all special characters replaced
by underscore.

This is an ugly hack but better then to leave it broken
and this code is only used if configured in libkleopatrarc.

GnuPG-Bug-Id: T5226

This introduces a general Settings class instead of yet another
FooPreferences class.

GnuPG-bug-id: 5175

This adds the possibility to select groups of keys in the selection
dialog that can be opened when selecting recipients for encryption.

GnuPG-bug-id: 5175, 5241

GnuPG-bug-id: 5175, 5241

Group items are always top-level and do not have children, so that
they cannot be expanded/collapsed.

GnuPG-bug-id: 5175

GnuPG-bug-id: 5175, 5241

This makes handling of multiple selected entries in the selection
dialog much easier, especially, once groups can also be selected in the
selection dialog.

GnuPG-bug-id: 5175, 5241

GnuPG-bug-id: 5175, 5241, 5249

GnuPG-bug-id: 5175, 5241

Certificates for qualified signatures are issued together with the
physical cards. It's not possible to request a certificate for qualified
signatures for a self-generated key.

GnuPG-bug-id: 5129

When the EnterDetailsPage is created it is too early to
check for pgp() so we do it now when the result label
is updated as we then know if pgp was selected in
the dialog.

If GetUserName is used and not GetUserNameEx the size paremter
is one wchar_t too large and includes another \O. So it's better
to use fromWcharArray without size so that it only uses the
terminated string. If the zero is included in the GnuPG
key params it aborts parsing at that point and creates
a key without subkeys.

The key filter is changed when the user switches between OpenPGP and
S/MIME. This change wasn't propagated to the completer (so that the
completer showed matching keys/certificates for the wrong protocol) and
the key wasn't updated.

When 0 or 1 certificates matched the entered text, then the line action
indicated this. But when, after further editing, multiple certificates
matched, then the line action was not updated and still indicated 0 or 1
match.

The two mEdit* flags were never reset and therefore updateKey() never
set icon/tooltip to indicate that multiple certificates match the
current text.

Note: Setting the initial NKS PIN would also fail, but as long as the
NKS NullPIN is active a different code path is used.

GnuPG-bug-id: 5220

The problem is that the option secretOnly is incompatible with the
option includeSigs (aka key list mode Signatures) because gpgme does
"gpg --list-secret-keys" if secretOnly is true,
"gpg --check-sigs" if secretOnly is false, but signatures are requested,
"gpg --list-keys" if secretOnly is false and no signatures are requested.
See T3580.

This problem caused the tags to vanish from the key list for the users'
own keys as soon as they viewed the key details.

Using key list mode WithSecret instead of secretOnly fixes the problem.

Note: Adding key list mode Signatures is superfluous because the job
is already created with includeSigs.

GnuPG-bug-id: 5174

GnuPG-bug-id: 5174

Tag support is used in many places and the Tags column can be enabled
for one key list but disabled for another. Therefore, tag support
shouldn't be disabled just because the Tags column is disabled/not shown
in one key list.

GnuPG-bug-id: 5174

On any modern Windows (>=Vista) there is the concept of elevated
security privileges. That means that you can elevate a user
of the Administrator group to have Administrative privileges but
e.g. still the same home directory as the user. This can
lead to subtle issues when Kleopatra / GnuPG creates files when
running elevated and Kleo is then later run not elvated. So
we better check for that and exit early if thats the case.

GnuPG-Bug-Id: T5212

GIT_SILENT: use new cmake-3.19.0 feature. cmake --preset=dev or other it will provide correct cmake settings

This fixes the windows build by adding some missing
includes. QtGlobal is required to use the Q_OS_WIN macro.