GitLab

We simply use the text color also for links. Links are still
recognizable by the underlining.

GnuPG-bug-id: 5535

Qt does not use the QPalette::Link color when rendering rich text.
Therefore, we do it directly via the style-attribute of the <a> tag.

GnuPG-bug-id: 5535

* Make ResultItemWidget a composite widget that can receive focus.
* Ensure correct focus order when adding a new result item widget.
* Add forceSetTabOrder helper for setting the focus order of widgets
  with any focus policy (including Qt::NoFocus).

GnuPG-bug-id: 5535

In particular, this ensures the correct focus order of the widgets.

GnuPG-bug-id: 5535

GnuPG-bug-id: 5535

Before, information on unknown recipients was shown (with early exit)
before the "No MDC" hint, i.e. in case of a symmetrically encrypted
message with additional public key encryption the "No MDC" hint
would not have been shown.

GnuPG-bug-id: 5535

In this case checking the compliance of the decryption (which didn't
happen) or showing the embedded filename (which is not available without
decryption) makes no sense.

GnuPG-bug-id: 5535

This change fixes a logic error/regression introduced with revision
54ae2682c871d24f16177e1b761de3fea46e59ce (in kdepim repo before the
split).

GnuPG-bug-id: 5535

Set useful tooltips (e.g. for screen readers) for the line edit in case
no certificates or multiple certificates match the user input.

GnuPG-bug-id: 5535

* Add UrlLabel, a label for displaying a single link, which
  * automatically gives focus to/selects the displayed link when the
    label gets focus,
  * sends a text selection event to the accessibility clients when
    a link is selected,
  * works around a bug in QLabel::focusNextPrevChild(false)
* Add AccessibleRichTextLabel which allows accessibility clients to
  retrieve the selected text of a UrlLabel
* Use UrlLabel for the Diagnostics/Show Audit Log label

GnuPG-bug-id: 5535

Check only enabled recipient widgets for valid key/group. List all
unresolved recipients in the error message.

GnuPG-bug-id: 5582

(cherry picked from commit c16459aa)

For some reason the screen reader "reads" the Close button even if it's
hidden. It seems that Qt somehow gives it (local) focus, but not
application wide focus.

GnuPG-bug-id: 5535

GnuPG-bug-id: 5535

GnuPG-bug-id: 5535

If one presses Return while a recipient input widget has focus, then the
wizard switches to the next page and the SignEncryptWidget emits an
operationChanged signal which triggers an update of the commit button.
This update needs to be ignored, so that the label text that is
cleared in initializePage() of the second page is not set again.

GnuPG-bug-id: 5535

This ensures that the VS-NfD compliance hint is read by screen readers
when the commit button gets focus or is read for some other reason.

GnuPG-bug-id: 5535

updateCommitButton implicitly triggers the creation of a custom wizard
button which inserts the wizard buttons into the focus chain before the
output widgets. To fix the tab order we need to call updateCommitButton
after the creation of the output widgets.

GnuPG-bug-id: 5535

If there are no secret keys in the keyring, then disable the "sign as"
option and the "encrypt to me" option. (The latter because we currently
require a secret key for the "encrypt to me" key.)
If there are no public keys in the keyring (and therefore also no secret
keys), then disable the "encrypt for others" option and check the
"encrypt with passphrase" option which is the only possible operation in
this case.

GnuPG-bug-id: 5535

If there are no keys in the keyring, then we check the visibility
of the requesters before the dialog is shown on screen, i.e. before
the dialog is visible, so that isVisible() returns false even for
those requesters that were not explicitly set to "not visible". What
we actually want to find is not the first visible widget, but the
first widget that is not explicitly hidden. Therefore, we need to check
for !isHidden() instead of isVisible().

GnuPG-bug-id: 5535

GnuPG-bug-id: 5535

i.e. name of signature file before names of encrypted files.

GnuPG-bug-id: 5535

GnuPG-bug-id: 5535

Create the filename requesters when setting up the rest of the UI. In
particular, this ensures correct tab order.

GnuPG-bug-id: 5535

If the recipient field to remove has focus, then we move the focus to
the next recipient field or, if the field to remove is the last one, to
the previous recipient field. Since there are at least two (empty) fields,
if we remove the field, we don't have to consider the case that there are
no remaining fields.

GnuPG-bug-id: 5535

... because this may result in multiple empty recipient fields. Instead
trigger recipientsChanged() and make this check for completely empty
recipient fields instead of for fields with no key or group. There may
be non-empty recipient fields where the text doesn't match any key or
group.

GnuPG-bug-id: 5535

GnuPG-bug-id: 5535

GnuPG-bug-id: 5535

Use a separate box layout for the recipient widgets instead of fitting
them into a grid. This makes in particular the removal of widgets way
easier. Moreover, scrolling the recipient widget which has focus into
view works (almost) automatically.

GnuPG-bug-id: 5535

Decouple the update of the UI after a change of the protocol from
setting the protocol. This way we can initialize the protocol already
in-class and still setup the UI depending on the protocol without having
to rely on the uninitialized mCurrentProto being different from
GpgME::UnknownProtocol.

The initialization of mCurrentProto in-class also ensures that other
setup code uses the correct value.

GnuPG-bug-id: 5535

Set the focus policy of the scroll area to NoFocus. I think it makes no
sense to be able to give keyboard focus to the scroll area. On the
contrary, it was really confusing because neither the screen reader nor
the display gave any hint about which part of the GUI now has focus.
Took me some time and some additional debug output to figure this out.

GnuPG-bug-id: 5535

* Remove explicit setting of alignment of one of the two group boxes
  to AlignLeft which is the default anyway.
* Remove obsolete connects. encBox is not checkable anymore since a long
  time.

GnuPG-bug-id: 5535

* Add a label with explicit shortcut
* Make the widgets wrapping the filename requesters usable as buddy
* Set the first visible filename requester as buddy of the label

GnuPG-bug-id: 5544

Note: Qt automatically assigns shortcuts if one presses and holds the Alt
key, but for documentation purposes and better accessibility we explicitly
set shortcuts.

GnuPG-bug-id: 5544

GnuPG-bug-id: 5545

QWizard (re)sets the button texts to the default texts when switching
pages unless custom button texts have been set. To prevent our button
texts from being overwritten we need to set custom button texts with
QWizard::setButtonText() instead of setting the text of the button
directly.

GnuPG-bug-id: 5545

GnuPG-bug-id: 5545