GitLab

* Boost min ver 1.34 -> 1.58
* Boost_INCLUDE_DIR -> Boost_INCLUDE_DIRS (DIR is for internal usage)
* Switch to use C++17

In order to avoid clash with the standard <exception> header
on case-insensitive systems, libkleo's Exception header has been
renamed to KleoException.

This uses gpgconf to look up the homedir of GnuPG and we now
work internally with UTF-8 filenames which are passed through
gpgrt in the end to have Windows UTF-16 conversion. This
fixes a crash / assert when Kleopatra is run from a homedirectory
that contains a non 8 bit character on Windows.

GnuPG-bug-id: 5094

"bad" includes "revoked", "expired", and "disabled".

This bumps the required libkleo version and uses the
isBad name instead of isInvalid.

To develop for Windows we often compile libkleo and kleopatra
with older kde frameworks. The Gpg4win build system patched
that but it is better to have it in the repo itself.

The release scripts that bump the dependencies in general
should still work.

More precisely, this revokes certifications (i.e. signatures) for
user IDs of OpenPGP keys. Needs GnuPG >= 2.2.24 (soon to be released)
and gpgme >= 1.14.1 (unreleased).

GnuPG-bug-id: 5094

* Add/move actions to switch between the three main views (certificate
  overview, notepad, smartcard management) to the View menu and to the
  toolbar
* Remove now obsolete Back button from smartcard management

GnuPG-bug-id: 5108

Use the new DEVINFO --watch command to watch for status changes of
smartcard devices instead of using a file system watcher to watch
certain files. As with the old approach we are only notified about
the removal of smartcards unless we/the user explicitly trigger/s a
rescan (with the SERIALNO --all command).

GnuPG-bug-id: 5066

The timestamp needs to be in UTC. QDateTime::fromSecsSinceEpoch()
uses local time by default, so we need to request UTC explicitly.
The wrong creation timestamp resulted in a different creation
time stored on the card than stored locally. And, since the creation
time is included in the calculation of the fingerprint, this also
resulted in different fingerprints stored on the card and locally.

... because for card keys we do not have the secret key available for
import to a card

GnuPG-bug-id: 4794

GnuPG-bug-id: 4794

Card, OpenPGPCard:
* Get card holder name from the card info for all types of card/apps
  (scdaemon currently only provides the card holder for the OpenPGP app)

GnuPG-bug-id: 5066

Previously, always the first card was taken (under the assumption that
it's the only inserted card).

CardCommand::Private:
* Add possibility for subclasses to set the serial number

KeyToCardCommand:
* Remove superfluous supported() (always returned true)
* Add static method for getting the suitable cards for a given subkey
* Ask the user which card to write the key to if multiple suitable cards
  are available

SubKeysWidget:
* Always show the "Transfer to smartcard" option if the secret subkey
  is available; disable the option if no suitable cards are available

smartcard/utils.*, view/smartcardwidget.cpp:
* Make displayAppName() available everywhere

GnuPG-bug-id: 5066

* For OpenPGP card serial number add a space between manufacturer id and
  card id (as printed on actual OpenPGP cards and as done by gpg-agent
  when asking for a card)
* For Yubikey tokens show Yubikey id printed on the tokens (working
  around a bug in scdaemon)

GnuPG-bug-id: 5066

GnuPG-bug-id: 5066

Card, PIVCard:
* Add display serial number to the base class Card

ReaderStatus:
* Try to get the display serial number from scdaemon for all supported
  cards/card applications

PIVCardWidget:
* Show only the display serial number; the full serial number is available
  as tooltip

SmartCardWidget:
* Use display serial number and nicer app names for the labels of the
  card application tabs

GnuPG-bug-id: 5066

* Treat ENODEV error from scdaemon as "card not present" as done by
  gpg-card
* Only return an invalid dummy card if a real error occurred; if no
  card is present simply return an empty list of cards

GnuPG-bug-id: 5066

ReaderStatus:
* Use more specific signals cardAdded, cardChanged, cardRemoved instead
  of just cardChanged.
* Send serial number and app name (which uniquely identify an application
  on a smartcard) with the signals

NetKeyWidget, PGPCardWidget, PIVCardWidget:
* Remove double margins around the widgets; this also avoids an ugly
  lightgray border around the widgets

SmartCardWidget:
* Use a QTabWidget with tabs for each application on the inserted
  smartcards

GnuPG-bug-id: 5066

It happened once too many times that someone sent me his
secret key even though the filename now clearly says SECRET.

I think using the word "Backup" is better. Because "Export" is
something that you give away. "Backup" is something for yourself.

Should also help with confusion about "Export your key in Kleopatra
and send it to others."

GnuPG-Bug-Id: T5095

gnupg-helper now lives in libkleo under the name
libkleo/src/utils/gnupg.cpp

Users don't know X.509. They have their S/MIME key and
their OpenPGP key.

GnuPG-Bug-Id: T5096

Different users require a different name for VS-NfD compliance
VS-NfD is something german and Kleopatra now also sees some
usage in NATO RESTRICTED, EU RESTRICTED, etc. use
cases. To better work for that we now take it from libkleopatrarc
so that it can be centrally configured for such deployments.

Most work from me in the last years was done for them.

On Windows we distribute Kleopatra as part of a package
and we take the about data from the filesystem to have it
match the Package Version.

GnuPG-Bug-Id: T5011

The gnupg-helper was added to Libkleo some time ago.
Use it now to avoid duplicated code.

We currently depend on 1.11 and don't need to guard against
1.8 anymore.

(cherry picked from commit 97b9f4e7)

Card:
* Add parseCardInfo() for parsing the common card infos APPVERSION,
  CARDTYPE, and CARDVERSION
* Add cardtype() and cardVersion() returning the parsed card info
* Add displayAppVersion() and displayCardVersion() returning nicely
  formatted version numbers

OpenPGPCard:
* Remove unused mIsV2
* Remove obsolete setSerialNumber() overload and obsolete cardVersion()
  and mCardVersion; the app version (confusingly named mCardVersion)
  is now read from the card info by the base class
* Rename setKeyPairInfo() to more appropriate setCardInfo() (also used
  for PIVCard)

PIVCard:
* Parsing of APPVERSION is now done by the base class

ReaderStatus:
* handle_openpgp_card: Use "LEARN --force" instead of
  "LEARN --keypairinfo" to also get common card infos

ChangePinCommand, PGPCardWidget:
* Simplify checks for certain app versions

PGPCardWidget, PIVCardWidget:
* Use Card::displayAppVersion() to get app version for display