Port foreach(...)

CMakeLists.txt

@@ -104,6 +104,7 @@ add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x050f00)
 add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054F00)
 add_definitions(-DQT_NO_SIGNALS_SLOTS_KEYWORDS)
 add_definitions(-DQT_NO_EMIT)
+add_definitions(-DQT_NO_FOREACH)
 set(CMAKE_CXX_STANDARD 14)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
 

src/dialog.cpp

@@ -193,7 +193,9 @@ SetupManager *Dialog::setupManager()
 
 void Dialog::clearDynamicPages()
 {
-    foreach (KPageWidgetItem *item, mDynamicPages) {
+    const auto dynamicPages = mDynamicPages;
+    for (int i = 0, total = dynamicPages.count(); i < total; ++i) {
+        KPageWidgetItem *item = mDynamicPages.at(i);
         removePage(item);
     }
     mDynamicPages.clear();

src/setupmanager.cpp

@@ -177,8 +177,10 @@ void SetupManager::rollback()
 {
     m_page->setStatus(i18n("Failed to set up account, rolling back..."));
     const int setupObjectCount = m_objectToSetup.size() + m_setupObjects.size();
-    int remainingObjectCount = m_setupObjects.size();
-    foreach (SetupObject *obj, m_setupObjects) {
+    const int remainingObjectCount = m_setupObjects.size();
+    const auto setupObjectsList = m_setupObjects;
+    for (int i = 0; i < setupObjectsList.count(); ++i) {
+        auto obj = m_setupObjects.at(i);
         m_page->setProgress((remainingObjectCount * 100) / setupObjectCount);
         if (obj) {
             obj->destroy();