Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
PIM
KMail
Commits
07f721a5
Commit
07f721a5
authored
Oct 02, 2020
by
Laurent Montel
😁
Browse files
Fix some cppcheck warning
parent
377a96aa
Pipeline
#36183
passed with stage
in 26 minutes and 26 seconds
Changes
4
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
ktnef/src/qwmf.cpp
View file @
07f721a5
...
...
@@ -165,7 +165,6 @@ bool QWinMetaFile::load(QBuffer &buffer)
WmfEnhMetaHeader
eheader
;
WmfMetaHeader
header
;
WmfPlaceableHeader
pheader
;
WORD
checksum
;
int
filePos
,
idx
,
i
;
WmfCmd
*
cmd
,
*
last
;
DWORD
rdSize
;
...
...
@@ -194,7 +193,7 @@ bool QWinMetaFile::load(QBuffer &buffer)
st
>>
pheader
.
inch
;
st
>>
pheader
.
reserved
;
st
>>
pheader
.
checksum
;
checksum
=
calcCheckSum
(
&
pheader
);
const
WORD
checksum
=
calcCheckSum
(
&
pheader
);
if
(
pheader
.
checksum
!=
checksum
)
{
mIsPlaceable
=
false
;
}
...
...
src/editor/potentialphishingemail/potentialphishingdetailwidget.cpp
View file @
07f721a5
...
...
@@ -15,6 +15,7 @@
PotentialPhishingDetailWidget
::
PotentialPhishingDetailWidget
(
QWidget
*
parent
)
:
QWidget
(
parent
)
,
mListWidget
(
new
QListWidget
(
this
))
{
QVBoxLayout
*
mainLayout
=
new
QVBoxLayout
(
this
);
mainLayout
->
setContentsMargins
(
0
,
0
,
0
,
0
);
...
...
@@ -22,7 +23,6 @@ PotentialPhishingDetailWidget::PotentialPhishingDetailWidget(QWidget *parent)
lab
->
setObjectName
(
QStringLiteral
(
"label"
));
mainLayout
->
addWidget
(
lab
);
mListWidget
=
new
QListWidget
(
this
);
mListWidget
->
setObjectName
(
QStringLiteral
(
"list_widget"
));
mainLayout
->
addWidget
(
mListWidget
);
}
...
...
src/editor/potentialphishingemail/potentialphishingdetailwidget.h
View file @
07f721a5
...
...
@@ -22,7 +22,7 @@ public:
void
fillList
(
const
QStringList
&
lst
);
private:
QListWidget
*
mListWidget
=
nullptr
;
QListWidget
*
const
mListWidget
=
nullptr
;
};
#endif // POTENTIALPHISHINGDETAILWIDGET_H
src/identity/identitypage.cpp
View file @
07f721a5
...
...
@@ -225,11 +225,11 @@ void IdentityPage::slotRemoveIdentity()
KGuiItem
(
i18n
(
"&Remove"
),
QStringLiteral
(
"edit-delete"
)))
==
KMessageBox
::
Continue
)
{
for
(
QTreeWidgetItem
*
item
:
selectedItems
)
{
for
(
QTreeWidgetItem
*
selected
item
:
selectedItems
)
{
IdentityListViewItem
*
identityItem
=
dynamic_cast
<
IdentityListViewItem
*>
(
item
);
identityName
=
identityItem
->
identity
().
identityName
();
if
(
mIdentityManager
->
removeIdentity
(
identityName
))
{
delete
item
;
delete
selected
item
;
}
if
(
mIPage
.
mIdentityList
->
currentItem
())
{
mIPage
.
mIdentityList
->
currentItem
()
->
setSelected
(
true
);
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment