Make it const + remove mem leak

src/editor/kmcomposerwin.cpp

@@ -239,6 +239,7 @@ KMComposerWin::KMComposerWin(const KMime::Message::Ptr &aMsg,
     , mId(id)
     , mContext(context)
     , mTooMyRecipientWarning(new TooManyRecipientsWarning(this))
+    , mIncorrectIdentityFolderWarning(new IncorrectIdentityFolderWarning(this))
     , mPluginEditorManagerInterface(new KMailPluginEditorManagerInterface(this))
     , mPluginEditorGrammarManagerInterface(new KMailPluginGrammarEditorManagerInterface(this))
 
@@ -373,12 +374,11 @@ KMComposerWin::KMComposerWin(const KMime::Message::Ptr &aMsg,
     connect(composerEditorNg, &KMComposerEditorNg::selectionChanged, this, &KMComposerWin::slotSelectionChanged);
     // connect(editor, &KMComposerEditor::textChanged, this, &KMComposeWin::slotEditorTextChanged);
     mComposerBase->setEditor(composerEditorNg);
-    mIncorrectIdentityFolderWarning = new IncorrectIdentityFolderWarning(this);
+
     vbox->addWidget(mIncorrectIdentityFolderWarning);
 
     mAttachmentFromExternalMissing = new AttachmentAddedFromExternalWarning(this);
     vbox->addWidget(mAttachmentFromExternalMissing);
-    mTooMyRecipientWarning = new TooManyRecipientsWarning(this);
     vbox->addWidget(mTooMyRecipientWarning);
 
     vbox->addWidget(mCryptoStateIndicatorWidget);

src/editor/kmcomposerwin.h

@@ -678,7 +678,7 @@ private:
     PimCommon::CustomToolsWidgetNg *mCustomToolsWidget = nullptr;
     AttachmentMissingWarning *mAttachmentMissing = nullptr;
     ExternalEditorWarning *mExternalEditorWarning = nullptr;
-    TooManyRecipientsWarning *mTooMyRecipientWarning = nullptr;
+    TooManyRecipientsWarning *const mTooMyRecipientWarning;
     QTimer *mVerifyMissingAttachment = nullptr;
     MailCommon::FolderRequester *mFccFolder = nullptr;
     bool mPreventFccOverwrite = false;
@@ -691,7 +691,7 @@ private:
     MessageComposer::StatusBarLabelToggledState *mStatusBarLabelToggledOverrideMode = nullptr;
     MessageComposer::StatusBarLabelToggledState *mStatusBarLabelSpellCheckingChangeMode = nullptr;
     PotentialPhishingEmailWarning *mPotentialPhishingEmailWarning = nullptr;
-    IncorrectIdentityFolderWarning *mIncorrectIdentityFolderWarning = nullptr;
+    IncorrectIdentityFolderWarning *const mIncorrectIdentityFolderWarning;
     KMComposerGlobalAction *mGlobalAction = nullptr;
     KPIMTextEdit::RichTextEditorWidget *mRichTextEditorwidget = nullptr;