GIT_SILENT: Use more target-centric cmake code

agents/archivemailagent/CMakeLists.txt

@@ -2,7 +2,8 @@
 # SPDX-License-Identifier: BSD-3-Clause
 add_definitions(-DTRANSLATION_DOMAIN=\"akonadi_archivemail_agent\")
 
-set(libarchivemailagent_SRCS
+add_library(archivemailagent STATIC)
+target_sources(archivemailagent PRIVATE
     archivemailkernel.cpp
     archivemailmanager.cpp
     archivemailinfo.cpp
@@ -10,23 +11,23 @@ set(libarchivemailagent_SRCS
     archivemailagentutil.cpp
     )
 
-kconfig_add_kcfg_files(libarchivemailagent_SRCS
+kconfig_add_kcfg_files(archivemailagent
     settings/archivemailagentsettings.kcfgc
     )
 
 
 qt_add_dbus_adaptor(libarchivemailagent_SRCS org.freedesktop.Akonadi.ArchiveMailAgent.xml archivemailagent.h ArchiveMailAgent)
+target_sources(archivemailagent PRIVATE ${libarchivemailagent_SRCS})
 
-ecm_qt_declare_logging_category(libarchivemailagent_SRCS HEADER archivemailagent_debug.h IDENTIFIER ARCHIVEMAILAGENT_LOG CATEGORY_NAME org.kde.pim.archivemailagent
+ecm_qt_declare_logging_category(archivemailagent HEADER archivemailagent_debug.h IDENTIFIER ARCHIVEMAILAGENT_LOG CATEGORY_NAME org.kde.pim.archivemailagent
         DESCRIPTION "kmail (archivemailagent)"
         OLD_CATEGORY_NAMES log_archivemailagent
         EXPORT KMAIL
     )
 
 
-ki18n_wrap_ui(libarchivemailagent_SRCS ui/archivemailwidget.ui )
+ki18n_wrap_ui(archivemailagent ui/archivemailwidget.ui )
 
-add_library(archivemailagent STATIC ${libarchivemailagent_SRCS})
 pim_target_precompile_headers(archivemailagent PUBLIC ../../kmail_pch.h)
 #if (COMPILE_WITH_UNITY_CMAKE_SUPPORT)
 #    set_target_properties(archivemailagent PROPERTIES UNITY_BUILD ON)

kmail-refresh-settings/CMakeLists.txt

-set(kmail-refresh-settings_SRCS
+add_executable(kmail-refresh-settings)
+target_sources(kmail-refresh-settings PRIVATE
     main.cpp
     refreshsettingsassistant.cpp
     refreshsettringsfinishpage.cpp
@@ -6,13 +7,12 @@ set(kmail-refresh-settings_SRCS
     refreshsettingsfirstpage.cpp
     )
 
-ecm_qt_declare_logging_category(kmail-refresh-settings_SRCS HEADER kmail-refresh-settings_debug.h IDENTIFIER KMAIL_REFRESH_SETTINGS_LOG CATEGORY_NAME org.kde.pim.kmail_refresh_settings
+ecm_qt_declare_logging_category(kmail-refresh-settings HEADER kmail-refresh-settings_debug.h IDENTIFIER KMAIL_REFRESH_SETTINGS_LOG CATEGORY_NAME org.kde.pim.kmail_refresh_settings
         DESCRIPTION "kmail-refresh-settings"
         EXPORT KMAIL
     )
 
 
-add_executable(kmail-refresh-settings ${kmail-refresh-settings_SRCS})
 if (COMPILE_WITH_UNITY_CMAKE_SUPPORT)
     set_target_properties(kmail-refresh-settings PROPERTIES UNITY_BUILD ON)
 endif()

ktnef/src/CMakeLists.txt

 configure_file(ktnef-version.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/ktnef-version.h @ONLY)
 
 add_subdirectory(pics)
+add_executable(ktnef)
 
-set(ktnef_SRCS
+target_sources(ktnef PRIVATE
     attachpropertydialog.cpp
     ktnefmain.cpp
     ktnefview.cpp
@@ -12,18 +13,17 @@ set(ktnef_SRCS
     ktnef.qrc
     )
 
-ecm_qt_declare_logging_category(ktnef_SRCS HEADER ktnef_debug.h IDENTIFIER KTNEFAPPS_LOG CATEGORY_NAME org.kde.pim.ktnefapps
+ecm_qt_declare_logging_category(ktnef HEADER ktnef_debug.h IDENTIFIER KTNEFAPPS_LOG CATEGORY_NAME org.kde.pim.ktnefapps
         DESCRIPTION "kmail-refresh-settings"
         EXPORT KMAIL
     )
 
 
 file(GLOB ICONS_SRCS "${CMAKE_CURRENT_SOURCE_DIR}/pics/hicolor/*-apps-ktnef.png")
-ecm_add_app_icon(ktnef_SRCS ICONS ${ICONS_SRCS})
+ecm_add_app_icon(ktnef ICONS ${ICONS_SRCS})
 
-ki18n_wrap_ui(ktnef_SRCS ui/attachpropertywidgetbase.ui)
+ki18n_wrap_ui(ktnef ui/attachpropertywidgetbase.ui)
 
-add_executable(ktnef ${ktnef_SRCS})
 if (COMPILE_WITH_UNITY_CMAKE_SUPPORT)
     set_target_properties(ktnef PROPERTIES UNITY_BUILD ON)
 endif()