Commit 8f6dbec1 authored by Laurent Montel's avatar Laurent Montel 😁
Browse files

Not necessary to use qOverload here

parent 92dbc919
Pipeline #82763 passed with stage
in 25 minutes and 34 seconds
......@@ -143,7 +143,7 @@ FilterLogDialog::FilterLogDialog(QWidget *parent)
mLogMemLimitSpin->setValue(FilterLog::instance()->maxLogSize() / 1024);
mLogMemLimitSpin->setSuffix(i18n(" KB"));
mLogMemLimitSpin->setSpecialValueText(i18nc("@label:spinbox Set the size of the logfile to unlimited.", "unlimited"));
connect(mLogMemLimitSpin, qOverload<int>(&QSpinBox::valueChanged), this, &FilterLogDialog::slotChangeLogMemLimit);
connect(mLogMemLimitSpin, &QSpinBox::valueChanged, this, &FilterLogDialog::slotChangeLogMemLimit);
mLogMemLimitSpin->setWhatsThis(
i18n("Collecting log data uses memory to temporarily store the "
"log data; here you can limit the maximum amount of memory "
......
......@@ -347,7 +347,7 @@ AppearancePageColorsTab::AppearancePageColorsTab(QWidget *parent)
mCloseToQuotaThreshold = new QSpinBox(this);
mCloseToQuotaThreshold->setRange(0, 100);
mCloseToQuotaThreshold->setSingleStep(1);
connect(mCloseToQuotaThreshold, qOverload<int>(&QSpinBox::valueChanged), this, &ConfigModuleTab::slotEmitChanged);
connect(mCloseToQuotaThreshold, &QSpinBox::valueChanged, this, &ConfigModuleTab::slotEmitChanged);
mCloseToQuotaThreshold->setSuffix(i18n("%"));
hbox->addWidget(mCloseToQuotaThreshold);
......@@ -462,7 +462,7 @@ AppearancePageLayoutTab::AppearancePageLayoutTab(QWidget *parent)
Qt::Vertical,
KMailSettings::self()->folderListItem());
vlay->addWidget(mFolderListGroupBox);
connect(mFolderListGroup, qOverload<QAbstractButton *>(&QButtonGroup::buttonClicked), this, &ConfigModuleTab::slotEmitChanged);
connect(mFolderListGroup, &QButtonGroup::buttonClicked, this, &ConfigModuleTab::slotEmitChanged);
auto folderCBHLayout = new QHBoxLayout;
mFolderQuickSearchCB = new QCheckBox(i18n("Show folder quick search field"), this);
......@@ -475,7 +475,7 @@ AppearancePageLayoutTab::AppearancePageLayoutTab(QWidget *parent)
mFavoriteFoldersViewGroupBox->setTitle(i18n("Show Favorite Folders View"));
mFavoriteFoldersViewGroupBox->setLayout(new QVBoxLayout());
mFavoriteFoldersViewGroup = new QButtonGroup(this);
connect(mFavoriteFoldersViewGroup, qOverload<QAbstractButton *>(&QButtonGroup::buttonClicked), this, &ConfigModuleTab::slotEmitChanged);
connect(mFavoriteFoldersViewGroup, &QButtonGroup::buttonClicked, this, &ConfigModuleTab::slotEmitChanged);
auto favoriteFoldersViewHiddenRadio = new QRadioButton(i18n("Never"), mFavoriteFoldersViewGroupBox);
mFavoriteFoldersViewGroup->addButton(favoriteFoldersViewHiddenRadio,
......@@ -499,7 +499,7 @@ AppearancePageLayoutTab::AppearancePageLayoutTab(QWidget *parent)
mFolderToolTipsGroupBox->setTitle(i18n("Folder Tooltips"));
mFolderToolTipsGroupBox->setLayout(new QVBoxLayout());
mFolderToolTipsGroup = new QButtonGroup(this);
connect(mFolderToolTipsGroup, qOverload<QAbstractButton *>(&QButtonGroup::buttonClicked), this, &ConfigModuleTab::slotEmitChanged);
connect(mFolderToolTipsGroup, &QButtonGroup::buttonClicked, this, &ConfigModuleTab::slotEmitChanged);
auto folderToolTipsAlwaysRadio = new QRadioButton(i18n("Always"), mFolderToolTipsGroupBox);
mFolderToolTipsGroup->addButton(folderToolTipsAlwaysRadio, static_cast<int>(FolderTreeWidget::DisplayAlways));
......@@ -518,7 +518,7 @@ AppearancePageLayoutTab::AppearancePageLayoutTab(QWidget *parent)
KMailSettings::self()->readerWindowModeItem());
vlay->addWidget(mReaderWindowModeGroupBox);
connect(mReaderWindowModeGroup, qOverload<QAbstractButton *>(&QButtonGroup::buttonClicked), this, &ConfigModuleTab::slotEmitChanged);
connect(mReaderWindowModeGroup, &QButtonGroup::buttonClicked, this, &ConfigModuleTab::slotEmitChanged);
vlay->addStretch(10); // spacer
}
......@@ -592,7 +592,7 @@ AppearancePageHeadersTab::AppearancePageHeadersTab(QWidget *parent)
&MessageList::Utils::AggregationConfigButton::configureDialogCompleted,
this,
&AppearancePageHeadersTab::slotSelectDefaultAggregation);
connect(mAggregationComboBox, qOverload<int>(&MessageList::Utils::AggregationComboBox::activated), this, &ConfigModuleTab::slotEmitChanged);
connect(mAggregationComboBox, &MessageList::Utils::AggregationComboBox::activated, this, &ConfigModuleTab::slotEmitChanged);
// "Theme"
using MessageList::Utils::ThemeComboBox;
......@@ -607,7 +607,7 @@ AppearancePageHeadersTab::AppearancePageHeadersTab(QWidget *parent)
formLayout->addRow(i18n("Default theme:"), themeLayout);
connect(themeConfigButton, &MessageList::Utils::ThemeConfigButton::configureDialogCompleted, this, &AppearancePageHeadersTab::slotSelectDefaultTheme);
connect(mThemeComboBox, qOverload<int>(&MessageList::Utils::ThemeComboBox::activated), this, &ConfigModuleTab::slotEmitChanged);
connect(mThemeComboBox, &MessageList::Utils::ThemeComboBox::activated, this, &ConfigModuleTab::slotEmitChanged);
// "Date Display" group:
mDateDisplay = new QButtonGroup(this);
......@@ -689,7 +689,7 @@ AppearancePageHeadersTab::AppearancePageHeadersTab(QWidget *parent)
}
} // end for loop populating mDateDisplay
connect(mDateDisplay, qOverload<QAbstractButton *>(&QButtonGroup::buttonClicked), this, &ConfigModuleTab::slotEmitChanged);
connect(mDateDisplay, &QButtonGroup::buttonClicked, this, &ConfigModuleTab::slotEmitChanged);
}
void AppearancePageHeadersTab::slotLinkClicked(const QString &link)
......
......@@ -232,7 +232,7 @@ ComposerPageGeneralTab::ComposerPageGeneralTab(QWidget *parent)
mWrapColumnSpin->setWhatsThis(helpText);
connect(mWordWrapCheck, &QCheckBox::stateChanged, this, &ConfigModuleTab::slotEmitChanged);
connect(mWrapColumnSpin, qOverload<int>(&QSpinBox::valueChanged), this, &ComposerPageGeneralTab::slotEmitChanged);
connect(mWrapColumnSpin, &QSpinBox::valueChanged, this, &ComposerPageGeneralTab::slotEmitChanged);
// only enable the spinbox if the checkbox is checked
connect(mWordWrapCheck, &QAbstractButton::toggled, mWrapColumnSpin, &QWidget::setEnabled);
......@@ -342,7 +342,7 @@ ComposerPageGeneralTab::ComposerPageGeneralTab(QWidget *parent)
mRecipientSpin->setToolTip(i18n("Set the maximum number of recipients for the warning"));
connect(mRecipientCheck, &QCheckBox::stateChanged, this, &ComposerPageGeneralTab::slotEmitChanged);
connect(mRecipientSpin, qOverload<int>(&QSpinBox::valueChanged), this, &ComposerPageGeneralTab::slotEmitChanged);
connect(mRecipientSpin, &QSpinBox::valueChanged, this, &ComposerPageGeneralTab::slotEmitChanged);
// only enable the spinbox if the checkbox is checked
connect(mRecipientCheck, &QCheckBox::toggled, mRecipientSpin, &QSpinBox::setEnabled);
......@@ -371,7 +371,7 @@ ComposerPageGeneralTab::ComposerPageGeneralTab(QWidget *parent)
label = new QLabel(MessageComposer::MessageComposerSettings::self()->maximumRecipientsItem()->label(), this);
label->setBuddy(mMaximumRecipients);
connect(mMaximumRecipients, qOverload<int>(&QSpinBox::valueChanged), this, &ConfigModuleTab::slotEmitChanged);
connect(mMaximumRecipients, &QSpinBox::valueChanged, this, &ConfigModuleTab::slotEmitChanged);
groupGridLayout->addWidget(label, row, 0, 1, 2);
groupGridLayout->addWidget(mMaximumRecipients, row, 2);
......@@ -410,7 +410,7 @@ ComposerPageGeneralTab::ComposerPageGeneralTab(QWidget *parent)
mMaximumRecentAddress->setToolTip(helpText);
mMaximumRecentAddress->setWhatsThis(helpText);
connect(mMaximumRecentAddress, qOverload<int>(&QSpinBox::valueChanged), this, &ConfigModuleTab::slotEmitChanged);
connect(mMaximumRecentAddress, &QSpinBox::valueChanged, this, &ConfigModuleTab::slotEmitChanged);
connect(mShowRecentAddressesInComposer, &QAbstractButton::toggled, mMaximumRecentAddress, &QWidget::setEnabled);
connect(mShowRecentAddressesInComposer, &QAbstractButton::toggled, label, &QWidget::setEnabled);
......@@ -448,7 +448,7 @@ ComposerPageGeneralTab::ComposerPageGeneralTab(QWidget *parent)
label = new QLabel(KMailSettings::self()->autosaveIntervalItem()->label(), this);
label->setBuddy(mAutoSave);
connect(mAutoSave, qOverload<int>(&QSpinBox::valueChanged), this, &ConfigModuleTab::slotEmitChanged);
connect(mAutoSave, &QSpinBox::valueChanged, this, &ConfigModuleTab::slotEmitChanged);
groupGridLayout->addWidget(label, row, 0);
groupGridLayout->addWidget(mAutoSave, row, 1);
......@@ -1143,7 +1143,7 @@ ComposerPageAttachmentsTab::ComposerPageAttachmentsTab(QWidget *parent)
mMaximumAttachmentSize->setRange(-1, 99999);
mMaximumAttachmentSize->setSingleStep(100);
mMaximumAttachmentSize->setSuffix(i18nc("spinbox suffix: unit for kilobyte", " kB"));
connect(mMaximumAttachmentSize, qOverload<int>(&QSpinBox::valueChanged), this, &ConfigModuleTab::slotEmitChanged);
connect(mMaximumAttachmentSize, &QSpinBox::valueChanged, this, &ConfigModuleTab::slotEmitChanged);
mMaximumAttachmentSize->setSpecialValueText(i18n("No limit"));
layAttachment->addWidget(mMaximumAttachmentSize);
vlay->addLayout(layAttachment);
......
......@@ -65,7 +65,7 @@ MiscPageFolderTab::MiscPageFolderTab(QWidget *parent)
connect(mMMTab.mExcludeImportantFromExpiry, &QCheckBox::stateChanged, this, &MiscPageFolderTab::slotEmitChanged);
connect(mMMTab.mLoopOnGotoUnread, &QComboBox::activated, this, &MiscPageFolderTab::slotEmitChanged);
connect(mMMTab.mActionEnterFolder, &QComboBox::activated, this, &MiscPageFolderTab::slotEmitChanged);
connect(mMMTab.mDelayedMarkTime, qOverload<int>(&QSpinBox::valueChanged), this, &MiscPageFolderTab::slotEmitChanged);
connect(mMMTab.mDelayedMarkTime, &QSpinBox::valueChanged, this, &MiscPageFolderTab::slotEmitChanged);
connect(mMMTab.mDelayedMarkAsRead, &QAbstractButton::toggled, mMMTab.mDelayedMarkTime, &QWidget::setEnabled);
connect(mMMTab.mDelayedMarkAsRead, &QAbstractButton::toggled, this, &ConfigModuleTab::slotEmitChanged);
connect(mMMTab.mShowPopupAfterDnD, &QCheckBox::stateChanged, this, &MiscPageFolderTab::slotEmitChanged);
......
......@@ -172,7 +172,7 @@ SecurityPageMDNTab::SecurityPageMDNTab(QWidget *parent)
// "ignore", "ask", "deny", "always send" radiobuttons
mMDNGroup = new QButtonGroup(this);
connect(mMDNGroup, qOverload<QAbstractButton *>(&QButtonGroup::buttonClicked), this, &SecurityPageMDNTab::slotEmitChanged);
connect(mMDNGroup, &QButtonGroup::buttonClicked, this, &SecurityPageMDNTab::slotEmitChanged);
mMDNGroup->addButton(mUi.radioIgnore, 0);
mMDNGroup->addButton(mUi.radioAsk, 1);
mMDNGroup->addButton(mUi.radioDeny, 2);
......@@ -180,7 +180,7 @@ SecurityPageMDNTab::SecurityPageMDNTab(QWidget *parent)
// "Original Message quote" radiobuttons
mOrigQuoteGroup = new QButtonGroup(this);
connect(mOrigQuoteGroup, qOverload<QAbstractButton *>(&QButtonGroup::buttonClicked), this, &SecurityPageMDNTab::slotEmitChanged);
connect(mOrigQuoteGroup, &QButtonGroup::buttonClicked, this, &SecurityPageMDNTab::slotEmitChanged);
mOrigQuoteGroup->addButton(mUi.radioNothing, 0);
mOrigQuoteGroup->addButton(mUi.radioFull, 1);
mOrigQuoteGroup->addButton(mUi.radioHeaders, 2);
......@@ -287,12 +287,12 @@ SecurityPageWarningTab::SecurityPageWarningTab(QWidget *parent)
connect(mWidget->warnGroupBox, &QGroupBox::toggled, this, &SecurityPageWarningTab::slotEmitChanged);
connect(mWidget->mWarnUnsigned, &QCheckBox::toggled, this, &SecurityPageWarningTab::slotEmitChanged);
connect(mWidget->warnUnencryptedCB, &QCheckBox::toggled, this, &SecurityPageWarningTab::slotEmitChanged);
connect(mWidget->mWarnSignKeyExpiresSB, qOverload<int>(&KPluralHandlingSpinBox::valueChanged), this, &SecurityPageWarningTab::slotEmitChanged);
connect(mWidget->mWarnEncrKeyExpiresSB, qOverload<int>(&KPluralHandlingSpinBox::valueChanged), this, &SecurityPageWarningTab::slotEmitChanged);
connect(mWidget->mWarnEncrChainCertExpiresSB, qOverload<int>(&KPluralHandlingSpinBox::valueChanged), this, &SecurityPageWarningTab::slotEmitChanged);
connect(mWidget->mWarnSignChainCertExpiresSB, qOverload<int>(&KPluralHandlingSpinBox::valueChanged), this, &SecurityPageWarningTab::slotEmitChanged);
connect(mWidget->mWarnSignRootCertExpiresSB, qOverload<int>(&KPluralHandlingSpinBox::valueChanged), this, &SecurityPageWarningTab::slotEmitChanged);
connect(mWidget->mWarnEncrRootCertExpiresSB, qOverload<int>(&KPluralHandlingSpinBox::valueChanged), this, &SecurityPageWarningTab::slotEmitChanged);
connect(mWidget->mWarnSignKeyExpiresSB, &KPluralHandlingSpinBox::valueChanged, this, &SecurityPageWarningTab::slotEmitChanged);
connect(mWidget->mWarnEncrKeyExpiresSB, &KPluralHandlingSpinBox::valueChanged, this, &SecurityPageWarningTab::slotEmitChanged);
connect(mWidget->mWarnEncrChainCertExpiresSB, &KPluralHandlingSpinBox::valueChanged, this, &SecurityPageWarningTab::slotEmitChanged);
connect(mWidget->mWarnSignChainCertExpiresSB, &KPluralHandlingSpinBox::valueChanged, this, &SecurityPageWarningTab::slotEmitChanged);
connect(mWidget->mWarnSignRootCertExpiresSB, &KPluralHandlingSpinBox::valueChanged, this, &SecurityPageWarningTab::slotEmitChanged);
connect(mWidget->mWarnEncrRootCertExpiresSB, &KPluralHandlingSpinBox::valueChanged, this, &SecurityPageWarningTab::slotEmitChanged);
connect(mWidget->gnupgButton, &QPushButton::clicked, this, &SecurityPageWarningTab::slotConfigureGnupg);
connect(mWidget->enableAllWarningsPB, &QPushButton::clicked, this, &SecurityPageWarningTab::slotReenableAllWarningsClicked);
......
......@@ -145,7 +145,7 @@ void SummaryWidget::displayModel(const QModelIndex &parent, int &counter, const
stats.count(),
stats.unreadCount()));
connect(urlLabel, qOverload<>(&KUrlLabel::leftClickedUrl), this, [this, urlLabel]() {
connect(urlLabel, &KUrlLabel::leftClickedUrl, this, [this, urlLabel]() {
selectFolder(urlLabel->url());
});
......
......@@ -404,7 +404,7 @@ void SummaryViewPart::slotConfigure()
QPointer<KCMultiDialog> dlg = new KCMultiDialog(mMainWidget);
dlg->setObjectName(QStringLiteral("ConfigDialog"));
dlg->setModal(true);
connect(dlg.data(), qOverload<>(&KCMultiDialog::configCommitted), this, &SummaryViewPart::updateWidgets);
connect(dlg.data(), &KCMultiDialog::configCommitted, this, &SummaryViewPart::updateWidgets);
const auto metaDataList = KPluginMetaData::findPlugins(QStringLiteral("pim/kcms/summary/"));
for (const auto &metaData : metaDataList) {
dlg->addModule(metaData);
......
......@@ -28,7 +28,7 @@ SummaryView::SummaryView(KontactInterface::Core *core, const QVariantList &)
{
mSyncAction = new KSelectAction(QIcon::fromTheme(QStringLiteral("view-refresh")), i18n("Sync All"), this);
actionCollection()->addAction(QStringLiteral("kontact_summary_sync"), mSyncAction);
connect(mSyncAction, qOverload<QAction *>(&KSelectAction::triggered), this, &SummaryView::syncAccount);
connect(mSyncAction, &KSelectAction::triggered, this, &SummaryView::syncAccount);
connect(mSyncAction->menu(), &QMenu::aboutToShow, this, &SummaryView::fillSyncActionSubEntries);
insertSyncAction(mSyncAction);
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment