Add missing override + const'ify pointer

(cherry picked from commit fd968aca)

kmail-refresh-settings/refreshsettingsassistant.h

@@ -16,7 +16,7 @@ class RefreshSettingsAssistant : public KAssistantDialog
     Q_OBJECT
 public:
     explicit RefreshSettingsAssistant(QWidget *parent = nullptr);
-    ~RefreshSettingsAssistant();
+    ~RefreshSettingsAssistant() override;
 
 private:
     void initializePages();

kmail-refresh-settings/refreshsettingscleanuppage.h

@@ -15,7 +15,7 @@ class RefreshSettingsCleanupPage : public QWidget
     Q_OBJECT
 public:
     explicit RefreshSettingsCleanupPage(QWidget *parent = nullptr);
-    ~RefreshSettingsCleanupPage();
+    ~RefreshSettingsCleanupPage() override;
 
 Q_SIGNALS:
     void cleanDoneInfo(const QString &msg);

kmail-refresh-settings/refreshsettingsfirstpage.h

@@ -14,7 +14,7 @@ class RefreshSettingsFirstPage : public QWidget
     Q_OBJECT
 public:
     explicit RefreshSettingsFirstPage(QWidget *parent = nullptr);
-    ~RefreshSettingsFirstPage();
+    ~RefreshSettingsFirstPage() override;
 };
 
 #endif // REFRESHSETTINGSFIRSTPAGE_H

kmail-refresh-settings/refreshsettringsfinishpage.h

@@ -14,7 +14,7 @@ class RefreshSettringsFinishPage : public QWidget
     Q_OBJECT
 public:
     explicit RefreshSettringsFinishPage(QWidget *parent = nullptr);
-    ~RefreshSettringsFinishPage();
+    ~RefreshSettringsFinishPage() override;
 
 Q_SIGNALS:
     void cleanDoneInfo(const QString &info);

src/autotests/createfollowupreminderonexistingmessagejobtest.h

@@ -14,7 +14,7 @@ class CreateFollowupReminderOnExistingMessageJobTest : public QObject
     Q_OBJECT
 public:
     explicit CreateFollowupReminderOnExistingMessageJobTest(QObject *parent = nullptr);
-    ~CreateFollowupReminderOnExistingMessageJobTest();
+    ~CreateFollowupReminderOnExistingMessageJobTest() override;
 private Q_SLOTS:
     void shouldHaveDefaultValue();
     void shouldValidBeforeStartJob();

src/autotests/cryptostateindicatorwidgettest.h

@@ -14,7 +14,7 @@ class CryptoStateIndicatorWidgetTest : public QObject
     Q_OBJECT
 public:
     explicit CryptoStateIndicatorWidgetTest(QObject *parent = nullptr);
-    ~CryptoStateIndicatorWidgetTest();
+    ~CryptoStateIndicatorWidgetTest() override;
 private Q_SLOTS:
     void shouldHaveDefaultValue();
     void shouldBeNotVisibleWhenShowAlwaysIsFalse();

src/autotests/displaymessageformatactionmenutest.cpp

@@ -7,6 +7,7 @@
 #include "displaymessageformatactionmenutest.h"
 #include "../widgets/displaymessageformatactionmenu.h"
 #include <KToggleAction>
+#include <QMenu>
 #include <QSignalSpy>
 #include <QTest>
 #include <qtestmouse.h>

src/autotests/identityaddvcarddialogtest.cpp

@@ -13,7 +13,10 @@
 
 #include <QTest>
 
-identityaddvcarddialogtest::identityaddvcarddialogtest() = default;
+identityaddvcarddialogtest::identityaddvcarddialogtest(QObject *parent)
+    : QObject(parent)
+{
+}
 
 void identityaddvcarddialogtest::shouldHaveDefaultValue()
 {

src/autotests/identityaddvcarddialogtest.h

@@ -13,7 +13,7 @@ class identityaddvcarddialogtest : public QObject
 {
     Q_OBJECT
 public:
-    identityaddvcarddialogtest();
+    explicit identityaddvcarddialogtest(QObject *parent = nullptr);
 
 private Q_SLOTS:
     void shouldHaveDefaultValue();

src/autotests/kactionmenutransporttest.h

@@ -14,7 +14,7 @@ class KActionMenuTransportTest : public QObject
     Q_OBJECT
 public:
     explicit KActionMenuTransportTest(QObject *parent = nullptr);
-    ~KActionMenuTransportTest();
+    ~KActionMenuTransportTest() override;
 private Q_SLOTS:
     void shouldHaveDefaultValue();
 };

src/autotests/kmcommandstest.h

@@ -16,7 +16,7 @@ class KMCommandsTest : public QObject
     Q_OBJECT
 public:
     explicit KMCommandsTest(QObject *parent = nullptr);
-    ~KMCommandsTest();
+    ~KMCommandsTest() override;
 private Q_SLOTS:
     void testMailtoReply();
     void testReply();

src/autotests/kmcomposerwintest.h

@@ -7,8 +7,8 @@
 #ifndef KMCOMPOSERWINTEST_H
 #define KMCOMPOSERWINTEST_H
 
+#include <QDir>
 #include <QObject>
-
 class KMKernel;
 
 class KMComposerWinTest : public QObject
@@ -16,8 +16,8 @@ class KMComposerWinTest : public QObject
     Q_OBJECT
 public:
     explicit KMComposerWinTest(QObject *parent = nullptr);
-    ~KMComposerWinTest();
-    
+    ~KMComposerWinTest() override;
+
 private Q_SLOTS:
     void init();
     void cleanup();

src/autotests/tagselectdialogtest.h

@@ -14,7 +14,7 @@ class TagSelectDialogTest : public QObject
     Q_OBJECT
 public:
     explicit TagSelectDialogTest(QObject *parent = nullptr);
-    ~TagSelectDialogTest();
+    ~TagSelectDialogTest() override;
 private Q_SLOTS:
     void shouldHaveDefaultValue();
     void initTestCase();

src/collectionpage/collectionquotawidget.cpp

@@ -16,19 +16,19 @@
 
 CollectionQuotaWidget::CollectionQuotaWidget(QWidget *parent)
     : QWidget(parent)
+    , mUsage(new QLabel(this))
+    , mProgressBar(new QProgressBar(this))
 {
     auto layout = new QGridLayout(this);
 
     auto lab = new QLabel(i18n("Usage:"), this);
     layout->addWidget(lab, 0, 0);
 
-    mUsage = new QLabel(this);
     mUsage->setTextFormat(Qt::PlainText);
     layout->addWidget(mUsage, 0, 1);
 
     auto Status = new QLabel(i18n("Status:"), this);
     layout->addWidget(Status, 1, 0);
-    mProgressBar = new QProgressBar(this);
     // xgettext: no-c-format
     mProgressBar->setFormat(i18n("%p% full"));
     layout->addWidget(mProgressBar, 1, 1);

src/collectionpage/collectionquotawidget.h

@@ -24,8 +24,8 @@ public:
     void setQuotaInfo(qint64 currentValue, qint64 maxValue);
 
 private:
-    QProgressBar *mProgressBar = nullptr;
-    QLabel *mUsage = nullptr;
+    QProgressBar *const mProgressBar;
+    QLabel *const mUsage;
 };
 
 #endif /* COLLECTIONQUOTAWIDGET_H */

src/dialog/kmknotify.h

@@ -17,7 +17,7 @@ class KMKnotify : public QDialog
 {
     Q_OBJECT
 public:
-    explicit KMKnotify(QWidget *parent);
+    explicit KMKnotify(QWidget *parent = nullptr);
     ~KMKnotify() override;
 
     void setCurrentNotification(const QString &name);

src/editor/potentialphishingemail/autotests/potentialphishingdetaildialogtest.h

@@ -15,7 +15,7 @@ class PotentialPhishingDetailDialogTest : public QObject
     Q_OBJECT
 public:
     explicit PotentialPhishingDetailDialogTest(QObject *parent = nullptr);
-    ~PotentialPhishingDetailDialogTest();
+    ~PotentialPhishingDetailDialogTest() override;
 private Q_SLOTS:
     void shouldHaveDefaultValue();
     void initTestCase();

src/editor/potentialphishingemail/autotests/potentialphishingdetailwidgettest.h

@@ -15,7 +15,7 @@ class PotentialPhishingDetailWidgetTest : public QObject
     Q_OBJECT
 public:
     explicit PotentialPhishingDetailWidgetTest(QObject *parent = nullptr);
-    ~PotentialPhishingDetailWidgetTest();
+    ~PotentialPhishingDetailWidgetTest() override;
 private Q_SLOTS:
     void shouldHaveDefaultValue();
     void shouldFillList();

src/editor/potentialphishingemail/autotests/potentialphishingemailjobtest.h

@@ -15,7 +15,7 @@ class PotentialPhishingEmailJobTest : public QObject
     Q_OBJECT
 public:
     explicit PotentialPhishingEmailJobTest(QObject *parent = nullptr);
-    ~PotentialPhishingEmailJobTest();
+    ~PotentialPhishingEmailJobTest() override;
 
 private Q_SLOTS:
     void shouldNotStartIfNoEmails();

src/editor/potentialphishingemail/autotests/potentialphishingemailwarningtest.h

@@ -15,7 +15,7 @@ class PotentialPhishingEmailWarningTest : public QObject
     Q_OBJECT
 public:
     explicit PotentialPhishingEmailWarningTest(QObject *parent = nullptr);
-    ~PotentialPhishingEmailWarningTest();
+    ~PotentialPhishingEmailWarningTest() override;
 private Q_SLOTS:
     void shouldHaveDefaultValue();
 };