Commit f30e1048 authored by Laurent Montel's avatar Laurent Montel 😁
Browse files

Add missing Q_REQUIRED_RESULT

parent 02c8e7d5
Pipeline #175282 passed with stage
in 6 minutes and 5 seconds
......@@ -25,7 +25,7 @@ public:
void deserialize(const QByteArray &data) override;
void setTaskId(Akonadi::Item::Id id);
Akonadi::Item::Id taskId() const;
Q_REQUIRED_RESULT Akonadi::Item::Id taskId() const;
private:
Akonadi::Item::Id mId = {-1};
......
......@@ -36,5 +36,5 @@ private:
void drawFocus(QPainter *, const QStyleOptionViewItem &, const QRect &) const;
QTextDocument *document(const QStyleOptionViewItem &option, const QModelIndex &index) const;
QStyleOptionButton buttonOption(const QStyleOptionViewItem &option) const;
Q_REQUIRED_RESULT QStyleOptionButton buttonOption(const QStyleOptionViewItem &option) const;
};
......@@ -58,7 +58,7 @@ class KMAIL_EXPORT MiscPage : public ConfigModuleWithTabs
Q_OBJECT
public:
explicit MiscPage(QWidget *parent = nullptr, const QVariantList &args = {});
QString helpAnchor() const override;
Q_REQUIRED_RESULT QString helpAnchor() const override;
};
class MiscPagePrintingTab : public ConfigModuleTab
......
......@@ -44,7 +44,7 @@ class SecurityPageMDNTab : public ConfigModuleTab
Q_OBJECT
public:
explicit SecurityPageMDNTab(QWidget *parent = nullptr);
QString helpAnchor() const;
Q_REQUIRED_RESULT QString helpAnchor() const;
void save() override;
......@@ -65,7 +65,7 @@ public:
explicit SecurityPageComposerCryptoTab(QWidget *parent = nullptr);
~SecurityPageComposerCryptoTab() override;
QString helpAnchor() const;
Q_REQUIRED_RESULT QString helpAnchor() const;
void save() override;
......@@ -84,7 +84,7 @@ public:
explicit SecurityPageWarningTab(QWidget *parent = nullptr);
~SecurityPageWarningTab() override;
QString helpAnchor() const;
Q_REQUIRED_RESULT QString helpAnchor() const;
void save() override;
......@@ -105,7 +105,7 @@ public:
explicit SecurityPageSMimeTab(QWidget *parent = nullptr);
~SecurityPageSMimeTab() override;
QString helpAnchor() const;
Q_REQUIRED_RESULT QString helpAnchor() const;
void save() override;
......@@ -138,5 +138,5 @@ class KMAIL_EXPORT SecurityPage : public ConfigModuleWithTabs
public:
explicit SecurityPage(QWidget *parent = nullptr, const QVariantList &args = {});
QString helpAnchor() const override;
Q_REQUIRED_RESULT QString helpAnchor() const override;
};
......@@ -29,7 +29,7 @@ public:
// TODO add body ? or editor
void initializePlugins();
bool execute(const MessageComposer::PluginEditorCheckBeforeSendParams &params) const;
Q_REQUIRED_RESULT bool execute(const MessageComposer::PluginEditorCheckBeforeSendParams &params) const;
private:
Q_DISABLE_COPY(KMailPluginEditorCheckBeforeSendManagerInterface)
......
......@@ -21,15 +21,15 @@ class KMailPluginEditorConvertTextManagerInterface : public QObject
public:
explicit KMailPluginEditorConvertTextManagerInterface(QObject *parent = nullptr);
~KMailPluginEditorConvertTextManagerInterface() override;
QWidget *parentWidget() const;
Q_REQUIRED_RESULT QWidget *parentWidget() const;
void setParentWidget(QWidget *parentWidget);
KActionCollection *actionCollection() const;
Q_REQUIRED_RESULT KActionCollection *actionCollection() const;
void setActionCollection(KActionCollection *actionCollection);
void initializePlugins();
KPIMTextEdit::RichTextComposer *richTextEditor() const;
Q_REQUIRED_RESULT KPIMTextEdit::RichTextComposer *richTextEditor() const;
void setRichTextEditor(KPIMTextEdit::RichTextComposer *richTextEditor);
Q_REQUIRED_RESULT QHash<MessageComposer::PluginActionType::Type, QList<QAction *>> actionsType();
......
......@@ -19,10 +19,10 @@ public:
explicit KMailPluginEditorInitManagerInterface(QObject *parent = nullptr);
~KMailPluginEditorInitManagerInterface() override = default;
KPIMTextEdit::RichTextComposer *richTextEditor() const;
Q_REQUIRED_RESULT KPIMTextEdit::RichTextComposer *richTextEditor() const;
void setRichTextEditor(KPIMTextEdit::RichTextComposer *richTextEditor);
QWidget *parentWidget() const;
Q_REQUIRED_RESULT QWidget *parentWidget() const;
void setParentWidget(QWidget *parentWidget);
void initializePlugins();
......
......@@ -26,15 +26,15 @@ public:
explicit KMailPluginEditorManagerInterface(QObject *parent = nullptr);
~KMailPluginEditorManagerInterface() override;
KPIMTextEdit::RichTextEditor *richTextEditor() const;
Q_REQUIRED_RESULT KPIMTextEdit::RichTextEditor *richTextEditor() const;
void setRichTextEditor(KPIMTextEdit::RichTextEditor *richTextEditor);
QWidget *parentWidget() const;
Q_REQUIRED_RESULT QWidget *parentWidget() const;
void setParentWidget(QWidget *parentWidget);
void initializePlugins();
KActionCollection *actionCollection() const;
Q_REQUIRED_RESULT KActionCollection *actionCollection() const;
void setActionCollection(KActionCollection *actionCollection);
Q_REQUIRED_RESULT QHash<MessageComposer::PluginActionType::Type, QList<QAction *>> actionsType();
......
......@@ -23,17 +23,17 @@ public:
explicit KMailPluginGrammarEditorManagerInterface(QObject *parent = nullptr);
~KMailPluginGrammarEditorManagerInterface() override = default;
KPIMTextEdit::RichTextComposer *richTextEditor() const;
Q_REQUIRED_RESULT KPIMTextEdit::RichTextComposer *richTextEditor() const;
void setRichTextEditor(KPIMTextEdit::RichTextComposer *richTextEditor);
QWidget *parentWidget() const;
Q_REQUIRED_RESULT QWidget *parentWidget() const;
void setParentWidget(QWidget *parentWidget);
void initializePlugins();
KActionCollection *actionCollection() const;
Q_REQUIRED_RESULT KActionCollection *actionCollection() const;
void setActionCollection(KActionCollection *actionCollection);
PimCommon::CustomToolsWidgetNg *customToolsWidget() const;
Q_REQUIRED_RESULT PimCommon::CustomToolsWidgetNg *customToolsWidget() const;
void setCustomToolsWidget(PimCommon::CustomToolsWidgetNg *customToolsWidget);
private:
......
......@@ -68,6 +68,7 @@ K_PLUGIN_CLASS_WITH_JSON(KCMKontactSummary, "kcmkontactsummary.json")
KCMKontactSummary::KCMKontactSummary(QWidget *parent, const QVariantList &args)
: KCModule(parent, args)
, mPluginView(new PluginView(this))
{
auto layout = new QVBoxLayout(this);
layout->setContentsMargins({});
......@@ -75,7 +76,6 @@ KCMKontactSummary::KCMKontactSummary(QWidget *parent, const QVariantList &args)
auto label = new QLabel(i18n("Select the plugin summaries to show on the summary page."), this);
layout->addWidget(label);
mPluginView = new PluginView(this);
layout->addWidget(mPluginView);
layout->setStretchFactor(mPluginView, 1);
......
......@@ -32,5 +32,5 @@ public:
void save() override;
private:
PluginView *mPluginView = nullptr;
PluginView *const mPluginView;
};
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment