GitLab

back

(cherry picked from commit 78147c2c)

It doesn't open any dialog so the "..." is wrong and "set" is a
more accurate action than "select" for this button. This is also
closer to the original text.

Added contributors' email addresses, where those were missing. Clarified contributors' roles.
Added comments to clarify when contributors were active, and how active each one has been.

Jonathan Marten authored Sep 19, 2021 and Laurent Montel committed Sep 21, 2021

This appears to be a consequence of commits 3e34c9f0 and 22d1bab9.
When the system tray icon is active, closing the main window should
merely hide it but keep KMail running in the background.  However,
the test "if (KMMainWidget::mainWidgetList())" in KMKernel::canQueryClose()
seems to be incorect, it is saying "if there is a main window, then
allow the close".  The effect is that KMail quits when the window is
closed.

The test may have been incorrect for a long time, but masked by the
second part of the conditional "and if there is more than one main
window" before commit 3e34c9f0.  Most users will only have one KMail
main window open and so will never satisfy the condition.

Reversing the test restores the correct behaviour, so that KMail keeps
running in the background (with the system tray icon shown if enabled)
when the main window is closed.