Members of the KDE Community are recommended to subscribe to the kde-community mailing list at https://mail.kde.org/mailman/listinfo/kde-community to allow them to participate in important discussions and receive other important announcements

Commit a7ccd0d6 authored by Laurent Montel's avatar Laurent Montel 😁

Coding style

parent bb726f87
......@@ -128,10 +128,11 @@ void CollectionMailingListPage::init(const Akonadi::Collection &col)
connect(mEditList, &KEditListWidget::changed, this, &CollectionMailingListPage::slotConfigChanged);
groupLayout->addWidget(mEditList, 7, 0, 1, 4);
//Order is important because the activate handler and fillMLFromWidgets
//depend on it
const QStringList el {i18n("Post to List"), i18n("Subscribe to List"), i18n("Unsubscribe From List"), i18n("List Archives"), i18n("List Help")};
const QStringList el {
i18n("Post to List"), i18n("Subscribe to List"), i18n("Unsubscribe From List"), i18n("List Archives"), i18n("List Help")
};
mAddressCombo->addItems(el);
connect(mAddressCombo, QOverload<int>::of(&KComboBox::activated), this, &CollectionMailingListPage::slotAddressChanged);
......
......@@ -229,7 +229,7 @@ void AccountsPageReceivingTab::slotAddMailAccount()
const QString path = QStandardPaths::findExecutable(QStringLiteral("accountwizard"));
if (!QProcess::startDetached(path, lst)) {
KMessageBox::error(this, i18n("Could not start the account wizard. "
"Please make sure you have AccountWizard properly installed."),
"Please make sure you have AccountWizard properly installed."),
i18n("Unable to start account wizard"));
}
}
......
......@@ -443,7 +443,6 @@ KMComposerWin::KMComposerWin(const KMime::Message::Ptr &aMsg, bool lastSignState
connect(mPotentialPhishingEmailWarning, &PotentialPhishingEmailWarning::sendNow, this, &KMComposerWin::slotCheckSendNowStep2);
v->addWidget(mPotentialPhishingEmailWarning);
if (KMailSettings::self()->showForgottenAttachmentWarning()) {
mVerifyMissingAttachment = new QTimer(this);
mVerifyMissingAttachment->setSingleShot(true);
......@@ -865,7 +864,7 @@ void KMComposerWin::rethinkFields(bool fromSlot, bool forceAllHeaders)
}
rethinkHeaderLine(showHeaders, HDR_REPLY_TO, row, mLblReplyTo, mEdtReplyTo);
if (showHeaders & HDR_REPLY_TO) {
(void) connectFocusMoving(prevFocus, mEdtReplyTo);
(void)connectFocusMoving(prevFocus, mEdtReplyTo);
}
mGrid->addWidget(mComposerBase->recipientsEditor(), row, 0, 1, 2);
......
......@@ -535,7 +535,6 @@ private:
void slotCryptoModuleSelected();
void slotFccIsInvalid();
void updateComposerAfterIdentityChanged(const KIdentityManagement::Identity &ident, uint uoid, bool wasModified);
void insertUrls(const QMimeData *source, const QList<QUrl> &urlList);
......
......@@ -31,7 +31,6 @@ IncorrectIdentityFolderWarning::IncorrectIdentityFolderWarning(QWidget *parent)
IncorrectIdentityFolderWarning::~IncorrectIdentityFolderWarning()
{
}
void IncorrectIdentityFolderWarning::mailTransportIsInvalid()
......
......@@ -66,7 +66,7 @@ void RemoveDuplicateMessageInFolderAndSubFolderJob::slotFetchCollectionDone(cons
Akonadi::Collection::List lst;
for (const Akonadi::Collection &collection : list) {
if (collection.isValid()) {
if(collection.rights() & Akonadi::Collection::CanDeleteItem) {
if (collection.rights() & Akonadi::Collection::CanDeleteItem) {
lst.append(collection);
}
}
......
......@@ -24,8 +24,7 @@
#include <QObject>
#include <AkonadiCore/Collection>
class KJob;
namespace KPIM
{
namespace KPIM {
class ProgressItem;
}
class RemoveDuplicateMessageInFolderAndSubFolderJob : public QObject
......
......@@ -93,7 +93,7 @@ KMReaderWin::KMReaderWin(QWidget *aParent, QWidget *mainWindow, KActionCollectio
QVBoxLayout *vlay = new QVBoxLayout(this);
vlay->setContentsMargins(0, 4, 0, 0);
mViewer = new Viewer(this, mainWindow, mActionCollection);
connect(mViewer, QOverload<const Akonadi::Item &, const QUrl&>::of(&Viewer::urlClicked), this, &KMReaderWin::slotUrlClicked);
connect(mViewer, QOverload<const Akonadi::Item &, const QUrl &>::of(&Viewer::urlClicked), this, &KMReaderWin::slotUrlClicked);
connect(mViewer, &Viewer::requestConfigSync, kmkernel, &KMKernel::slotRequestConfigSync, Qt::QueuedConnection); // happens anyway on shutdown, so we can skip it there with using a queued connection
connect(mViewer, &Viewer::makeResourceOnline, kmkernel, &KMKernel::makeResourceOnline);
connect(mViewer, &MessageViewer::Viewer::showReader, this, &KMReaderWin::slotShowReader);
......
......@@ -422,7 +422,7 @@ void MessageActions::updateMailingListActions(const Akonadi::Item &messageItem)
qDeleteAll(mMailListActionList);
mMailListActionList.clear();
if (!listId.isEmpty()) {
mMailingListActionMenu->menu()->setTitle(i18n("Mailing List Name: %1",listId));
mMailingListActionMenu->menu()->setTitle(i18n("Mailing List Name: %1", listId));
}
if (mailList.features() & MessageCore::MailingList::ArchivedAt) {
// IDEA: this may be something you want to copy - "Copy in submenu"?
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment