Add missing override

src/kmailtransport/plugins/transportabstractplugin.h

@@ -34,7 +34,7 @@ class MAILTRANSPORT_EXPORT TransportAbstractPlugin : public QObject
     Q_OBJECT
 public:
     explicit TransportAbstractPlugin(QObject *parent = nullptr);
-    ~TransportAbstractPlugin();
+    ~TransportAbstractPlugin() override;
 
     Q_REQUIRED_RESULT virtual TransportJob *createTransportJob(MailTransport::Transport *t, const QString &identifier) = 0;
     Q_REQUIRED_RESULT virtual QVector<TransportAbstractPluginInfo> names() const = 0;

src/kmailtransport/plugins/transportpluginmanager.h

@@ -17,7 +17,7 @@ class KMAILTRANSPORT_TESTS_EXPORT TransportPluginManager : public QObject
     Q_OBJECT
 public:
     explicit TransportPluginManager(QObject *parent = nullptr);
-    ~TransportPluginManager();
+    ~TransportPluginManager() override;
 
     static TransportPluginManager *self();
 

src/kmailtransport/servertest.h

@@ -49,12 +49,12 @@ public:
      *
      * @param parent The parent widget.
      */
-    ServerTest(QObject *parent = nullptr);
+    explicit ServerTest(QObject *parent = nullptr);
 
     /**
      * Destroys the server test.
      */
-    ~ServerTest();
+    ~ServerTest() override;
 
     /**
      * Sets the server to test.
@@ -64,7 +64,7 @@ public:
     /**
      * Returns the server to test.
      */
-    QString server() const;
+    Q_REQUIRED_RESULT QString server() const;
 
     /**
      * Set a custom port to use.
@@ -97,7 +97,7 @@ public:
      *
      * @since 4.1
      */
-    int port(Transport::EnumEncryption::type encryptionMode) const;
+    Q_REQUIRED_RESULT int port(Transport::EnumEncryption::type encryptionMode) const;
 
     /**
      * Sets a fake hostname for the test. This is currently only used when
@@ -114,7 +114,7 @@ public:
     /**
      * @return the fake hostname, as set before with @ref setFakeHostname
      */
-    QString fakeHostname() const;
+    Q_REQUIRED_RESULT QString fakeHostname() const;
 
     /**
      * Makes @p pb the progressbar to use. This class will call show()
@@ -137,7 +137,7 @@ public:
     /**
      * Returns the protocol.
      */
-    QString protocol() const;
+    Q_REQUIRED_RESULT QString protocol() const;
 
     /**
      * Starts the test. Will emit finished() when done.
@@ -149,13 +149,13 @@ public:
      * after the finished() signals has been sent.
      * @return an enum of the type Transport::EnumAuthenticationType
      */
-    QVector<int> normalProtocols() const;
+    Q_REQUIRED_RESULT QVector<int> normalProtocols() const;
 
     /**
      * tells you if the normal server is available
      * @since 4.5
      */
-    bool isNormalPossible() const;
+    Q_REQUIRED_RESULT bool isNormalPossible() const;
 
     /**
      * Get the protocols for the TLS connections. Call this only
@@ -163,20 +163,20 @@ public:
      * @return an enum of the type Transport::EnumAuthenticationType
      * @since 4.1
      */
-    QVector<int> tlsProtocols() const;
+    Q_REQUIRED_RESULT QVector<int> tlsProtocols() const;
 
     /**
      * Get the protocols for the SSL connections. Call this only
      * after the finished() signals has been sent.
      * @return an enum of the type Transport::EnumAuthenticationType
      */
-    QVector<int> secureProtocols() const;
+    Q_REQUIRED_RESULT QVector<int> secureProtocols() const;
 
     /**
      * tells you if the ssl server is available
      * @since 4.5
      */
-    bool isSecurePossible() const;
+    Q_REQUIRED_RESULT bool isSecurePossible() const;
 
     /**
      * Get the special capabilities of the server.
@@ -185,7 +185,7 @@ public:
      * @return the list of special capabilities of the server.
      * @since 4.1
      */
-    QList<Capability> capabilities() const;
+    Q_REQUIRED_RESULT QList<Capability> capabilities() const;
 
 Q_SIGNALS:
     /**

src/kmailtransport/transport.h

@@ -94,7 +94,7 @@ public:
 
       @since 4.5
     */
-    static QString authenticationTypeString(int type);
+    static Q_REQUIRED_RESULT QString authenticationTypeString(int type);
 
     /**
       Returns a deep copy of this Transport object which will no longer be
@@ -126,7 +126,7 @@ protected:
     /**
       Returns true if the password was not stored in the wallet.
     */
-    bool needsWalletMigration() const;
+    Q_REQUIRED_RESULT bool needsWalletMigration() const;
 
     /**
       Try to migrate the password from the config file to the wallet.

src/kmailtransport/transportjob.h

@@ -90,27 +90,27 @@ protected:
     /**
       Returns the sender of the mail.
     */
-    QString sender() const;
+    Q_REQUIRED_RESULT QString sender() const;
 
     /**
       Returns the "To" receiver(s) of the mail.
     */
-    QStringList to() const;
+    Q_REQUIRED_RESULT QStringList to() const;
 
     /**
       Returns the "Cc" receiver(s) of the mail.
     */
-    QStringList cc() const;
+    Q_REQUIRED_RESULT QStringList cc() const;
 
     /**
       Returns the "Bcc" receiver(s) of the mail.
     */
-    QStringList bcc() const;
+    Q_REQUIRED_RESULT QStringList bcc() const;
 
     /**
       Returns the data of the mail.
     */
-    QByteArray data() const;
+    Q_REQUIRED_RESULT QByteArray data() const;
 
     /**
       Returns a QBuffer opened on the message data. This is useful for

src/kmailtransportakonadi/dispatchmodeattribute.h

@@ -46,15 +46,15 @@ public:
 
     /* reimpl */
     DispatchModeAttribute *clone() const override;
-    QByteArray type() const override;
-    QByteArray serialized() const override;
+    Q_REQUIRED_RESULT QByteArray type() const override;
+    Q_REQUIRED_RESULT QByteArray serialized() const override;
     void deserialize(const QByteArray &data) override;
 
     /**
       Returns the dispatch mode for the message.
       @see DispatchMode.
     */
-    DispatchMode dispatchMode() const;
+    Q_REQUIRED_RESULT DispatchMode dispatchMode() const;
 
     /**
       Sets the dispatch mode for the message.
@@ -67,7 +67,7 @@ public:
       Returns the date and time when the message should be sent.
       Only valid if dispatchMode() is Automatic.
     */
-    QDateTime sendAfter() const;
+    Q_REQUIRED_RESULT QDateTime sendAfter() const;
 
     /**
       Sets the date and time when the message should be sent.

src/kmailtransportakonadi/errorattribute.h

@@ -40,7 +40,7 @@ public:
     /**
      * Returns the i18n'ed error message.
      */
-    QString message() const;
+    Q_REQUIRED_RESULT QString message() const;
 
     /**
      * Sets the i18n'ed error message.
@@ -49,8 +49,8 @@ public:
 
     /* reimpl */
     ErrorAttribute *clone() const override;
-    QByteArray type() const override;
-    QByteArray serialized() const override;
+    Q_REQUIRED_RESULT QByteArray type() const override;
+    Q_REQUIRED_RESULT QByteArray serialized() const override;
     void deserialize(const QByteArray &data) override;
 
 private:

src/kmailtransportakonadi/transportattribute.h

@@ -46,7 +46,7 @@ public:
       Returns the transport id to use for sending this message.
       @see TransportManager.
     */
-    int transportId() const;
+    Q_REQUIRED_RESULT int transportId() const;
 
     /**
       Returns the transport object corresponding to the transport id contained