Port some code to for(...:...)

src/kmailtransport/tests/transportmgr.cpp

@@ -78,7 +78,7 @@ TransportMgr::TransportMgr()
 void TransportMgr::removeAllBtnClicked()
 {
     MailTransport::TransportManager *manager = MailTransport::TransportManager::self();
-    QList<Transport *> transports = manager->transports();
+    const QList<Transport *> transports = manager->transports();
     for (int i = 0; i < transports.count(); i++) {
         MailTransport::Transport *transport = transports.at(i);
         qDebug() << transport->host();

src/kmailtransport/transportjob.cpp

@@ -35,12 +35,12 @@ public:
     {
     }
 
-    Transport *transport;
     QString sender;
     QStringList to;
     QStringList cc;
     QStringList bcc;
     QByteArray data;
+    Transport *transport;
     QBuffer *buffer;
 };
 

src/kmailtransport/transportmanager.cpp

@@ -583,7 +583,7 @@ void TransportManagerPrivate::prepareWallet()
 
 void TransportManager::loadPasswords()
 {
-    foreach (Transport *t, d->transports) {
+    for (Transport *t : qAsConst(d->transports)) {
         t->readPassword();
     }
 
@@ -603,7 +603,7 @@ void TransportManager::loadPasswordsAsync()
 
     // check if there is anything to do at all
     bool found = false;
-    foreach (Transport *t, d->transports) {
+    for (Transport *t : qAsConst(d->transports)) {
         if (!t->isComplete()) {
             found = true;
             break;
@@ -706,7 +706,7 @@ void TransportManagerPrivate::migrateToWallet()
     }
 
     // perform migration
-    foreach (Transport *t, transports) {
+    for (Transport *t : qAsConst(transports)) {
         if (t->needsWalletMigration()) {
             t->migrateToWallet();
         }